Skip to content

[Due for payment 2025-03-17] Add feed syntax key #56855

Closed

Description

@luacmartins

Problem

When users select a card feed, we currently select all cards in the feed and use the card: syntax key with those cardIDs. That's worked so far, but it creates an issue where saving this search will save a static list of cardIDs and won't reflect any cards added/removed from the feed.

Why is this important?

Feature should handle a dynamic list of cards

Solution

Keep the UI the same, but use a feed syntax key in search that'll pass the fundID to the backend

cc @SzymczakJ

Issue OwnerCurrent Issue Owner: @sobitneupane
Issue OwnerCurrent Issue Owner: @maddylewis

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 13, 2025
  2. self-assigned this
    on Feb 13, 2025
  3. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 13, 2025
  4. melvin-bot commented on Feb 13, 2025

    @melvin-bot

    Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. maddylewis commented on Feb 14, 2025

    @maddylewis
    Contributor

    @luacmartins - since you removed the BUG label, i don't think I'm needed on this issue so I'm going to unassign myself. if im misinterpreting, just lmk!

  6. removed their assignment
    on Feb 14, 2025
  7. JakubKorytko commented on Feb 17, 2025

    @JakubKorytko
    Member

    Hello my name is Jakub and I work for SWM expert agency. I would like to work on this task, please assign me.

  8. melvin-bot commented on Feb 17, 2025

    @melvin-bot

    📣 @JakubKorytko! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  9. changed the title [-]Add `fund` syntax key[/-] [+]Add `feed` syntax key[/+] on Feb 17, 2025
  10. 42 remaining items

  11. luacmartins commented on Mar 17, 2025

    @luacmartins
    ContributorAuthor

    Reassigning @maddylewis for payment based on this comment #56855 (comment)

  12. maddylewis commented on Mar 18, 2025

    @maddylewis
    Contributor

    on it!

  13. maddylewis commented on Mar 18, 2025

    @maddylewis
    Contributor

    Payment Overview

  14. maddylewis commented on Mar 18, 2025

    @maddylewis
    Contributor

    @sobitneupane - are you due payment for this issue? if yes, can you confirm the payment amount? ty!

  15. sobitneupane commented on Mar 19, 2025

    @sobitneupane
    Contributor

    @maddylewis Yes, I believe it's the usual $250.

  16. maddylewis commented on Mar 19, 2025

    @maddylewis
  17. sobitneupane commented on Mar 20, 2025

    @sobitneupane
    Contributor

    @maddylewis I don’t think we need a checklist here. This is an improvement to an existing feature rather than a bug.

  18. sobitneupane commented on Mar 20, 2025

    @sobitneupane
    Contributor

    Regression Test Proposal:

    1. Click on the search anywhere in the application.
    2. Type in feed: followed by existing card feed (workspace or domain).
    3. After accepting the search, verify that:
    • Display name of the feed is visible in the search input.
    • Query in the URL and request sent to the server contains key feed: fundID_bank.
    1. Click on the advanced search filters anywhere in the application.
    2. Select any feed in the Card row.
    3. Check step 3 in the test above.
    4. Deselect any card from the selected feed, save it and verify that the list of cards is displayed instead of the feed.

    Do we agree 👍 or 👎

  19. maddylewis commented on Mar 20, 2025

    @maddylewis
    Contributor

    @luacmartins - does this regression test proposal sound good? #56855 (comment)

  20. luacmartins commented on Mar 20, 2025

    @luacmartins
    ContributorAuthor

    Yea, that's good

  21. maddylewis commented on Mar 21, 2025

    @maddylewis
    Contributor
    • regression test added ✅
    • payment summary posted ✅
    • contract / ND payment

    closing!

  22. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Mar 21, 2025
  23. garrettmknight commented on May 20, 2025

    @garrettmknight
    Contributor

    $250 approved for @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions