Skip to content

[Due for payment 2025-03-27] [HIGH] The expense to be approved is not appearing at the bottom of the expense report ordered by date on report action #56859

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Deliverable

The deliverable is to provide reliable reproduction steps for the bug. - Follow the Propose a solution for a job process to submit the steps for review”. Inc. preconditions and additional details if they’re helpful. (ie. require x beta to be enabled, must be on a Collect plan)

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation (hyperlinked to channel name): quality

Action Performed:

  1. User A submits an expense to approver in a report with multiple card expenses
  2. Approver sees a GBR in the LHN

Expected Result:

Expense to be approved appears as the last message in the expense report

Actual Result:

Expense to be approved appears somewhere on the top and user has to scroll up to find the report
It should be ordered by the date on the reportAction.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Please check OP in slack

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. melvin-bot commented on Feb 13, 2025

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  2. melvin-bot commented on Feb 13, 2025

    @melvin-bot

    Triggered auto assignment to @puneetlath (AutoAssignerNewDotQuality)

  3. MelvinBot commented on Feb 13, 2025

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. changed the title [-]The expense to be approved is not appearing at the bottom of the expense report ordered by date on report action[/-] [+][CRITICAL] The expense to be approved is not appearing at the bottom of the expense report ordered by date on report action[/+] on Feb 16, 2025
  5. 39 remaining items

  6. changed the title [-][HIGH] The expense to be approved is not appearing at the bottom of the expense report ordered by date on report action[/-] [+][Due for payment 2025-03-27] [HIGH] The expense to be approved is not appearing at the bottom of the expense report ordered by date on report action[/+] on Mar 20, 2025
  7. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  8. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-27. 🎊

    For reference, here are some details about the assignees on this issue:

  9. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    @abdulrahuman5196 @VictoriaExpensify @abdulrahuman5196 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  10. melvin-bot commented on Mar 27, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@VictoriaExpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. VictoriaExpensify commented on Mar 28, 2025

    @VictoriaExpensify
    Contributor

    Payment summary:
    Contributor: @sosek108 is from an agency-contributor and not due payment
    C+: @abdulrahuman5196 owed $250 via NewDot

  12. abdulrahuman5196 commented on Apr 10, 2025

    @abdulrahuman5196
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Not a regression. We fixed a possible edge case.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. - N/A Existing normal test should be fine for this case.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  13. JmillsExpensify commented on Apr 14, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @abdulrahuman5196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Needs ReproductionReproducible steps needed

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions