You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-05] [$250] Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report #56952
Version Number: 9.0.99-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+sj9032@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Left Hand Navigation (LHN)
Action Performed:
Go to staging.new.expensify.com
Log in with a new account.
Go to Account settings > Workspaces.
Click New workspace button to create a new workspace.
On workspace settings page, click on the workspace chat.
On workspace chat, click + > Assign task.
Create a task.
Go to the task report.
Send a reply.
Open another chat in LHN, other than workspace chat and task report.
Open FAB to dismiss FAB tooltip.
Expected Result:
There will be only one tooltip which is for the workspace chat.
Actual Result:
There are two tooltips - one for workspace chat, another one for workspace task report.
Another issue - Task report has three lines in the header (Step 8).
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report[/-][+][$250] Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report[/+]on Feb 19, 2025
changed the title [-][$250] Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report[/-][+][Due for payment 2025-03-05] [$250] Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report[/+]on Feb 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.5-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hoangzinh@kadiealexander@hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Feb 17, 2025
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Feb 17, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-02-17 15:57:46 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
There are two tooltips - one for workspace chat, another one for workspace task report.
What is the root cause of that problem?
The task report of policy expense chat still have the same
chatTypethen this also matches this conditionApp/src/components/LHNOptionsList/OptionRowLHN.tsx
Line 64 in 9370c43
What changes do you think we should make in order to solve the problem?
We need to add
!isThreadcondition here to prevent this tooltip can be shown for the child report of the policy expense chator we can use
!optionItem?.isTaskReportApp/src/components/LHNOptionsList/OptionRowLHN.tsx
Line 64 in 9370c43
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report[/-][+][$250] Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report[/+]melvin-bot commentedon Feb 19, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021892081957972685258
melvin-bot commentedon Feb 19, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)hoangzinh commentedon Feb 20, 2025
@nkdengineer's proposal looks good to me
Link to proposal #56952 (comment)
🎀👀🎀 C+ reviewed
11 remaining items
[-][$250] Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report[/-][+][Due for payment 2025-03-05] [$250] Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report[/+]melvin-bot commentedon Feb 26, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.5-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 26, 2025
@hoangzinh @kadiealexander @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
kadiealexander commentedon Mar 4, 2025
Payments needed:
@hoangzinh please complete the checklist!
hoangzinh commentedon Mar 5, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/54064/files#r1981138552
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/477602
Regression Test Proposal
Test:
Do we agree 👍 or 👎
hoangzinh commentedon Mar 5, 2025
Requested payment in ND
garrettmknight commentedon Mar 11, 2025
$250 approved for @hoangzinh