Skip to content

[Due for payment 2025-03-05] [$250] Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report #56952

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.99-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new account.
  3. Go to Account settings > Workspaces.
  4. Click New workspace button to create a new workspace.
  5. On workspace settings page, click on the workspace chat.
  6. On workspace chat, click + > Assign task.
  7. Create a task.
  8. Go to the task report.
  9. Send a reply.
  10. Open another chat in LHN, other than workspace chat and task report.
  11. Open FAB to dismiss FAB tooltip.

Expected Result:

There will be only one tooltip which is for the workspace chat.

Actual Result:

There are two tooltips - one for workspace chat, another one for workspace task report.

Another issue - Task report has three lines in the header (Step 8).

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6745822_1739805303574.20250217_230908.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021892081957972685258
  • Upwork Job ID: 1892081957972685258
  • Last Price Increase: 2025-02-19
  • Automatic offers:
    • nkdengineer | Contributor | 106209014
Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 17, 2025
  2. melvin-bot commented on Feb 17, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Feb 17, 2025

    @nkdengineer
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-02-17 15:57:46 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    There are two tooltips - one for workspace chat, another one for workspace task report.

    What is the root cause of that problem?

    The task report of policy expense chat still have the same chatType then this also matches this condition

    const shouldShowWokspaceChatTooltip = isPolicyExpenseChat(report) && activePolicyID === report?.policyID && session?.accountID === report?.ownerAccountID;

    What changes do you think we should make in order to solve the problem?

    We need to add !isThread condition here to prevent this tooltip can be shown for the child report of the policy expense chat

    const shouldShowWokspaceChatTooltip = isPolicyExpenseChat(report) && !isThread(report) && activePolicyID === report?.policyID && session?.accountID === report?.ownerAccountID;
    
    

    or we can use !optionItem?.isTaskReport

    const shouldShowWokspaceChatTooltip = isPolicyExpenseChat(report) && !optionItem?.isTaskReport && activePolicyID === report?.policyID && session?.accountID === report?.ownerAccountID;
    
    

    const shouldShowWokspaceChatTooltip = isPolicyExpenseChat(report) && activePolicyID === report?.policyID && session?.accountID === report?.ownerAccountID;

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 19, 2025
  5. changed the title [-]Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report[/-] [+][$250] Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report[/+] on Feb 19, 2025
  6. melvin-bot commented on Feb 19, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 19, 2025
  8. melvin-bot commented on Feb 19, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  9. moved this to Bugs and Follow Up Issues in #expensify-bugson Feb 19, 2025
  10. hoangzinh commented on Feb 20, 2025

    @hoangzinh
    Contributor

    @nkdengineer's proposal looks good to me

    Link to proposal #56952 (comment)

    🎀👀🎀 C+ reviewed

  11. 11 remaining items

  12. changed the title [-][$250] Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report[/-] [+][Due for payment 2025-03-05] [$250] Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report[/+] on Feb 26, 2025
  13. melvin-bot commented on Feb 26, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Feb 26, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.5-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-05. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Feb 26, 2025

    @melvin-bot

    @hoangzinh @kadiealexander @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. kadiealexander commented on Mar 4, 2025

    @kadiealexander
    Contributor

    Payments needed:

    @hoangzinh please complete the checklist!

  17. hoangzinh commented on Mar 5, 2025

    @hoangzinh
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:

    Regression Test Proposal

    Test:

    1. Log in with a new account.
    2. Go to Account settings > Workspaces.
    3. Click New workspace button to create a new workspace.
    4. On workspace settings page, click on the workspace chat.
    5. On workspace chat, click + > Assign task.
    6. Create a task.
    7. Go to the task report.
    8. Send any message.
    9. Open another chat in LHN, other than workspace chat and task report.
    10. Open FAB to dismiss FAB tooltip.
    11. Verify that: There will be only one tooltip in LHN which is for the workspace chat.

    Do we agree 👍 or 👎

  18. hoangzinh commented on Mar 5, 2025

    @hoangzinh
    Contributor

    Requested payment in ND

  19. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Mar 6, 2025
  20. garrettmknight commented on Mar 11, 2025

    @garrettmknight
    Contributor

    $250 approved for @hoangzinh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions