You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-21] [SIDEPANE][Due for payment 2025-03-13] Build "Stage 1) Build a placeholder help pane, tested via NVP" of "Add live-navigating help side pane" #471592 #56988
The design doc for Add live-navigating help side pane is still going through detailed review. However, I'd like to get a head start on proving out the basics of the technology. There is already a WIP PR here: #56490 Can you please:
Sorry for not updating earlier. Yesterday, I was busy with other tasks and reviews. Today I got back to work and had major problems with styling due to recent navigation refactor, basically a lot has changed under the hood… The good news is we now have a working side pane with clearer and more structured code. Now that I have a good base I should have more updates tomorrow!
Fantastic! How long before we have a PR that can be merged?
To be honest, I thought it would be ready by now, but I keep running into rough edges. Realistically speaking PR should be ready early next week, perhaps Tuesday/Wednesday.
Is somebody working on the backend part already?
1.1) Return the nameValuePair.expensify_sidePane in Open/ReconnectApp
We return the current value (if any) in OpenApp and ReconnectApp, so the client knows the current state of this value.
On Fri, Feb 21, 2025 at 11:52 AM Błażej Kustra ***@***.***> wrote:
Fantastic! How long before we have a PR that can be merged?
To be honest, I thought it would be ready by now, but I keep running into
rough edges. Realistically speaking PR should be ready early next week,
perhaps Tuesday/Wednesday.
Is somebody working on the backend part already?
1.1) Return the nameValuePair.expensify_sidePane in Open/ReconnectApp
We return the current value (if any) in OpenApp and ReconnectApp, so the
client knows the current state of this value.
—
Reply to this email directly, view it on GitHub
<#56988 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEMNUVHRI4CPDFV7DSKYI32Q57XRAVCNFSM6AAAAABXKPKFOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZVGQYTQMZSGY>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
[image: blazejkustra]*blazejkustra* left a comment (Expensify/App#56988)
<#56988 (comment)>
Fantastic! How long before we have a PR that can be merged?
To be honest, I thought it would be ready by now, but I keep running into
rough edges. Realistically speaking PR should be ready early next week,
perhaps Tuesday/Wednesday.
Is somebody working on the backend part already?
1.1) Return the nameValuePair.expensify_sidePane in Open/ReconnectApp
We return the current value (if any) in OpenApp and ReconnectApp, so the
client knows the current state of this value.
—
Reply to this email directly, view it on GitHub
<#56988 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEMNUVHRI4CPDFV7DSKYI32Q57XRAVCNFSM6AAAAABXKPKFOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZVGQYTQMZSGY>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
Activity
mallenexpensify commentedon Feb 18, 2025
@blazejkustra can you please comment so I can assign to you? Thx
blazejkustra commentedon Feb 18, 2025
🚀
blazejkustra commentedon Feb 18, 2025
Update: I started cleaning the PR that I prepared during SF onshore. I'll provide more details tomorrow on where we stand 🚢
quinthar commentedon Feb 18, 2025
Great, thanks!!
blazejkustra commentedon Feb 20, 2025
Sorry for not updating earlier. Yesterday, I was busy with other tasks and reviews. Today I got back to work and had major problems with styling due to recent navigation refactor, basically a lot has changed under the hood… The good news is we now have a working side pane with clearer and more structured code. Now that I have a good base I should have more updates tomorrow!
Screen.Recording.2025-02-20.at.19.08.29.mov
quinthar commentedon Feb 21, 2025
blazejkustra commentedon Feb 21, 2025
To be honest, I thought it would be ready by now, but I keep running into rough edges. Realistically speaking PR should be ready early next week, perhaps Tuesday/Wednesday.
Is somebody working on the backend part already?
quinthar commentedon Feb 21, 2025
64 remaining items
garrettmknight commentedon Mar 31, 2025
Reopening for payment summary for @rushatgabhane
Please confirm the payment for this comment: #56988 (comment)
melvin-bot commentedon Mar 31, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.trjExpensify commentedon Mar 31, 2025
@rushatgabhane confirming you reviewed this PR as an "outside" C+ assignment, not as a result of a regression to an original PR you reviewed?
rushatgabhane commentedon Mar 31, 2025
yes that is correct!
trjExpensify commentedon Mar 31, 2025
Payment summary as follows:
garrettmknight commentedon Mar 31, 2025
$250 approved for @rushatgabhane