Skip to content

[Due for payment 2025-03-21] [SIDEPANE][Due for payment 2025-03-13] Build "Stage 1) Build a placeholder help pane, tested via NVP" of "Add live-navigating help side pane" #471592 #56988

Closed

Description

@mallenexpensify

Note: This is for @blazejkustra.

The design doc for Add live-navigating help side pane is still going through detailed review. However, I'd like to get a head start on proving out the basics of the technology. There is already a WIP PR here: #56490 Can you please:

  1. Implement everything up to Stage 1, then stop
  2. Submit this PR for merging

Thanks!

cc @quinthar

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. mallenexpensify commented on Feb 18, 2025

    @mallenexpensify
    ContributorAuthor

    @blazejkustra can you please comment so I can assign to you? Thx

  2. blazejkustra commented on Feb 18, 2025

    @blazejkustra
    Contributor

    🚀

  3. blazejkustra commented on Feb 18, 2025

    @blazejkustra
    Contributor

    Update: I started cleaning the PR that I prepared during SF onshore. I'll provide more details tomorrow on where we stand 🚢

  4. self-assigned this
    on Feb 18, 2025
  5. quinthar commented on Feb 18, 2025

    @quinthar
    Contributor

    Great, thanks!!

  6. blazejkustra commented on Feb 20, 2025

    @blazejkustra
    Contributor

    Sorry for not updating earlier. Yesterday, I was busy with other tasks and reviews. Today I got back to work and had major problems with styling due to recent navigation refactor, basically a lot has changed under the hood… The good news is we now have a working side pane with clearer and more structured code. Now that I have a good base I should have more updates tomorrow!

    Screen.Recording.2025-02-20.at.19.08.29.mov
  7. quinthar commented on Feb 21, 2025

    @quinthar
    Contributor
  8. blazejkustra commented on Feb 21, 2025

    @blazejkustra
    Contributor

    Fantastic! How long before we have a PR that can be merged?

    To be honest, I thought it would be ready by now, but I keep running into rough edges. Realistically speaking PR should be ready early next week, perhaps Tuesday/Wednesday.

    Is somebody working on the backend part already?

    1.1) Return the nameValuePair.expensify_sidePane in Open/ReconnectApp
    We return the current value (if any) in OpenApp and ReconnectApp, so the client knows the current state of this value.

  9. quinthar commented on Feb 21, 2025

    @quinthar
    Contributor
  10. 64 remaining items

  11. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 31, 2025
  12. garrettmknight commented on Mar 31, 2025

    @garrettmknight
    Contributor

    Reopening for payment summary for @rushatgabhane

    Please confirm the payment for this comment: #56988 (comment)

  13. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 31, 2025
  14. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  15. trjExpensify commented on Mar 31, 2025

    @trjExpensify
    Contributor

    @rushatgabhane confirming you reviewed this PR as an "outside" C+ assignment, not as a result of a regression to an original PR you reviewed?

  16. rushatgabhane commented on Mar 31, 2025

    @rushatgabhane
    Member

    yes that is correct!

  17. trjExpensify commented on Mar 31, 2025

    @trjExpensify
    Contributor

    Payment summary as follows:

  18. garrettmknight commented on Mar 31, 2025

    @garrettmknight
    Contributor

    $250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ImprovementItem broken or needs improvement.Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions