You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-13] [$250] Web - Action menu - Pressing tab does not navigate through action menu badges #57022
Version Number: 56992 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/5605616 Issue reported by: Applause Internal Team Device used: v9.1.0-0 App Component: Chat Report View
Action Performed:
sign in to staging.new.expensify.com
Navigate to a conversation with comments or messages sent already
Click on a comment or message
Press tab to navigate through action menu badges
Expected Result:
User can navigate through action menu badges by pressing tab to reach emoji picker.
Actual Result:
Pressing tab after the first badge is highlighted, stops navigating through action menu badges and navigates through conversation.
However, when we press 'Tab' to focus to the next item, the onBlur inside ActiveHoverable is triggered, causing hovered to be false lead to the action menu being hidden, preventing focus from moving to the next action menu item.
What changes do you think we should make in order to solve the problem?
Previously, we only set hovered is false when clicking outside the element. However, in this PR (#54744), that logic was removed.
I think we should reintroduce that logic here.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A, UI bug
What alternative solutions did you explore? (Optional)
N/A Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
And the mini context menu won't show anymore if it's not hovered.
What changes do you think we should make in order to solve the problem?
The onBlur was first added at #14377 which then causes some issues which keep getting patched until #20561.
The issue that the onBlur is trying to solve isn't reproducible anymore, so I suggest removing the onBlur workaround to set the hovered state to false. Hover state should rely only on mouse enter and leave event.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
⚠️@bernhardoj Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
changed the title [-]Web - Action menu - Pressing tab does not navigate through action menu badges[/-][+][$250] Web - Action menu - Pressing tab does not navigate through action menu badges[/+]on Feb 19, 2025
@ishpaul777@jliexpensify@ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No neec
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Not required, we removed whole logic that caused this so there's no need
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Feb 18, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.linhvovan29546 commentedon Feb 18, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Action menu - Pressing tab does not navigate through action menu badges
What is the root cause of that problem?
We display the action menu when hovering, based on the
hoveredstate of theHoverablecomponent.App/src/pages/home/report/PureReportActionItem.tsx
Lines 1185 to 1196 in 18c43dd
However, when we press 'Tab' to focus to the next item, the
onBlurinsideActiveHoverableis triggered, causinghoveredto befalselead to the action menu being hidden, preventing focus from moving to the next action menu item.What changes do you think we should make in order to solve the problem?
Previously, we only set hovered is
falsewhen clicking outside the element. However, in this PR (#54744), that logic was removed.I think we should reintroduce that logic here.
App/src/components/Hoverable/ActiveHoverable.tsx
Lines 109 to 111 in e676248
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A, UI bug
What alternative solutions did you explore? (Optional)
N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
bernhardoj commentedon Feb 18, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Pressing Tab doesn't navigate through the emoji reaction.
What is the root cause of that problem?
When we are navigating through the reaction using Tab, the report action item is blurred. If it's blurred, the hovered state is set to false.
App/src/components/Hoverable/ActiveHoverable.tsx
Lines 109 to 111 in 7ad53a7
App/src/components/Hoverable/ActiveHoverable.tsx
Lines 86 to 90 in 7ad53a7
And the mini context menu won't show anymore if it's not hovered.
What changes do you think we should make in order to solve the problem?
The
onBlurwas first added at #14377 which then causes some issues which keep getting patched until #20561.The issue that the onBlur is trying to solve isn't reproducible anymore, so I suggest removing the onBlur workaround to set the hovered state to false. Hover state should rely only on mouse enter and leave event.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
github-actions commentedon Feb 18, 2025
[-]Web - Action menu - Pressing tab does not navigate through action menu badges[/-][+][$250] Web - Action menu - Pressing tab does not navigate through action menu badges[/+]melvin-bot commentedon Feb 19, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021892038726903190623
melvin-bot commentedon Feb 19, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (
External)jliexpensify commentedon Feb 19, 2025
I can repro this one
22 remaining items
melvin-bot commentedon Mar 6, 2025
@ishpaul777 @jliexpensify @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jliexpensify commentedon Mar 9, 2025
Bumping @ishpaul777 for the checklist
ishpaul777 commentedon Mar 10, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/54744/files#r1990069687
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No neec
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Not required, we removed whole logic that caused this so there's no need
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
ishpaul777 commentedon Mar 10, 2025
doing it in few minsdonejliexpensify commentedon Mar 13, 2025
Payment Summary
bernhardoj commentedon Mar 13, 2025
Requested in ND.
ishpaul777 commentedon Mar 13, 2025
Requested in ND.
JmillsExpensify commentedon Mar 17, 2025
$250 approved for @bernhardoj
garrettmknight commentedon Mar 24, 2025
$250 approved for @ishpaul777