Skip to content

[Due for payment 2025-03-17] [$250] Session expired errors right after login #57083

Closed

Description

@VickyStash

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.0-2
Reproducible in staging?:
Reproducible in production?: yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @VickyStash
Slack conversation (hyperlinked to channel name): N/A

Action Performed:

Pre-steps:
Use one browser window and make sure you’re signed-out of any account on new.expensify.com and expensify.com prior to starting the steps below.

Steps:

  1. Login with a new account in the ND.
  2. Close the window when the onboarding modal is shown.
  3. Open the OD and login with the account from the step 1.

Expected Result:

The user is re-navigated to the ND with a logged-in account.

Actual Result:

The user is re-navigated to the ND, but logged out right after that. All requests failed with Your session has expired error.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
video_bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021892144520168190268
  • Upwork Job ID: 1892144520168190268
  • Last Price Increase: 2025-02-19
Issue OwnerCurrent Issue Owner: @greg-schroeder

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 19, 2025
  2. melvin-bot commented on Feb 19, 2025

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. VickyStash commented on Feb 19, 2025

    @VickyStash
    ContributorAuthor

    Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

  4. koko57 commented on Feb 19, 2025

    @koko57
    Contributor

    also will have my 👀 on that one

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 19, 2025
  6. changed the title [-]Session expired errors right after login[/-] [+][$250] Session expired errors right after login[/+] on Feb 19, 2025
  7. melvin-bot commented on Feb 19, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 19, 2025
  9. melvin-bot commented on Feb 19, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

  10. 38 remaining items

  11. melvin-bot commented on Mar 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Mar 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.10-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-17. 🎊

    For reference, here are some details about the assignees on this issue:

    • @VickyStash does not require payment (Contractor)
    • @dominictb requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Mar 10, 2025

    @melvin-bot

    @dominictb @greg-schroeder @dominictb The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. dominictb commented on Mar 12, 2025

    @dominictb
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: No need for offending PR

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

    Regression Test Proposal

    Test:

    1. Login with a new account in the ND.
    2. Close the ND window when the onboarding modal is shown.
    3. Open the OD and login with the account from the step 1.
    4. Enter the magic code and continue login. Since you are testing over prod OD, the URL will turn into https://new.expensify.com/transition?... for transition, you need to copy it quickly and modify to navigate to DEV URL, ex https://dev.new.expensify.com:8082/transition?...
    5. Make sure that after opening ND with the transition link https://dev.new.expensify.com:8082/transition?... the user stays logged in, the app re-authenticated with the shortLivedAuthToken.

    Do we agree 👍 or 👎

  15. melvin-bot commented on Mar 17, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @VickyStash is from an agency-contributor and not due payment
    • ROLE: @dominictb paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@greg-schroeder)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1892144520168190268/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. greg-schroeder commented on Mar 17, 2025

    @greg-schroeder
    Contributor

    Will process this today

  17. greg-schroeder commented on Mar 17, 2025

    @greg-schroeder
    Contributor

    Offset sent to @dominictb via Upwork


    Payment summary:

    Contributor: @VickyStash - No payment
    C+: @dominictb - $250 - Upwork

  18. greg-schroeder commented on Mar 17, 2025

    @greg-schroeder
    Contributor

    File regression test. Closing, I'll pay you immediately once you accept okay @dominictb!

  19. dominictb commented on Mar 19, 2025

    @dominictb
    Contributor

    @greg-schroeder Accepted with thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions