[Due for payment 2025-03-10] [$250] QBO Card reconciliation - Wrong navigation with RHP back button on "Settlement account" page

@bfitzexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.1.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/5617523
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

Expensify Card is enabled and bank account is set up on Expensify Card page.
Workspace is connected to QBO.

Go to staging.new.expensify.com
Go to workspace settings > Accounting.
Click Card reconciliation.
Enable "Continuous Reconciliation" if not enabled.
Click Reconciliation account.
Click Expensify Card settlement account link.
Click RHP back button.

Expected Result:

RHP will return to the previous page which is "Reconciliation account" page.

Actual Result:

RHP returns to "Settings". A second click on the RHP back button opens "Reconciliation account" page.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6747864_1739969542624.20250219_204202.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021892962783772169851
Upwork Job ID: 1892962783772169851
Last Price Increase: 2025-02-21
Automatic offers:

nkdengineer | Contributor | 106259995

Issue Owner

Current Issue Owner: @bfitzexpensify

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

🚨 Edited by proposal-police: This proposal was edited at 2025-02-22 14:12:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We use goBack with the fallbackRoute then it's always navigate back to the fallback route after this function is reworked.

App/src/pages/workspace/expensifyCard/WorkspaceSettlementAccountPage.tsx

Line 98 in 11302a9

    
           onBackButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_EXPENSIFY_CARD_SETTINGS.getRoute(policyID))}

What changes do you think we should make in order to solve the problem?

Accept the backTo params for WorkspaceSettlementAccountPageroute

App/src/ROUTES.ts

Line 1460 in 11302a9

    
           getRoute: (policyID: string) => `settings/workspaces/${policyID}/expensify-card/settings/account` as const,

When we navigate to Expensify card setting account page here, add backTo param to the route as Navigation.getActiveRoute()

App/src/pages/workspace/accounting/reconciliation/ReconciliationAccountSettingsPage.tsx

Line 78 in 11302a9

    
           <TextLink onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_SETTINGS_ACCOUNT.getRoute(policyID))}>

Get the backTo param in WorkspaceSettlementAccountPage page from route and goBack to the backTo route if it exist, otherwise go back to the expensify card setting page

App/src/pages/workspace/expensifyCard/WorkspaceSettlementAccountPage.tsx

Line 98 in 11302a9

    
           onBackButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_EXPENSIFY_CARD_SETTINGS.getRoute(policyID))}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

For point 3, we can create a standard solution in HeaderWithBackButton

Get backTo param from route
Define a new prop shouldGobackWithBackTo with default value as true
If backTo exists and shouldGobackWithBackTo is true, go back with backTo when we click on back button in the header
We need to search backTo: Routes to see if all the pages have backTo param and pass shouldGobackWithBackTo={false} if we need to override the default behavior at the point 3.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Job added to Upwork: https://www.upwork.com/jobs/~021892962783772169851

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@parasharrajat

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.7-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Wrong navigation with RHP back button on Settlement account page #57390

If no regressions arise, payment will be issued on 2025-03-10. 🎊

For reference, here are some details about the assignees on this issue:

@parasharrajat requires payment through NewDot Manual Requests
@nkdengineer requires payment automatic offer (Contributor)

@parasharrajat

@parasharrajat @bfitzexpensify @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@nkdengineer

Payment complete to @nkdengineer

@parasharrajat please complete the BZ checklist

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: Implement flexible bottom tab bar #49539 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Expensify Card is enabled and bank account is set up on Expensify Card page.
Workspace is connected to QBO.

Test:

Go to workspace settings > Accounting.
Click Card reconciliation.
Enable "Continuous Reconciliation" if not enabled.
Click Reconciliation account.
Click Expensify Card settlement account link.
Click RHP back button.
Verify that: RHP will return to the previous page which is "Reconciliation account" page.

Do we agree 👍 or 👎

@parasharrajat

Great, thanks.

Payment summary:

@parasharrajat due $250 for C+ work

Payment requested as per #57109 (comment)

@parasharrajat

$250 approved for @parasharrajat

Navigation Menu

Repository navigation

[Due for payment 2025-03-10] [$250] QBO Card reconciliation - Wrong navigation with RHP back button on "Settlement account" page #57109

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

23 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Due for payment 2025-03-10] [$250] QBO Card reconciliation - Wrong navigation with RHP back button on "Settlement account" page #57109

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 19, 2025

nkdengineer commented on Feb 19, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Feb 21, 2025

melvin-bot commented on Feb 21, 2025

23 remaining items

melvin-bot commented on Mar 3, 2025

melvin-bot commented on Mar 3, 2025

melvin-bot commented on Mar 3, 2025

bfitzexpensify commented on Mar 11, 2025

parasharrajat commented on Mar 11, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

bfitzexpensify commented on Mar 11, 2025

parasharrajat commented on Mar 17, 2025

JmillsExpensify commented on Mar 17, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions