Repository navigation
[Due for payment 2025-03-17] [Due for payment 2025-03-13] [$250] iOS - Search - Search page cannot be dismissed by swiping to the right #57291
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.4-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Search
Action Performed:
- Launch ND or hybrid app.
- Tap on the search icon on the top right
- Swipe to the right to dismiss the search page (iOS swiping style)
Expected Result:
The search page can be dismissed by swiping to the right (previously it was fixed in #51731)
Actual Result:
The search page cannot be dismissed by swiping to the right.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6750749_1740219577904.20250222_181417.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021894676272056100014
- Upwork Job ID: 1894676272056100014
- Last Price Increase: 2025-02-26
- Automatic offers:
- DylanDylann | Reviewer | 106292983
- nkdengineer | Contributor | 106292984
Issue Owner
Current Issue Owner: @JmillsExpensifyMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Feb 22, 2025
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Feb 22, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-02-22 20:02:26 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The search page cannot be dismissed by swiping to the right.
What is the root cause of that problem?
It starts to happen after this PR, we removed
swipeDirectionthat returned fromgetModalStylesand replaced it withswipeDirectionprophttps://github.com/Expensify/App/pull/55157/files#diff-c5dd0a065b12f253786ab2916473640a80014957475696db4d97bedc23f47af2L158
App/src/components/Modal/BaseModal.tsx
Line 76 in 0b6d1a0
And we don't pass
swipeDirectionprop here.App/src/components/Search/SearchRouter/SearchRouterModal.tsx
Line 22 in 0b6d1a0
It may aslo happen with other modal that has
propagateSwipeistrueWhat changes do you think we should make in order to solve the problem?
Pass the
swipeDirectionasrighthere. We need to check for other places thatpropagateSwipeistrueand passswipeDirectionprop accordingly if it happensApp/src/components/Search/SearchRouter/SearchRouterModal.tsx
Line 22 in 0b6d1a0
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
It's just missing a prop for swipe action so I think we can skip the test
What alternative solutions did you explore? (Optional)
We can still get the
swipeDirectionfromgetModalStylesand fallback it here ifswipeDirectionprop isundefinedApp/src/components/Modal/BaseModal.tsx
Line 187 in 0b6d1a0
Or we can add the default value for
swipeDirectionOr we can remove
swipeDirectionprop and still getswipeDirectionfromgetModalStylesbecause I don't see we pass this prop anywhereResult
Screen.Recording.2025-02-23.at.02.58.28.mov
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]iOS - Search - Search page cannot be dismissed by swiping to the right[/-][+][$250] iOS - Search - Search page cannot be dismissed by swiping to the right[/+]melvin-bot commentedon Feb 26, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021894676272056100014
melvin-bot commentedon Feb 26, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (
External)JmillsExpensify commentedon Feb 26, 2025
Opened up to the community
24 remaining items
[-][Due for payment 2025-03-13] [$250] iOS - Search - Search page cannot be dismissed by swiping to the right[/-][+][Due for payment 2025-03-17] [Due for payment 2025-03-13] [$250] iOS - Search - Search page cannot be dismissed by swiping to the right[/+]melvin-bot commentedon Mar 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.10-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 10, 2025
@DylanDylann @JmillsExpensify @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
DylanDylann commentedon Mar 17, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: This is a new improvement, not a bug
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
garrettmknight commentedon Mar 17, 2025
Payment summary:
melvin-bot commentedon Mar 18, 2025
@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Mar 19, 2025
@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?
JmillsExpensify commentedon Mar 19, 2025
Regression test created.