Skip to content

[Due for payment 2025-04-18] [$250] Web - Error when attempting to delete employees #57298

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.4-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition: new workspace with connected Netsuite.

  1. Go t ws > Members
  2. Add admin to workspace
  3. Go to Accounting > Export
  4. Set Preferred exporter to admin (from step 2)
  5. Go to Accounting > Advanced
  6. Toggle ON Invite employees and set approvals
  7. Go to Members > bulk select
  8. Select all imported employees (except admin role) > Remove
  9. Submit Remove button

Expected Result:

All employees removed and approver changed to Workspace Owner.

Actual Result:

Nothing happens on Remove button click. In DevTools console there is an error 'Uncaught Error: Approval workflow must have at least one approver'

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6750871_1740232924391.bandicam_2025-02-22_15-45-19-565.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021896794206809288400
  • Upwork Job ID: 1896794206809288400
  • Last Price Increase: 2025-03-25
  • Automatic offers:
    • CyberAndrii | Contributor | 106734843
Issue OwnerCurrent Issue Owner: @zanyrenney

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 23, 2025
  2. melvin-bot commented on Feb 23, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. kadiealexander commented on Feb 24, 2025

    @kadiealexander
    Contributor

    @yuwenmemon @zsgreenwald I was trying to understand the expected behaviour here from the design doc and I wasn't able to quite figure it out. If we import employees and set approval flows from NetSuite, should the admin then be able to delete those users in Expensify? I can see an argument either way.

  4. kadiealexander commented on Feb 26, 2025

    @kadiealexander
    Contributor

    Took it to Slack here.

  5. kadiealexander commented on Mar 3, 2025

    @kadiealexander
    Contributor

    Still discussing in Slack.

  6. yuwenmemon commented on Mar 3, 2025

    @yuwenmemon
    Contributor

    Image

    @kadiealexander Looking at the video I'm not sure this is a NetSuite specific issue but more an issue about not surfacing an error about removing workspace members that are approvers in the workspace.

  7. changed the title [-]Web - NetSuite - Can't delete imported employees from m[/-] [+]Web - Error not shown when attempting to delete employees[/+] on Mar 4, 2025
  8. kadiealexander commented on Mar 4, 2025

    @kadiealexander
    Contributor

    @yuwenmemon I've tested with other approval workflows and this only seems to happen when connected to NetSuite

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 4, 2025
  10. changed the title [-]Web - Error not shown when attempting to delete employees[/-] [+][$250] Web - Error not shown when attempting to delete employees[/+] on Mar 4, 2025
  11. melvin-bot commented on Mar 4, 2025

    @melvin-bot
  12. 66 remaining items

  13. melvin-bot commented on Apr 17, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  14. kadiealexander commented on Apr 17, 2025

    @kadiealexander
    Contributor

    Reassigning to handle payment as I'm heading OOO. Thanks for your help Zany!

  15. zanyrenney commented on Apr 17, 2025

    @zanyrenney
    Contributor

    Eeek, not ideal as I am also OOO tomorrow when payment is due.

  16. zanyrenney commented on Apr 17, 2025

    @zanyrenney
    Contributor

    fyi @luacmartins @ishpaul777 @CyberAndrii since many people are off for Easter, I'm not going to reassign this again, I'll pay this out on Tuesday instead. Thanks for your patience.

  17. melvin-bot commented on Apr 21, 2025

    @melvin-bot

    @luacmartins, @CyberAndrii, @zanyrenney, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  18. zanyrenney commented on Apr 22, 2025

    @zanyrenney
    Contributor

    payment summary

    @CyberAndrii requires payment automatic offer (Contributor) - paid $250 via Upwork.
    @ishpaul777 requires payment through NewDot Manual Requests - please request $250 via ND.

  19. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Apr 22, 2025
  20. garrettmknight commented on May 2, 2025

    @garrettmknight
    Contributor

    $250 approved for @ishpaul777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions