Skip to content

[Due for payment 2025-03-17] [CRITICAL] Pinned and unread chats disappear from the LHN #57354

New issue
New issue
Closed
Closed
[Due for payment 2025-03-17] [CRITICAL] Pinned and unread chats disappear from the LHN#57354
Assignees
trjExpensifyrushatgabhaneMarioExpensify
Labels
AutoAssignerNewDotQualityUsed to assign quality issues to engineersAwaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Description

@m-natarajan
m-natarajan
opened on Feb 24, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Deliverable

The deliverable is to provide reliable reproduction steps for the bug. - Follow the Propose a solution for a job process to submit the steps for review”. Inc. preconditions and additional details if they’re helpful. (ie. require x beta to be enabled, must be on a Collect plan)

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @zsgreenwald @dubielzyk-expensify
Slack conversation (hyperlinked to channel name): #quality

Action Performed:

Case1: Refresh the page (Zach's bug report)

  1. Sign in to NewDot
  2. Refresh the page
  3. Observe all unread and pinned chats disappear from the LHN

Case2: Create expense (Jon's bug report)

  1. Sign in to NewDot
  2. Observe the LHN loads correctly (all unreads and pinned chats are there)
  3. Create an expense
  4. Observe all unread and pinned chats disappear from the LHN

Expected Result:

The LHN shouldn't "empty" after a refresh or creating an expense.

Actual Result:

All the pinned and unread chats disappear from the LHN

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Image

Onyx data is in the OP

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. m-natarajan
    added
    AutoAssignerNewDotQualityUsed to assign quality issues to engineers
    BugSomething is broken. Auto assigns a BugZero manager.
    DailyKSv2
    Needs ReproductionReproducible steps needed
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Feb 24, 2025
  2. m-natarajan
    added this to [#whatsnext] #qualityon Feb 24, 2025

  3. melvin-bot commented on Feb 24, 2025

    @melvin-bot
    melvin-botBot
    on Feb 24, 2025 – with Melvin Bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot
    assigned
    trjExpensify
    and
    MarioExpensify
    on Feb 24, 2025

  5. melvin-bot commented on Feb 24, 2025

    @melvin-bot
    melvin-botBot
    on Feb 24, 2025 – with Melvin Bot

    Triggered auto assignment to @MarioExpensify (AutoAssignerNewDotQuality)

  6. melvin-bot
    added
    WeeklyKSv2
    on Feb 24, 2025

  7. MelvinBot commented on Feb 24, 2025

    @MelvinBot
    MelvinBot
    on Feb 24, 2025
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  8. mallenexpensify
    changed the title [-]Pinned and unread chats are disappeared from the LHN[/-] [+][$250 Reproduction Steps] Pinned and unread chats are disappeared from the LHN[/+] on Feb 25, 2025
  9. mallenexpensify
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 25, 2025

  10. mallenexpensify commented on Feb 25, 2025

    @mallenexpensify
    mallenexpensify
    on Feb 25, 2025
    Contributor

    @trjExpensify this seems to be a pesky bug so I updated the title and OP to try to get reliable reproduction steps (added Help Wanted too). If someone is able to share them, deets are in this SO for how to manage.

  11. 47 remaining items

  12. melvin-bot
    removed
    Overdue
    on Mar 17, 2025
  13. trjExpensify
    assigned
    rushatgabhane
    on Mar 17, 2025

  14. trjExpensify commented on Mar 19, 2025

    @trjExpensify
    trjExpensify
    on Mar 19, 2025
    Contributor

    Bump, @rushatgabhane.

  15. melvin-bot
    added
    Overdue
    on Mar 24, 2025

  16. MarioExpensify commented on Mar 24, 2025

    @MarioExpensify
    MarioExpensify
    on Mar 24, 2025
    Contributor

    Bumped @rushatgabhane here.

  17. trjExpensify commented on Mar 24, 2025

    @trjExpensify
    trjExpensify
    on Mar 24, 2025
    Contributor

    Sounds good!

  18. melvin-bot
    removed
    Overdue
    on Mar 24, 2025

  19. rushatgabhane commented on Mar 26, 2025

    @rushatgabhane
    rushatgabhane
    on Mar 26, 2025
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: This is mostly a backend bug, so I'm unable to pinpoint a PR on App repo.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1742992295307879

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Log into test account
    2. Enable offline mode
    3. Navigate through the app
    4. Disable offline mode and wait a little for the app to "refresh"
    5. Make sure that the App state is correctly kept (no disappearing reports or actions)

    Do we agree 👍 or 👎

  20. trjExpensify commented on Mar 26, 2025

    @trjExpensify
    trjExpensify
    on Mar 26, 2025
    Contributor

    Niceee, I thought for a minute you just didn't like getting paid. 😝 😉

    Payment summary as follows:

    On the test case, it seems pretty generic. We have offline tests for taking a variety of different actions throughout the app.

    As this bug was about the LHN, how do you feel about focusing on that?

    1. Log into a high traffic account
    2. Pin a couple of charts and mark a couple as unread
    3. Enable offline mode
    4. Click into Reports > navigate around a bit.
    5. Click into Settings > navigate around a bit.
    6. Click into Inbox
    7. Go back online and wait a little for the app to refresh
    8. Verify the pinned and unread chats don't disappear from the LHN

    Let me know!

  21. rushatgabhane commented on Mar 26, 2025

    @rushatgabhane
    rushatgabhane
    on Mar 26, 2025
    Member

    okay that should work!

  22. trjExpensify commented on Mar 26, 2025

    @trjExpensify
    trjExpensify
    on Mar 26, 2025
    Contributor

    Great, created. Closing! https://github.com/Expensify/Expensify/issues/484815

  23. trjExpensify
    closed this as completedon Mar 26, 2025
  24. github-project-automation
    moved this from CRITICAL to Done in [#whatsnext] #qualityon Mar 26, 2025

  25. rushatgabhane commented on Mar 26, 2025

    @rushatgabhane
    rushatgabhane
    on Mar 26, 2025
    Member

    Niceee, I thought for a minute you just didn't like getting paid. 😝 😉

    hahaha yeah

  26. garrettmknight commented on Apr 10, 2025

    @garrettmknight
    garrettmknight
    on Apr 10, 2025
    Contributor

    $250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersAwaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions