You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-13] [$250] Reports - Rename search page is reopened after saving a search and using device back button. #57380
Version Number: 9.1.5-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):ibellicotest+305@gmail.com Issue reported by: Applause Internal Team Device used: Motorola MotoG60 - Android 12 - Chrome App Component: Search
Action Performed:
Open the Expensify app.
Tap on "Reports" on the bottom of the screen.
Tap on the filters icon.
Apply any filter and save the search.
Tap on "Cancel"
Tap on the bookmark icon.
Tap on the three dots icon on the saved search and select "Rename"
Edit the search name and save the new name.
Tap on "Cancel"
Use device´s back button.
Expected Result:
After saving the new name of a search, landing on "Reports" and using device´s back button, the rename search page shouldn´t be reopened.
Actual Result:
Rename search page is reopened instead of inbox, after the user saves a new name, lands on "Reports" and uses device´s back button.
Please re-state the problem that we are trying to solve in this issue.
Rename search page is reopened instead of inbox, after the user saves a new name, lands on "Reports" and uses device´s back button.
What is the root cause of that problem?
We do two navigation actions here without waiting until the first one is complete then it doesn't work as expected and we also can see the console error appears
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Reports - Rename search page is reopened after saving a search and using device back button.[/-][+][$250] Reports - Rename search page is reopened after saving a search and using device back button.[/+]on Feb 25, 2025
changed the title [-][$250] Reports - Rename search page is reopened after saving a search and using device back button.[/-][+][Due for payment 2025-03-13] [$250] Reports - Rename search page is reopened after saving a search and using device back button.[/+]on Mar 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.9-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dukenv0307@maddylewis@dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Tap on "Reports" on the bottom of the screen.
Tap on the filters icon.
Apply any filter and save the search.
Tap on "Cancel"
Tap on the bookmark icon.
Tap on the three dots icon on the saved search and select "Rename"
Edit the search name and save the new name.
Tap on "Cancel"
Use device's back button.
Verify that the user lands in the inbox or whatever the page is that SHOULD be opened
Activity
melvin-bot commentedon Feb 25, 2025
Triggered auto assignment to @maddylewis (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Feb 25, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Rename search page is reopened instead of inbox, after the user saves a new name, lands on "Reports" and uses device´s back button.
What is the root cause of that problem?
We do two navigation actions here without waiting until the first one is complete then it doesn't work as expected and we also can see the console error appears
App/src/pages/Search/SavedSearchRenamePage.tsx
Lines 28 to 35 in eaa3be4
What changes do you think we should make in order to solve the problem?
We need to use
Navigation.isNavigationReadyfor the second navigation action to wait for the dismiss action is completeApp/src/pages/Search/SavedSearchRenamePage.tsx
Lines 28 to 35 in eaa3be4
or using
InteractionManager.runAfterInteractionWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
We can only use
goBackand remove both navigation actions hereApp/src/pages/Search/SavedSearchRenamePage.tsx
Lines 28 to 35 in eaa3be4
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Reports - Rename search page is reopened after saving a search and using device back button.[/-][+][$250] Reports - Rename search page is reopened after saving a search and using device back button.[/+]melvin-bot commentedon Feb 25, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021894396612887094597
melvin-bot commentedon Feb 25, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (
External)dukenv0307 commentedon Feb 25, 2025
@nkdengineer's proposal looks good to me
🎀👀🎀 C+ reviewed
melvin-bot commentedon Feb 25, 2025
Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
dangrous commentedon Feb 25, 2025
LGMT2!
8 remaining items
[-][$250] Reports - Rename search page is reopened after saving a search and using device back button.[/-][+][Due for payment 2025-03-13] [$250] Reports - Rename search page is reopened after saving a search and using device back button.[/+]melvin-bot commentedon Mar 6, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.9-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 6, 2025
@dukenv0307 @maddylewis @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
dukenv0307 commentedon Mar 10, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/51925/files#r1986509701
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
dangrous commentedon Mar 10, 2025
I think we can update
10to just beVerify that the user lands in the inboxor whatever the page is that SHOULD be openedmaddylewis commentedon Mar 14, 2025
Payment Overview
JmillsExpensify commentedon Apr 23, 2025
$250 approved for @dukenv0307