Skip to content

[Due for payment 2025-03-13] [$250] Reports - Rename search page is reopened after saving a search and using device back button. #57380

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.5-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+305@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Search

Action Performed:

  1. Open the Expensify app.
  2. Tap on "Reports" on the bottom of the screen.
  3. Tap on the filters icon.
  4. Apply any filter and save the search.
  5. Tap on "Cancel"
  6. Tap on the bookmark icon.
  7. Tap on the three dots icon on the saved search and select "Rename"
  8. Edit the search name and save the new name.
  9. Tap on "Cancel"
  10. Use device´s back button.

Expected Result:

After saving the new name of a search, landing on "Reports" and using device´s back button, the rename search page shouldn´t be reopened.

Actual Result:

Rename search page is reopened instead of inbox, after the user saves a new name, lands on "Reports" and uses device´s back button.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6753276_1740456958889.Save.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021894396612887094597
  • Upwork Job ID: 1894396612887094597
  • Last Price Increase: 2025-02-25
  • Automatic offers:
    • nkdengineer | Contributor | 106279877
Issue OwnerCurrent Issue Owner: @maddylewis

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 25, 2025
  2. melvin-bot commented on Feb 25, 2025

    @melvin-bot

    Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Feb 25, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Rename search page is reopened instead of inbox, after the user saves a new name, lands on "Reports" and uses device´s back button.

    What is the root cause of that problem?

    We do two navigation actions here without waiting until the first one is complete then it doesn't work as expected and we also can see the console error appears

    Navigation.dismissModal();
    Navigation.navigate(
    ROUTES.SEARCH_ROOT.getRoute({
    query: q,
    name: newName?.trim(),
    }),
    );
    };

    What changes do you think we should make in order to solve the problem?

    We need to use Navigation.isNavigationReady for the second navigation action to wait for the dismiss action is complete

    Navigation.dismissModal();
    Navigation.isNavigationReady().then(() => {
        Navigation.navigate(
            ROUTES.SEARCH_ROOT.getRoute({
                query: q,
                name: newName?.trim(),
            }),
        );
    });
    

    Navigation.dismissModal();
    Navigation.navigate(
    ROUTES.SEARCH_ROOT.getRoute({
    query: q,
    name: newName?.trim(),
    }),
    );
    };

    or using InteractionManager.runAfterInteraction

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    We can only use goBack and remove both navigation actions here

    Navigation.goBack(
        ROUTES.SEARCH_ROOT.getRoute({
            query: q,
            name: newName?.trim(),
        }),
    );
    

    Navigation.dismissModal();
    Navigation.navigate(
    ROUTES.SEARCH_ROOT.getRoute({
    query: q,
    name: newName?.trim(),
    }),
    );
    };

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 25, 2025
  5. changed the title [-]Reports - Rename search page is reopened after saving a search and using device back button.[/-] [+][$250] Reports - Rename search page is reopened after saving a search and using device back button.[/+] on Feb 25, 2025
  6. melvin-bot commented on Feb 25, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 25, 2025
  8. melvin-bot commented on Feb 25, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

  9. dukenv0307 commented on Feb 25, 2025

    @dukenv0307
    Contributor

    @nkdengineer's proposal looks good to me

    🎀👀🎀 C+ reviewed

  10. melvin-bot commented on Feb 25, 2025

    @melvin-bot

    Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  11. dangrous commented on Feb 25, 2025

    @dangrous
    Contributor

    LGMT2!

  12. 8 remaining items

  13. changed the title [-][$250] Reports - Rename search page is reopened after saving a search and using device back button.[/-] [+][Due for payment 2025-03-13] [$250] Reports - Rename search page is reopened after saving a search and using device back button.[/+] on Mar 6, 2025
  14. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.9-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-13. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    @dukenv0307 @maddylewis @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. dukenv0307 commented on Mar 10, 2025

    @dukenv0307
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/51925/files#r1986509701

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Tap on "Reports" on the bottom of the screen.
    2. Tap on the filters icon.
    3. Apply any filter and save the search.
    4. Tap on "Cancel"
    5. Tap on the bookmark icon.
    6. Tap on the three dots icon on the saved search and select "Rename"
    7. Edit the search name and save the new name.
    8. Tap on "Cancel"
    9. Use device's back button.
    10. Verify that the user lands in the inbox or whatever the page is that SHOULD be opened

    Do we agree 👍 or 👎

  18. dangrous commented on Mar 10, 2025

    @dangrous
    Contributor

    I think we can update 10 to just be Verify that the user lands in the inbox or whatever the page is that SHOULD be opened

  19. maddylewis commented on Mar 14, 2025

    @maddylewis
    Contributor

    Payment Overview

    @dukenv0307 requires payment through NewDot Manual Requests ($250)

    Image
  20. JmillsExpensify commented on Apr 23, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions