You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-21] [$250] Workspace - Missing workspace name in "You missed the party in" in archived #admins room #57386
Version Number: 9.1.5-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+sj9032@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Chat Report View
Action Performed:
Go to staging.new.expensify.com
Create a new workspace.
Go to workspace settings > Overview.
Click Share.
Click #admins.
Send a message in #admins.
Go to workspace settings.
Delete the workspace.
Go back to #admins.
Expected Result:
"You missed the party in" message will include the workspace name.
Actual Result:
The workspace name is missing and only shows — "You missed the party in , there's nothing to see here."
OPTIONAL: If we want bold Workspace name then we can separate it and do the same as this PR
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
beginningOfArchivedRoomPartOne: 'You missed the party in ',
beginningOfArchivedRoomPartTwo: ", there's nothing to see here.",
That show the welcome text without workspace Name
What changes do you think we should make in order to solve the problem?
Add a new translation that will display policy name,
we already have beginningOfArchivedRoomPartTwo so we will change that to beginningOfArchivedRoomPartThree
beginningOfArchivedRoomPartOne: 'You missed the party in ',beginningOfArchivedRoomPartTwo: ({workspaceName, isAdminRoom}: beginningOfArchivedRoomPartTwo)=>`${isAdminRoom ? workspaceName : ''}`,beginningOfArchivedRoomPartThree: ", there's nothing to see here.",
From getRoomWelcomeMessage we will pass the policyName and explicitly check if it's AdminRoom so that we can hide the workspace name on other rooms where we display reportName in welcome message
changed the title [-]Workspace - Missing workspace name in "You missed the party in" in archived #admins room[/-][+][$250] Workspace - Missing workspace name in "You missed the party in" in archived #admins room[/+]on Feb 27, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Ollyws@CortneyOfstad@Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
1. Create a new workspace
2. Go to workspace settings > Overview
3. Press Share
4. Press #admins
5. Send a message in #admins
6. Go to workspace settings
7. Delete the workspace
Test:
1. Open the workspace #admins room
2. Verify the welcome text includes the admins room name
Activity
melvin-bot commentedon Feb 25, 2025
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Feb 25, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
"You missed the party in" message is missing the workspace name - You missed the party in , there's nothing to see here.
What is the root cause of that problem?
we don't add workspace name here
App/src/languages/en.ts
Line 720 in eaa3be4
What changes do you think we should make in order to solve the problem?
App/src/libs/SidebarUtils.ts
Line 742 in eaa3be4
OPTIONAL: If we want bold Workspace name then we can separate it and do the same as this PR
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
bernhardoj commentedon Feb 25, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The workspace name is missing from the archived admins room welcome message.
What is the root cause of that problem?
This happens after #57078. If the report is archived, we will have 2 phrases.
App/src/libs/SidebarUtils.ts
Lines 741 to 743 in d97f1b4
The 1st phrase is
You missed the party in ,. Previously, if it's archived, we use this to show the text. 1st phrase, report name, 2nd phrase.App/src/components/ReportWelcomeText.tsx
Lines 155 to 175 in d97f1b4
But after the PR, we ignore it if it's an admin room and instead, use this to show 4 phrases of the admin room if not archived.
App/src/components/ReportWelcomeText.tsx
Lines 177 to 184 in d97f1b4
What changes do you think we should make in order to solve the problem?
We need to move the admin room check to the same place as invoice room check.
App/src/components/ReportWelcomeText.tsx
Lines 155 to 159 in d97f1b4
Then, don't show this if it's an archived room.
App/src/components/ReportWelcomeText.tsx
Lines 177 to 184 in d97f1b4
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
samranahm commentedon Feb 25, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-02-25 14:16:50 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace - Missing workspace name in "You missed the party in" in archived #admins room
What is the root cause of that problem?
Currently, we are not passing the
policyNametobeginningOfArchivedRoomPartOnekey hereApp/src/languages/en.ts
Lines 720 to 721 in 9abc56b
That show the welcome text without workspace Name
What changes do you think we should make in order to solve the problem?
Add a new translation that will display
policy name,we already have
beginningOfArchivedRoomPartTwoso we will change that tobeginningOfArchivedRoomPartThreeAdd new types in
languages/params.tsFrom
getRoomWelcomeMessagewe will pass thepolicyNameand explicitly check if it'sAdminRoomso that we can hide the workspace name on other rooms where we displayreportNamein welcome messageAnd pass this third phrase for non admin rooms rooms here
App/src/components/ReportWelcomeText.tsx
Lines 174 to 183 in e12e4b3
add this line bellow 174
we already displaying the phrase3 for admin room so no need to change anything there
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A UI issue
What alternative solutions did you explore? (Optional)
Results
CortneyOfstad commentedon Feb 27, 2025
Adjusted the Actual Result in the main GH comment to make this more clear. Was able to recreate, so getting eyes on this!
[-]Workspace - Missing workspace name in "You missed the party in" in archived #admins room[/-][+][$250] Workspace - Missing workspace name in "You missed the party in" in archived #admins room[/+]melvin-bot commentedon Feb 27, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021895135725269863089
26 remaining items
melvin-bot commentedon Mar 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-21. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 14, 2025
@Ollyws @CortneyOfstad @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 21, 2025
Payment Summary
Upwork Job
BugZero Checklist (@CortneyOfstad)
CortneyOfstad commentedon Mar 21, 2025
@Ollyws can you please complete the checklist ASAP? Thanks!
Ollyws commentedon Mar 21, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/57078/files#r2007524853
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Ollyws commentedon Mar 21, 2025
Requested in ND.
bernhardoj commentedon Mar 21, 2025
Requested in ND.
garrettmknight commentedon Mar 24, 2025
$250 approved for @Ollyws
CortneyOfstad commentedon Mar 24, 2025
Payment Summary
@Ollyws — to be paid $250 via NewDot
@bernhardoj — to be paid $250 via NewDot
Regression Test
https://github.com/Expensify/Expensify/issues/483946
JmillsExpensify commentedon Mar 24, 2025
$250 approved for @bernhardoj