Skip to content

[Due for payment 2025-03-21] [$250] Workspace - Missing workspace name in "You missed the party in" in archived #admins room #57386

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.5-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Chat Report View

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace.
  3. Go to workspace settings > Overview.
  4. Click Share.
  5. Click #admins.
  6. Send a message in #admins.
  7. Go to workspace settings.
  8. Delete the workspace.
  9. Go back to #admins.

Expected Result:

"You missed the party in" message will include the workspace name.

Actual Result:

The workspace name is missing and only shows — "You missed the party in , there's nothing to see here."

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6753390_1740468193638.20250225_151332.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021895135725269863089
  • Upwork Job ID: 1895135725269863089
  • Last Price Increase: 2025-02-27
Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 25, 2025
  2. melvin-bot commented on Feb 25, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. daledah commented on Feb 25, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "You missed the party in" message is missing the workspace name - You missed the party in , there's nothing to see here.

    What is the root cause of that problem?

    we don't add workspace name here

    beginningOfArchivedRoomPartOne: 'You missed the party in ',

    What changes do you think we should make in order to solve the problem?

    1. Update this to add params workspace name
    beginningOfArchivedRoomPartOne: ({workspaceName}: BeginningOfChatHistoryAdminRoomPartOneParams) => `You missed the party in ${workspaceName}`,
    
    1. And pass workspace name here

    welcomeMessage.phrase1 = translateLocal('reportActionsView.beginningOfArchivedRoomPartOne');

    OPTIONAL: If we want bold Workspace name then we can separate it and do the same as this PR

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. bernhardoj commented on Feb 25, 2025

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The workspace name is missing from the archived admins room welcome message.

    What is the root cause of that problem?

    This happens after #57078. If the report is archived, we will have 2 phrases.

    if (isArchivedReportWithID(report?.reportID)) {
    welcomeMessage.phrase1 = translateLocal('reportActionsView.beginningOfArchivedRoomPartOne');
    welcomeMessage.phrase2 = translateLocal('reportActionsView.beginningOfArchivedRoomPartTwo');

    The 1st phrase is You missed the party in ,. Previously, if it's archived, we use this to show the text. 1st phrase, report name, 2nd phrase.

    {isChatRoom &&
    (!isInvoiceRoom || isArchivedRoom) &&
    !isAdminRoom &&
    (welcomeMessage?.messageHtml ? (
    <View style={styles.renderHTML}>
    <RenderHTML html={welcomeMessage.messageHtml} />
    </View>
    ) : (
    <Text>
    <Text>{welcomeMessage.phrase1}</Text>
    {welcomeMessage.showReportName && (
    <Text
    style={[styles.textStrong]}
    onPress={navigateToReport}
    suppressHighlighting
    >
    {getReportName(report)}
    </Text>
    )}
    {welcomeMessage.phrase2 !== undefined && <Text>{welcomeMessage.phrase2}</Text>}
    </Text>

    But after the PR, we ignore it if it's an admin room and instead, use this to show 4 phrases of the admin room if not archived.

    {isChatRoom && isAdminRoom && (
    <Text>
    <Text>{welcomeMessage.phrase1}</Text>
    {welcomeMessage.phrase2 !== undefined && <Text style={styles.textStrong}>{welcomeMessage.phrase2}</Text>}
    {welcomeMessage.phrase3 !== undefined && <Text>{welcomeMessage.phrase3}</Text>}
    {welcomeMessage.phrase4 !== undefined && <Text>{welcomeMessage.phrase4}</Text>}
    </Text>
    )}

    What changes do you think we should make in order to solve the problem?

    We need to move the admin room check to the same place as invoice room check.

    {isChatRoom &&
    (!isInvoiceRoom || isArchivedRoom) &&
    !isAdminRoom &&
    (welcomeMessage?.messageHtml ? (
    <View style={styles.renderHTML}>

    {isChatRoom && ((!isInvoiceRoom && !isAdminRoom) || isArchivedRoom) &&
    

    Then, don't show this if it's an archived room.

    {isChatRoom && isAdminRoom && (
    <Text>
    <Text>{welcomeMessage.phrase1}</Text>
    {welcomeMessage.phrase2 !== undefined && <Text style={styles.textStrong}>{welcomeMessage.phrase2}</Text>}
    {welcomeMessage.phrase3 !== undefined && <Text>{welcomeMessage.phrase3}</Text>}
    {welcomeMessage.phrase4 !== undefined && <Text>{welcomeMessage.phrase4}</Text>}
    </Text>
    )}

    {isChatRoom && isAdminRoom && !isArchivedRoom &&
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

  5. samranahm commented on Feb 25, 2025

    @samranahm
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-02-25 14:16:50 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace - Missing workspace name in "You missed the party in" in archived #admins room

    What is the root cause of that problem?

    Currently, we are not passing the policyName to beginningOfArchivedRoomPartOne key here

    App/src/languages/en.ts

    Lines 720 to 721 in 9abc56b

    beginningOfArchivedRoomPartOne: 'You missed the party in ',
    beginningOfArchivedRoomPartTwo: ", there's nothing to see here.",

    That show the welcome text without workspace Name

    What changes do you think we should make in order to solve the problem?

    Add a new translation that will display policy name,
    we already have beginningOfArchivedRoomPartTwo so we will change that to beginningOfArchivedRoomPartThree

    beginningOfArchivedRoomPartOne: 'You missed the party in ',
    beginningOfArchivedRoomPartTwo: ({workspaceName, isAdminRoom}: beginningOfArchivedRoomPartTwo) =>`${isAdminRoom ? workspaceName : ''}`,
    beginningOfArchivedRoomPartThree: ", there's nothing to see here.",

    Add new types in languages/params.ts

    type beginningOfArchivedRoomPartTwo = {
        workspaceName: string;
        isAdminRoom: boolean;
    };

    From getRoomWelcomeMessage we will pass the policyName and explicitly check if it's AdminRoom so that we can hide the workspace name on other rooms where we display reportName in welcome message

    const isAdminRoom = isAdminRoomReportUtils(report);
    
    if (isArchivedReportWithID(report?.reportID)) {
        welcomeMessage.phrase1 = translateLocal('reportActionsView.beginningOfArchivedRoomPartOne');
        welcomeMessage.phrase2 = translateLocal('reportActionsView.beginningOfArchivedRoomPartTwo', {workspaceName, isAdminRoomChat})
        welcomeMessage.phrase3 = translateLocal('reportActionsView.beginningOfArchivedRoomPartThree');

    And pass this third phrase for non admin rooms rooms here

    {welcomeMessage.phrase2 !== undefined && <Text>{welcomeMessage.phrase2}</Text>}
    </Text>
    ))}
    {isChatRoom && isAdminRoom && (
    <Text>
    <Text>{welcomeMessage.phrase1}</Text>
    {welcomeMessage.phrase2 !== undefined && <Text style={styles.textStrong}>{welcomeMessage.phrase2}</Text>}
    {welcomeMessage.phrase3 !== undefined && <Text>{welcomeMessage.phrase3}</Text>}
    {welcomeMessage.phrase4 !== undefined && <Text>{welcomeMessage.phrase4}</Text>}
    </Text>

    add this line bellow 174

    {welcomeMessage.phrase3 !== undefined && <Text>{welcomeMessage.phrase3}</Text>}
    

    we already displaying the phrase3 for admin room so no need to change anything there

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A UI issue

    What alternative solutions did you explore? (Optional)

    Results

    Image
    Image
  6. CortneyOfstad commented on Feb 27, 2025

    @CortneyOfstad
    Contributor

    Adjusted the Actual Result in the main GH comment to make this more clear. Was able to recreate, so getting eyes on this!

  7. changed the title [-]Workspace - Missing workspace name in "You missed the party in" in archived #admins room[/-] [+][$250] Workspace - Missing workspace name in "You missed the party in" in archived #admins room[/+] on Feb 27, 2025
  8. melvin-bot commented on Feb 27, 2025

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 27, 2025
  10. 26 remaining items

  11. melvin-bot commented on Mar 14, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-21. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Ollyws requires payment through NewDot Manual Requests
    • @bernhardoj requires payment through NewDot Manual Requests
  12. melvin-bot commented on Mar 14, 2025

    @melvin-bot

    @Ollyws @CortneyOfstad @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. melvin-bot commented on Mar 21, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@CortneyOfstad)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1895135725269863089/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. CortneyOfstad commented on Mar 21, 2025

    @CortneyOfstad
    Contributor

    @Ollyws can you please complete the checklist ASAP? Thanks!

  15. Ollyws commented on Mar 21, 2025

    @Ollyws
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/57078/files#r2007524853

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    1. Create a new workspace
    2. Go to workspace settings > Overview
    3. Press Share
    4. Press #admins
    5. Send a message in #admins
    6. Go to workspace settings
    7. Delete the workspace
    

    Test:

    1. Open the workspace #admins room
    2. Verify the welcome text includes the admins room name
    

    Do we agree 👍 or 👎

  16. Ollyws commented on Mar 21, 2025

    @Ollyws
    Contributor

    Requested in ND.

  17. bernhardoj commented on Mar 21, 2025

    @bernhardoj
    Contributor

    Requested in ND.

  18. garrettmknight commented on Mar 24, 2025

    @garrettmknight
    Contributor

    $250 approved for @Ollyws

  19. CortneyOfstad commented on Mar 24, 2025

    @CortneyOfstad
    Contributor

    Payment Summary

    @Ollyws — to be paid $250 via NewDot
    @bernhardoj — to be paid $250 via NewDot

    Regression Test

    https://github.com/Expensify/Expensify/issues/483946

  20. JmillsExpensify commented on Mar 24, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions