You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-05] [Due for payment 2025-06-04] [Due for payment 2025-06-02] [Simplified Actions] [App] Implement DeleteAppReport #57466
Nice! Let me know if you have questions. Right now we only have the DeleteReport command (same param signature), the PR to add the DeleteAppReport alias is in review
Sure! As far as I can tell from OP section, the DeleteAppReport implementation does not involve any new design changes other than the copy variation for the new API call:
Delete report
Are you sure you want to delete this report?
(already exists currently [DeleteMoneyRequest]):
Delete expense
Are you sure you want to delete this expense?
The goal here being that in case a report has more expenses we will use the new DeleteAppReport that will optimistically delete the report and unreport all transactions on the report, which current DeleteMoneyRequest does not do.
Did I understand this task correctly ?
the PR to add the DeleteAppReport alias is in review
Does this mean that if I call the API right now to test the implementation, it would not work yet since the backend PR wasn't merged right ? If that's the case please let me know as soon as the BE part is available (staging or prod).
We generally refrain from applying penalties to PRs that implement new features. I guess that is the reason why the penalty for regression wasn't raised earlier
If a PR causes a regression at any point within the regression period (starting when the code is merged and ending 168 hours (that's 7 days) after being deployed to production):
payments will be issued 7 days after all regressions are fixed (ie: deployed to production)
a 50% penalty will be applied to the Contributor and Contributor+ for each regression on an issue
The 168 hours (aka 7 days) will be measured by calculating the time between when the PR is merged, and when a bug is posted to the #expensify-bugs Slack channel.
This is applicable whether the PR is for a bug or a new feature.
Activity
melvin-bot commentedon Feb 26, 2025
Triggered auto assignment to @kadiealexander (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.luacmartins commentedon Feb 26, 2025
@ikevin127 you can start working on implementing this one! Please prioritize it since it's part of a critical project.
ikevin127 commentedon Feb 26, 2025
Will start working on this today 👍
luacmartins commentedon Feb 26, 2025
Nice! Let me know if you have questions. Right now we only have the
DeleteReportcommand (same param signature), the PR to add theDeleteAppReportalias is in reviewikevin127 commentedon Feb 26, 2025
Sure! As far as I can tell from OP section, the
DeleteAppReportimplementation does not involve any new design changes other than the copy variation for the new API call:(already exists currently [
DeleteMoneyRequest]):The goal here being that in case a
report has more expenseswe will use the newDeleteAppReportthatwill optimistically delete the report and unreport all transactions on the report, which currentDeleteMoneyRequestdoes not do.Did I understand this task correctly ?
Does this mean that if I call the API right now to test the implementation, it would not work yet since the backend PR wasn't merged right ? If that's the case please let me know as soon as the BE part is available (staging or prod).
92 remaining items
allgandalf commentedon Jun 9, 2025
@kadiealexander I am still paid via upwork, can you please pay me via upwork?
mallenexpensify commentedon Jun 9, 2025
This issue caused regressions
The PR for this hit production on May 27
And the PR to fix shit was created the day before
So.. this should be $125 (or half for causing two regressions?).
@DylanDylann and @allgandalf please provide feedback and links/timeline, where applicable. Thx
kadiealexander commentedon Jun 10, 2025
Updated the payment summary, @DylanDylann and @allgandalf can you guys please address Matt's questions above? Thanks!
kadiealexander commentedon Jun 13, 2025
@DylanDylann and @allgandalf bump!
DylanDylann commentedon Jun 13, 2025
We generally refrain from applying penalties to PRs that implement new features. I guess that is the reason why the penalty for regression wasn't raised earlier
kadiealexander commentedon Jun 16, 2025
The contributing guidelines mention that:
This is applicable whether the PR is for a bug or a new feature.
kadiealexander commentedon Jun 18, 2025
@DylanDylann and @allgandalf please accept the Upwork contracts I sent across 🙏
DylanDylann commentedon Jun 18, 2025
@kadiealexander I get paid via NewDot now
allgandalf commentedon Jun 19, 2025
Can you pay me please @kadiealexander
kadiealexander commentedon Jun 19, 2025
Payment summary here. @DylanDylann please request via NewDot.
JmillsExpensify commentedon Aug 7, 2025
$125 approved for @DylanDylann