Skip to content

[Due for payment 2025-06-05] [Due for payment 2025-06-04] [Due for payment 2025-06-02] [Simplified Actions] [App] Implement DeleteAppReport #57466

Closed

Description

@luacmartins

Implement this section of the #migrate: Simplified actions framework for all reports design doc

Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. self-assigned this
    on Feb 26, 2025
  2. melvin-bot commented on Feb 26, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  3. luacmartins commented on Feb 26, 2025

    @luacmartins
    ContributorAuthor

    @ikevin127 you can start working on implementing this one! Please prioritize it since it's part of a critical project.

  4. ikevin127 commented on Feb 26, 2025

    @ikevin127
    Contributor

    Will start working on this today 👍

  5. luacmartins commented on Feb 26, 2025

    @luacmartins
    ContributorAuthor

    Nice! Let me know if you have questions. Right now we only have the DeleteReport command (same param signature), the PR to add the DeleteAppReport alias is in review

  6. ikevin127 commented on Feb 26, 2025

    @ikevin127
    Contributor

    Sure! As far as I can tell from OP section, the DeleteAppReport implementation does not involve any new design changes other than the copy variation for the new API call:

    Delete report
    Are you sure you want to delete this report?
    

    (already exists currently [DeleteMoneyRequest]):

    Delete expense
    Are you sure you want to delete this expense?
    

    The goal here being that in case a report has more expenses we will use the new DeleteAppReport that will optimistically delete the report and unreport all transactions on the report, which current DeleteMoneyRequest does not do.

    Did I understand this task correctly ?

    the PR to add the DeleteAppReport alias is in review

    Does this mean that if I call the API right now to test the implementation, it would not work yet since the backend PR wasn't merged right ? If that's the case please let me know as soon as the BE part is available (staging or prod).

  7. 92 remaining items

  8. allgandalf commented on Jun 9, 2025

    @allgandalf
    Contributor

    @kadiealexander I am still paid via upwork, can you please pay me via upwork?

  9. mallenexpensify commented on Jun 9, 2025

    @mallenexpensify
    Contributor

    This issue caused regressions

    The PR for this hit production on May 27

    Image

    And the PR to fix shit was created the day before

    Image

    So.. this should be $125 (or half for causing two regressions?).

    @DylanDylann and @allgandalf please provide feedback and links/timeline, where applicable. Thx

  10. kadiealexander commented on Jun 10, 2025

    @kadiealexander
    Contributor

    Updated the payment summary, @DylanDylann and @allgandalf can you guys please address Matt's questions above? Thanks!

  11. kadiealexander commented on Jun 13, 2025

    @kadiealexander
    Contributor
  12. DylanDylann commented on Jun 13, 2025

    @DylanDylann
    Contributor

    We generally refrain from applying penalties to PRs that implement new features. I guess that is the reason why the penalty for regression wasn't raised earlier

  13. kadiealexander commented on Jun 16, 2025

    @kadiealexander
    Contributor

    The contributing guidelines mention that:

    If a PR causes a regression at any point within the regression period (starting when the code is merged and ending 168 hours (that's 7 days) after being deployed to production):

    • payments will be issued 7 days after all regressions are fixed (ie: deployed to production)
    • a 50% penalty will be applied to the Contributor and Contributor+ for each regression on an issue

    The 168 hours (aka 7 days) will be measured by calculating the time between when the PR is merged, and when a bug is posted to the #expensify-bugs Slack channel.

    This is applicable whether the PR is for a bug or a new feature.

  14. kadiealexander commented on Jun 18, 2025

    @kadiealexander
    Contributor

    @DylanDylann and @allgandalf please accept the Upwork contracts I sent across 🙏

  15. DylanDylann commented on Jun 18, 2025

    @DylanDylann
    Contributor

    @kadiealexander I get paid via NewDot now

  16. allgandalf commented on Jun 19, 2025

    @allgandalf
    Contributor

    Can you pay me please @kadiealexander

  17. kadiealexander commented on Jun 19, 2025

    @kadiealexander
    Contributor

    Payment summary here. @DylanDylann please request via NewDot.

  18. JmillsExpensify commented on Aug 7, 2025

    @JmillsExpensify
    Contributor

    $125 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions