Skip to content

[Due for payment 2025-04-14] [$250] Next Steps - Incorrect next steps is shown when submitting expense offline. #57574

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.7-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #56770
Email or phone of affected tester (no customers): applausetester+bm578@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb
App Component: Chat Report View

Action Performed:

Precondition -
Delay submission is disabled
Add approvals is disabled.

  1. Go to staging.new.expensify.com
  2. Create a new workspace.
  3. Go to workspace settings > Members.
  4. Invite a member to the workspace.
  5. Go offline.
  6. Go to workspace settings > Workflows.
  7. Enable Add approvals.
  8. Click on the existing workflow.
  9. Click Approver.
  10. Select the member invited in Step 5 as the new approver.
  11. Save the workflow.
  12. Go back to Inbox.
  13. Create a manual expense
  14. Open the expense preview and check the next steps

Expected Result:

The next steps should say ""Waiting for [new approver] to approve expense(s)"

Actual Result:

The next steps say "Waiting for an admin to pay expense(s)"

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6756956_1740694901424.bandicam_2025-02-28_00-52-51-130.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021896395736858566110
  • Upwork Job ID: 1896395736858566110
  • Last Price Increase: 2025-03-03
  • Automatic offers:
    • suneox | Reviewer | 106412403
    • daledah | Contributor | 106412407
Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 28, 2025
  2. melvin-bot commented on Feb 28, 2025

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Feb 28, 2025

    @melvin-bot

    Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Feb 28, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Feb 28, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mitarachim commented on Feb 28, 2025

    @mitarachim
    Author

    QA team found different behavior in Prod , it says Waiting for your expense(s) to automatically submit

    bandicam.2025-02-28.04-26-07-297.mp4
  7. jacobkim9881 commented on Feb 28, 2025

    @jacobkim9881
    Contributor
  8. 38 remaining items

  9. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    This issue has not been updated in over 15 days. @robertjchen, @slafortune, @suneox, @daledah eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 7, 2025
  11. changed the title [-][$250] Next Steps - Incorrect next steps is shown when submitting expense offline.[/-] [+][Due for payment 2025-04-14] [$250] Next Steps - Incorrect next steps is shown when submitting expense offline.[/+] on Apr 7, 2025
  12. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-14. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    @suneox @slafortune @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. suneox commented on Apr 13, 2025

    @suneox
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/56950/files#r2041082314

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      N/A: it isn't an impactful bug just happen in offline mode get optimistic data

  16. slafortune commented on Apr 14, 2025

    @slafortune
    Contributor

    @suneox Role C+ Paid $250 via Upworks
    @daledah Role Contributor Paid $250 via Upworks

  17. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions