You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-14] [$250] Next Steps - Incorrect next steps is shown when submitting expense offline. #57574
Version Number: 9.1.7-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail:#56770 Email or phone of affected tester (no customers):applausetester+bm578@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Web, mweb App Component: Chat Report View
Action Performed:
Precondition -
Delay submission is disabled
Add approvals is disabled.
Go to staging.new.expensify.com
Create a new workspace.
Go to workspace settings > Members.
Invite a member to the workspace.
Go offline.
Go to workspace settings > Workflows.
Enable Add approvals.
Click on the existing workflow.
Click Approver.
Select the member invited in Step 5 as the new approver.
Save the workflow.
Go back to Inbox.
Create a manual expense
Open the expense preview and check the next steps
Expected Result:
The next steps should say ""Waiting for [new approver] to approve expense(s)"
Actual Result:
The next steps say "Waiting for an admin to pay expense(s)"
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
changed the title [-][$250] Next Steps - Incorrect next steps is shown when submitting expense offline.[/-][+][Due for payment 2025-04-14] [$250] Next Steps - Incorrect next steps is shown when submitting expense offline.[/+]on Apr 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox@slafortune@suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
N/A: it isn't an impactful bug just happen in offline mode get optimistic data
Activity
melvin-bot commentedon Feb 28, 2025
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Feb 28, 2025
Triggered auto assignment to @robertjchen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Feb 28, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Feb 28, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mitarachim commentedon Feb 28, 2025
QA team found different behavior in Prod , it says
Waiting for your expense(s) to automatically submitbandicam.2025-02-28.04-26-07-297.mp4
jacobkim9881 commentedon Feb 28, 2025
#56950
38 remaining items
melvin-bot commentedon Mar 31, 2025
This issue has not been updated in over 15 days. @robertjchen, @slafortune, @suneox, @daledah eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
[-][$250] Next Steps - Incorrect next steps is shown when submitting expense offline.[/-][+][Due for payment 2025-04-14] [$250] Next Steps - Incorrect next steps is shown when submitting expense offline.[/+]melvin-bot commentedon Apr 7, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 7, 2025
@suneox @slafortune @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
suneox commentedon Apr 13, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/56950/files#r2041082314
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
N/A: it isn't an impactful bug just happen in offline mode get optimistic data
slafortune commentedon Apr 14, 2025
@suneox Role C+ Paid $250 via Upworks
@daledah Role Contributor Paid $250 via Upworks