Skip to content

[Due for payment 2025-04-18] [$250] Android - Room -When editing mention, big space is displayed between suggestion and composer #57734

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Email or phone of affected tester (no customers): ibellicotest+345@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12
App Component: Other

Action Performed:

  1. Open the Expensify app.
  2. Open any room chat or create one if necessary.
  3. Send a mention of any user that is not part of the room.
  4. Send another mention of a different user that is not part of the room.
  5. Return to inbox and open room again, so the system message for the first mention, appears again.
  6. With the keyboard opened, long tap over the second mention and select "Edit Message"
  7. Check the gap displayed between the mentions suggestions box and the edition composer.

Expected Result:

Suggestions box should be displayed above the edition composer, without a big space in between.

Actual Result:

When trying to edit a mention that is displayed below a system message of a different mention, a big space is displayed between suggestions box and edition composer.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6760576_1741063981536.Gap.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021897461467419381223
  • Upwork Job ID: 1897461467419381223
  • Last Price Increase: 2025-03-06
Issue OwnerCurrent Issue Owner: @OfstadC / @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 4, 2025
  2. melvin-bot commented on Mar 4, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mallenexpensify commented on Mar 5, 2025

    @mallenexpensify
    Contributor

    Think it's wrong vid in OP, asked about in `#qa

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 6, 2025
  5. changed the title [-]Android - Room -When editing mention, big space is displayed between suggestion and composer[/-] [+][$250] Android - Room -When editing mention, big space is displayed between suggestion and composer[/+] on Mar 6, 2025
  6. melvin-bot commented on Mar 6, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 6, 2025
  8. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  9. mallenexpensify commented on Mar 6, 2025

    @mallenexpensify
    Contributor

    Was able to repro, sent to pool, reckon it should be able to be fixed externally
    Image

  10. zirgulis commented on Mar 6, 2025

    @zirgulis
    Contributor

    Hi I'm Povilas from Callstack and I would like to work on this issue

  11. 37 remaining items

  12. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-18. 🎊

    For reference, here are some details about the assignees on this issue:

    • @jjcoffee requires payment through NewDot Manual Requests
    • @zirgulis does not require payment (Contractor)
  14. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    @jjcoffee @OfstadC / @mallenexpensify @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. mallenexpensify commented on Apr 14, 2025

    @mallenexpensify
    Contributor

    @OfstadC thanks for keeping 👀 on, I unassigned ya.

  16. jjcoffee commented on Apr 17, 2025

    @jjcoffee
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: https://github.com/Expensify/App/pull/42630/files#r2048441024

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Android-only, ideally test on devices of different sizes

    Test:

    1. Open any room chat or create one if necessary.
    2. Send a mention of any user that is not part of the room.
    3. Send another mention of a different user that is not part of the room.
    4. Return to inbox and open room again, so the system message for the first mention, appears again.
    5. With the keyboard opened, long tap over the second mention and select "Edit Message"
    6. Verify that the suggestions box is displayed above the composer, without an unusually large gap.

    Do we agree 👍 or 👎

  17. melvin-bot commented on Apr 18, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @jjcoffee owed $250 via NewDot
    • Contributor: @zirgulis is from an agency-contributor and not due payment

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1897461467419381223/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  18. mallenexpensify commented on Apr 21, 2025

    @mallenexpensify
    Contributor

    Contributor+: @jjcoffee due $250 via NewDot

    Test case created

    @jasperhuangg , I see this comment on the PR

    @kavimuru That is unrelated to the original issue as it only deals with Android. Is there an existing issue for this, or can we create one to track the iOS version of this problem?

    QA doesn't monitor GHs, if we need a bug report created, can you post in Slack and add the 'bug' emoji so QA can create a new one? Thx

  19. garrettmknight commented on Apr 28, 2025

    @garrettmknight
    Contributor

    $250 approved for @jjcoffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions