[$250] Bank - Payment account and payer fields do not appear after adding bank account

@vnvianna

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+030305kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Go to staging.new.expensify.com
Go to workspace settings > Workflows.
Click Connect bank account.
Click Log into your bank.
Go throught the setup.
On the final step (T&C checkboxes), mark all the checkboxes and click Save and continue.
Close the RHP.

Expected Result:

After the bank account is added, payment account and payer will be shown under "Make or track payments".

Actual Result:

After the bank account is added, payment account and payer are not shown under "Make or track payments".

It requires page refresh for the fields to show up.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6760708_1741082022197.20250304_174511.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021899472044764959575
Upwork Job ID: 1899472044764959575
Last Price Increase: 2025-08-28
Automatic offers:

allgandalf | Reviewer | 106557416
mkzie2 | Contributor | 106557418

Issue Owner

Current Issue Owner: @vnvianna

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@s77rt

Proposal

Please re-state the problem that we are trying to solve in this issue.

After the bank account is added, payment account and payer are not shown under "Make or track payments".

What is the root cause of that problem?

I think this came from #56932 where the OpenPolicyWorkflowsPage is not re-triggered after closing the RHP. cc @s77rt @abzokhattab

Previously we use useFocusEffect to re-trigger OpenPolicyWorkflowsPage to keep data up to date whenever the page gets re-focused (closing the RHP is one of those cases).

What changes do you think we should make in order to solve the problem?

We can reapply useFocusEffect for this page only to temporarily fix this issue as this flow is a critical important flow.

useFocusEffect(
    useCallback(() => {
        InteractionManager.runAfterInteractions(() => {
            fetchData();
        });
    }, [fetchData]),
);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Optimistically update policy.achAccount in addPersonalBankAccount here (I see a TODO there saying we should implement offline pattern soon but it has not been done)
Make the BE AddPersonalBankAccount returns the correct policy.achAccount.

I prefer to not add that use effect. Can wo do one of the following:

Optimistically set the bank info data if possible
Have the BE return onyx data after the bank is added

@bfitzexpensify

@bfitzexpensify Eep! 4 days overdue now. Issues have feelings too...

Job added to Upwork: https://www.upwork.com/jobs/~021899472044764959575

@allgandalf

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

@mkzie2

Hi @mkzie2, the https://github.com/Expensify/Auth/pull/17214 was deployed. Let me know if you need anything more.

@vnvianna

Confirm that it was fixed:

Screen.Recording.2025-09-23.at.16.44.49.mov

Thank you @vnvianna! @mallenexpensify or @bfitzexpensify We can proceed payment and close this out.

@mkzie2

Wow, this is a beast of an issue. is this the payment summary?

Payment Summary

Contributor: @mkzie2 paid $250 via Upwork
Contributor+: @parasharrajat due $125 via NewDot (per here)

@parasharrajat , can fill out the BZ checklist plz?

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

@vnvianna

@vnvianna Huh... This is 4 days overdue. Who can take care of this?

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: Revert: "Fix: Read API is not triggered consistently when switching between features of a Collect workspace" #56932 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Test:

Go to workspace settings > Workflows.
Click Connect bank account.
Click Log into your bank.
Go through the setup.
On the final step (T&C checkboxes), mark all the checkboxes and click Save and continue.
Close the RHP.
Verify that the added bank account appears in the Workflows page

Do we agree 👍 or 👎

Issue mostly closed, calm down, Melvin.

@parasharrajat

@parasharrajat , @mkzie2 can you help me here plzzzzz

Can you confirm this is the right payment here?

Contributor: @mkzie2 paid $250 via Upwork
Contributor+: @parasharrajat due $125 via NewDot (per #57742 (comment))

What's the front end PR here? I need it for the test case. [HOLD BE] add optimistic data for addPersonalBankAccount #58973 looks like it's Draft and wasn't merged.

So we don't need the FE solution now as we handled these changes on the backend. Summary looks correct.

@mkzie2

Payment Summary

Contributor: @mkzie2 paid $250 via Upwork
Contributor+: @parasharrajat due $125 via NewDot

Test case

https://github.com/Expensify/Expensify/issues/551251

Payment requested as per #57742 (comment)

@parasharrajat

approved $125 for @parasharrajat.

Navigation Menu

Repository navigation

[$250] Bank - Payment account and payer fields do not appear after adding bank account #57742

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

116 remaining items

Payment Summary

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

BugZero Checklist:

Regression Test Proposal

Test:

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$250] Bank - Payment account and payer fields do not appear after adding bank account #57742

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 4, 2025

mkzie2 commented on Mar 4, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

s77rt commented on Mar 4, 2025

melvin-bot commented on Mar 10, 2025

melvin-bot commented on Mar 11, 2025

melvin-bot commented on Mar 11, 2025

116 remaining items

vnvianna commented on Sep 18, 2025

mkzie2 commented on Sep 23, 2025

mallenexpensify commented on Sep 23, 2025

Payment Summary

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

melvin-bot commented on Sep 23, 2025

parasharrajat commented on Sep 24, 2025

BugZero Checklist:

Regression Test Proposal

Test:

vnvianna commented on Sep 24, 2025

mallenexpensify commented on Sep 24, 2025

parasharrajat commented on Sep 25, 2025

mallenexpensify commented on Sep 25, 2025

Payment Summary

parasharrajat commented on Nov 9, 2025

trjExpensify commented on Nov 17, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions