Skip to content

[Due for payment 2025-03-27] [Due for payment 2025-03-24] [$250] Wallet Animation and continue button is misplaced & shown on the top #57746

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.1.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Other

Action Performed:

  1. Launch app
  2. Login with expensifail account
  3. Tap settings - wallet - add bank account and complete the flow
  4. At the end of flow, tap confirm

Expected Result:

In wallet- add account page, animation must be show in centre and continue button must shown at the bottom of the page.

Actual Result:

In wallet-add account page, animation and continue button is misplaced & shown on the top.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6760772_1741088825424.screenrecorder-2025-03-04-13-08-53-715.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021897178197260043781
  • Upwork Job ID: 1897178197260043781
  • Last Price Increase: 2025-03-05
  • Automatic offers:
    • Krishna2323 | Contributor | 106425986
Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 4, 2025
  2. melvin-bot commented on Mar 4, 2025

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. Krishna2323 commented on Mar 4, 2025

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Wallet Animation and continue button is misplaced & shown on the top

    What is the root cause of that problem?

    • The ConfirmationPage component isn't wrapped in a scrollview with flexGrow1 styles.
      <ConfirmationPage
      heading={translate('addPersonalBankAccountPage.successTitle')}
      description={translate('addPersonalBankAccountPage.successMessage')}
      shouldShowButton
      buttonText={translate('common.continue')}
      onButtonPress={onNext}
      />
      );

    What changes do you think we should make in order to solve the problem?

    • We should wrap the component with a scrollview and apply styles.flexGrow1 to scroll view and styles.h100 to container of the ConfirmationPage copmonent
    • Adding a scrollview is optional but I think that's preffered.
            <ScrollView contentContainerStyle={styles.flexGrow1}>
                <ConfirmationPage
                    heading={translate('addPersonalBankAccountPage.successTitle')}
                    description={translate('addPersonalBankAccountPage.successMessage')}
                    shouldShowButton
                    buttonText={translate('common.continue')}
                    onButtonPress={onNext}
                    containerStyle={styles.h100}
                />
            </ScrollView>

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A -- UI issue.

    What alternative solutions did you explore? (Optional)

    Result

    Monosnap.screencast.2025-03-04.18-44-56.mp4
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 5, 2025
  5. changed the title [-]Wallet Animation and continue button is misplaced & shown on the top[/-] [+][$250] Wallet Animation and continue button is misplaced & shown on the top[/+] on Mar 5, 2025
  6. melvin-bot commented on Mar 5, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 5, 2025
  8. melvin-bot commented on Mar 5, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  9. stephanieelliott commented on Mar 5, 2025

    @stephanieelliott
    Contributor

    @sobitneupane we have a proposal here already, can you take a look when you get a sec?

  10. sobitneupane commented on Mar 7, 2025

    @sobitneupane
    Contributor

    Thanks, @Krishna2323!

    Proposal from @Krishna2323 looks good to me.

    🎀 👀 🎀 C+ reviewed

  11. melvin-bot commented on Mar 7, 2025

    @melvin-bot

    Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  12. 25 remaining items

  13. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-27. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    @sobitneupane @stephanieelliott @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. stephanieelliott commented on Mar 27, 2025

    @stephanieelliott
    Contributor

    Prepping for payment tomorrow -- @sobitneupane can you please complete the BZ checklist when you get a chance?

  16. sobitneupane commented on Mar 31, 2025

    @sobitneupane
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Implemented International Bank Account flow #54798 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Launch app
    2. Login with expensifail account
    3. Tap settings - wallet -
      • add bank account using plaid and complete the flow
      • add bank account (manual) and complete the flow
    4. At the end of flow select a account and tap confirm
    5. Verify animation is shown in the middle and continue button is at the bottom

    Do we agree 👍 or 👎

  17. stephanieelliott commented on Apr 1, 2025

    @stephanieelliott
    Contributor
  18. stephanieelliott commented on Apr 1, 2025

    @stephanieelliott
    Contributor

    Summarizing payment on this issue:

    Upwork job is here: https://www.upwork.com/jobs/~021897178197260043781

  19. garrettmknight commented on May 20, 2025

    @garrettmknight
    Contributor

    $250 approved for @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions