You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-27] [Due for payment 2025-03-24] [$250] Wallet Animation and continue button is misplaced & shown on the top #57746
Version Number: V9.1.8-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 App Component: Other
Action Performed:
Launch app
Login with expensifail account
Tap settings - wallet - add bank account and complete the flow
At the end of flow, tap confirm
Expected Result:
In wallet- add account page, animation must be show in centre and continue button must shown at the bottom of the page.
Actual Result:
In wallet-add account page, animation and continue button is misplaced & shown on the top.
What changes do you think we should make in order to solve the problem?
We should wrap the component with a scrollview and apply styles.flexGrow1 to scroll view and styles.h100 to container of the ConfirmationPage copmonent
Adding a scrollview is optional but I think that's preffered.
changed the title [-]Wallet Animation and continue button is misplaced & shown on the top[/-][+][$250] Wallet Animation and continue button is misplaced & shown on the top[/+]on Mar 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@sobitneupane@stephanieelliott@sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Launch app
Login with expensifail account
Tap settings - wallet -
add bank account using plaid and complete the flow
add bank account (manual) and complete the flow
At the end of flow select a account and tap confirm
Verify animation is shown in the middle and continue button is at the bottom
Activity
melvin-bot commentedon Mar 4, 2025
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Krishna2323 commentedon Mar 4, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Wallet Animation and continue button is misplaced & shown on the top
What is the root cause of that problem?
ConfirmationPagecomponent isn't wrapped in ascrollviewwithflexGrow1styles.App/src/pages/settings/Wallet/InternationalDepositAccount/substeps/Success.tsx
Lines 10 to 17 in 734bc98
What changes do you think we should make in order to solve the problem?
scrollviewand applystyles.flexGrow1to scroll view andstyles.h100to container of theConfirmationPagecopmonentWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A -- UI issue.
What alternative solutions did you explore? (Optional)
Result
Monosnap.screencast.2025-03-04.18-44-56.mp4
[-]Wallet Animation and continue button is misplaced & shown on the top[/-][+][$250] Wallet Animation and continue button is misplaced & shown on the top[/+]melvin-bot commentedon Mar 5, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021897178197260043781
melvin-bot commentedon Mar 5, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)stephanieelliott commentedon Mar 5, 2025
@sobitneupane we have a proposal here already, can you take a look when you get a sec?
sobitneupane commentedon Mar 7, 2025
Thanks, @Krishna2323!
Proposal from @Krishna2323 looks good to me.
🎀 👀 🎀 C+ reviewed
melvin-bot commentedon Mar 7, 2025
Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
25 remaining items
melvin-bot commentedon Mar 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-27. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 20, 2025
@sobitneupane @stephanieelliott @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
stephanieelliott commentedon Mar 27, 2025
Prepping for payment tomorrow -- @sobitneupane can you please complete the BZ checklist when you get a chance?
sobitneupane commentedon Mar 31, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Implemented International Bank Account flow #54798 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
stephanieelliott commentedon Apr 1, 2025
Issue for TR case: https://github.com/Expensify/Expensify/issues/486325
stephanieelliott commentedon Apr 1, 2025
Summarizing payment on this issue:
Upwork job is here: https://www.upwork.com/jobs/~021897178197260043781
garrettmknight commentedon May 20, 2025
$250 approved for @sobitneupane