Repository navigation
[HOLD for payment 2021-11-04] Workspace - Add a image size restriction to workspace editor - Reported by: @akshayasalvi #5778
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Navigate to workspace editor
- Upload a workspace image that's over 50mb
Expected Result:
There should be a restriction to uploading large size images.
Actual Result:
User can upload very heavy files as workspace image.
Workaround:
None needed.
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.1.7-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @akshayasalvi
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1633985140145400
Activity
MelvinBot commentedon Oct 12, 2021
Triggered auto assignment to @MonilBhavsar (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MonilBhavsar commentedon Oct 14, 2021
I was able to upload large images. We should keep the size validation with 3MB limit. https://expensify.slack.com/archives/C01GTK53T8Q/p1634205377267400
We can use same copy as we have in old dot.
MelvinBot commentedon Oct 14, 2021
Triggered auto assignment to @bfitzexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.6 remaining items
bfitzexpensify commentedon Oct 14, 2021
@pecanoro, the exported label isn't working so I randomly chose you from the list of engineering contributor managers 😄.
@akshayasalvi Has identified the problem + a solution above, so hopefully this one is straightforward.
pecanoro commentedon Oct 14, 2021
@akshayasalvi sounds good! Go ahead!
akshayasalvi commentedon Oct 14, 2021
@pecanoro I'll get started on the PR. Can you help me with the content in Spanish? Here's what I have from translate.google.com
Title: Error al cargar la imagen
Description: El siguiente archivo supera el tamaño máximo de carga de 3 MB
pecanoro commentedon Oct 14, 2021
Title: Error al cargar la imagen
Description: La imagen supera el tamaño máximo de 3 MB
akshayasalvi commentedon Oct 14, 2021
Thank you
pecanoro commentedon Oct 14, 2021
@tichnas Yes, I am afraid so. He already proposed a solution that has been accepted.
bfitzexpensify commentedon Oct 15, 2021
@akshayasalvi I hired you for the posting FYI
akshayasalvi commentedon Oct 15, 2021
Thanks, @bfitzexpensify. PR Raised
parasharrajat commentedon Oct 15, 2021
I will be reviewing the PR and I will let you know @pecanoro when this is ready for final review and possibly for merge. See More
[-]Workspace - Add a image size restriction to workspace editor - Reported by: @akshayasalvi[/-][+][HOLD for payment 2021-11-04] Workspace - Add a image size restriction to workspace editor - Reported by: @akshayasalvi[/+]bfitzexpensify commentedon Nov 4, 2021
Contract ended and paid you @akshayasalvi — thanks for reporting and fixing!