Skip to content

[Due for payment 2025-03-17] Remove mostRecentReportActionLastModified from reconnectApp #57784

Closed

Description

@MarioExpensify

Description

Sometimes the App sends a mostRecentReportActionLastModified date as a parameter in calls for ReconnectApp command, with the change to use onyx method SetCollection every time a full reconnect is needed, the resulting data cleans the entire reports_ collection in the FE.

By removing the mostRecentReportActionLastModified parameter we ensure that if a full reconnect is required, the full data will be sent (instead of only incremental data).

A follow up to this issue would be to ensure every time we actually only need an incremental update the GetMissingOnyxMessages command is used instead of ReconnectApp.

Context: https://expensify.slack.com/archives/C05LX9D6E07/p1739993730112349

Activity

  1. added
    ReviewingHas a PR in review
    and removed on Mar 4, 2025
  2. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 10, 2025
  3. changed the title [-]Remove mostRecentReportActionLastModified from reconnectApp[/-] [+][Due for payment 2025-03-17] Remove mostRecentReportActionLastModified from reconnectApp[/+] on Mar 10, 2025
  4. melvin-bot commented on Mar 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  5. melvin-bot commented on Mar 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.10-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-17. 🎊

  6. melvin-bot commented on Mar 17, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  7. MarioExpensify commented on Mar 19, 2025

    @MarioExpensify
    ContributorAuthor

    Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions