Repository navigation
[Due for payment 2025-03-17] [Due for payment 2025-03-13] LHN - FAB does not close when clicking FAB button again when FAB is opened #57797
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.9-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to the report page (search page)
- Click FAB
- Click FAB again (now X button)
Expected Result:
FAB closes (production behavior)
Actual Result:
Nothing happens after clicking FAB button when FAB is already opened
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Mar 4, 2025
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 4, 2025
Triggered auto assignment to @tgolen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 4, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 4, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
16 remaining items
tgolen commentedon Mar 7, 2025
I think can be closed now. It's not subject to the regression period since the result was reverting the original PR.
[-][Due for payment 2025-03-13] LHN - FAB does not close when clicking FAB button again when FAB is opened[/-][+][Due for payment 2025-03-17] [Due for payment 2025-03-13] LHN - FAB does not close when clicking FAB button again when FAB is opened[/+]melvin-bot commentedon Mar 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.10-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-17. 🎊
rushatgabhane commentedon Apr 2, 2025
@sonialiap requesting payment summary for review of the linked PR, thank you!
#57890 (comment)
garrettmknight commentedon Apr 10, 2025
@sonialiap can you help me out with a payment summary, please?
sonialiap commentedon Apr 10, 2025
Payment summary:
$125 for reviewing the PR without tests. If you agree, please request in ND. If you disagree, let me know :)EDIT: updating to $250 since Rushat confirmed that he did test the PR
cc @garrettmknight
rushatgabhane commentedon Apr 11, 2025
i think it should be standard amount because i did test the PR with tests for FAB
sonialiap commentedon Apr 11, 2025
Thanks Rushat. Updating the summary to $250
sonialiap commentedon Apr 11, 2025
Updated payment summary:
cc @garrettmknight
garrettmknight commentedon Apr 22, 2025
$250 approved for @rushatgabhane