Repository navigation
Help panel - Help RHP does not close when clicking outside RHP or with ESC key #57798
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.9-0
Reproducible in staging?: Y
Reproducible in production?: No, unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+030306kh@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
- Developer panel is opened on the right.
- Go to staging.new.expensify.com
- Go to workspace settings > Categories
- Open any category
- Click Help icon
- Click outside RHP
- Note that help RHP does not close
- Open any category
- Press ESC key
- Note that app returns to workspace list while help RHP is opened
- Click outside help RHP
- Note that help RHP does not close
Expected Result:
In Step 6, 9 and 11 help RHP will close
Actual Result:
In Step 6, 9 and 11 help RHP does not close
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Mar 4, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 4, 2025
Triggered auto assignment to @MonilBhavsar (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 4, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 4, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
6 remaining items
MonilBhavsar commentedon Mar 4, 2025
Thank you @francoisl 🙌
blazejkustra commentedon Mar 5, 2025
Hey! I’m Błażej Kustra from Software Mansion, this regression comes from my PR so I'd like to work on it 👀
MonilBhavsar commentedon Mar 6, 2025
Thank you! I assigned you. Also assigned @brunovjk as a C+
blazejkustra commentedon Mar 27, 2025
This was fixed here. I believe we can close this issue! cc @MonilBhavsar
brunovjk commentedon Mar 27, 2025
I can't reproduce this anymore after implementing this PR. Tested on 27 Mar v9.1.20-2 Develop. We can close, payment and BZ checklist will be handled here. Thanks!
MonilBhavsar commentedon Mar 27, 2025
Thank you!