You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-27] [$150] Correctly escape quotes for travel/hotel addresses #57801
We're not currently escaping quotations for addresses on hotel bookings, potentially other bookings as well. Here's how the address looks in Expensify.
Then as a point of comparison, here's how the address looks in Spotnana.
changed the title [-]Correctly escape quotes for travel/hotel addresses[/-][+][$250] Correctly escape quotes for travel/hotel addresses[/+]on Mar 4, 2025
changed the title [-][$150] Correctly escape quotes for travel/hotel addresses[/-][+][Due for payment 2025-03-27] [$150] Correctly escape quotes for travel/hotel addresses[/+]on Mar 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@fedirjh@jliexpensify@fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
No regression test is needed here, we have implemented an ui test for this case.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Mar 4, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Correctly escape quotes for travel/hotel addresses[/-][+][$250] Correctly escape quotes for travel/hotel addresses[/+]melvin-bot commentedon Mar 4, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021897065491290587971
melvin-bot commentedon Mar 4, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)fedirjh commentedon Mar 4, 2025
cc @blimpich The images that you shared seems to be broken.
44 remaining items
[-][$150] Correctly escape quotes for travel/hotel addresses[/-][+][Due for payment 2025-03-27] [$150] Correctly escape quotes for travel/hotel addresses[/+]melvin-bot commentedon Mar 20, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-27. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 20, 2025
@fedirjh @jliexpensify @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jliexpensify commentedon Mar 24, 2025
Bump @fedirjh for the checklist
fedirjh commentedon Mar 24, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [VIP-Travel] Trip room summary #41659 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
No regression test is needed here, we have implemented an ui test for this case.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
jliexpensify commentedon Mar 24, 2025
Payment Summary:
Upwork job
jliexpensify commentedon Mar 27, 2025
Paid and job closed!
garrettmknight commentedon Apr 22, 2025
$150 approved for @fedirjh