Skip to content

[Due for payment 2025-03-27] [$150] Correctly escape quotes for travel/hotel addresses #57801

Closed

Description

@blimpich

We're not currently escaping quotations for addresses on hotel bookings, potentially other bookings as well. Here's how the address looks in Expensify.

Image

Then as a point of comparison, here's how the address looks in Spotnana.

Image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021897065491290587971
  • Upwork Job ID: 1897065491290587971
  • Last Price Increase: 2025-03-13
  • Automatic offers:
    • gijoe0295 | Contributor | 106513739
Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. self-assigned this
    on Mar 4, 2025
  2. added theissue type on Mar 4, 2025
  3. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 4, 2025
  4. melvin-bot commented on Mar 4, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 4, 2025
  6. changed the title [-]Correctly escape quotes for travel/hotel addresses[/-] [+][$250] Correctly escape quotes for travel/hotel addresses[/+] on Mar 4, 2025
  7. melvin-bot commented on Mar 4, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 4, 2025
  9. melvin-bot commented on Mar 4, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  10. fedirjh commented on Mar 4, 2025

    @fedirjh
    Contributor

    cc @blimpich The images that you shared seems to be broken.

  11. 44 remaining items

  12. changed the title [-][$150] Correctly escape quotes for travel/hotel addresses[/-] [+][Due for payment 2025-03-27] [$150] Correctly escape quotes for travel/hotel addresses[/+] on Mar 20, 2025
  13. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-27. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    @fedirjh @jliexpensify @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. jliexpensify commented on Mar 24, 2025

    @jliexpensify
    Contributor

    Bump @fedirjh for the checklist

  17. fedirjh commented on Mar 24, 2025

    @fedirjh
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: [VIP-Travel] Trip room summary #41659 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    No regression test is needed here, we have implemented an ui test for this case.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  18. jliexpensify commented on Mar 24, 2025

    @jliexpensify
    Contributor

    Payment Summary:

    • C: @gijoe0295 $150 (to be paid via Upworks)
    • C+: @fedirjh $150 (to be paid via New.Dot requests)

    Upwork job

  19. jliexpensify commented on Mar 27, 2025

    @jliexpensify
    Contributor

    Paid and job closed!

  20. garrettmknight commented on Apr 22, 2025

    @garrettmknight
    Contributor

    $150 approved for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions