Skip to content

[Due for payment 2025-03-24] Help Panel - Tooltip is shown over Help RHP #57805

New issue
New issue
Closed
Closed
[Due for payment 2025-03-24] Help Panel - Tooltip is shown over Help RHP#57805
Assignees
mollfprstephanieelliottbrunovjk289Adam289
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Description

@mitarachim
mitarachim
opened on Mar 5, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.1.9-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #56490
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Other

Action Performed:

Precondition
HelpButton is shown.

To implement HelpButton, Open the JS console and run:
Onyx.set('nvp_sidePaneExpanded', null)
Onyx.set('nvp_sidePaneExpanded', {})

  1. Go to staging.new.expensify.com
  2. Login with a new account
  3. Go to reports
  4. Click on "create expenses, start chatting and more!" tooltip
  5. Dismiss FAB
  6. When "Customize you search here!" is shown open the Help Panel.

Expected Result:

Tooltips are not shown when RHP is opened

Actual Result:

Tooltip is shown over the RHP

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6761336_1741134309234.Screen_Recording_2025-03-05_at_2.50.26_at_night.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. mitarachim
    added
    BugSomething is broken. Auto assigns a BugZero manager.
    DailyKSv2
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 5, 2025
  2. melvin-bot
    assigned
    stephanieelliott
    on Mar 5, 2025

  3. melvin-bot commented on Mar 5, 2025

    @melvin-bot
    melvin-botBot
    on Mar 5, 2025 – with Melvin Bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Mar 5, 2025

    @melvin-bot
    melvin-botBot
    on Mar 5, 2025 – with Melvin Bot

    Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot
    assigned
    mollfpr
    on Mar 5, 2025

  6. melvin-bot commented on Mar 5, 2025

    @melvin-bot
    melvin-botBot
    on Mar 5, 2025 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Mar 5, 2025

  8. github-actions commented on Mar 5, 2025

    @github-actions
    github-actionsBot
    on Mar 5, 2025 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  9. mitarachim
    changed the title [-]Help Panel - Tooltip is shown over Help RHN[/-] [+]Help Panel - Tooltip is shown over Help RHP[/+] on Mar 5, 2025
  10. mollfpr
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 5, 2025

  11. 27 remaining items

  12. melvin-bot commented on Mar 17, 2025

    @melvin-bot
    melvin-botBot
    on Mar 17, 2025 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-24. 🎊

    For reference, here are some details about the assignees on this issue:

    • @brunovjk requires payment (Needs manual offer from BZ)
    • @289Adam289 does not require payment (Contractor)

  13. melvin-bot commented on Mar 17, 2025

    @melvin-bot
    melvin-botBot
    on Mar 17, 2025 – with Melvin Bot

    @brunovjk @stephanieelliott @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    WeeklyKSv2
    on Mar 24, 2025

  15. melvin-bot commented on Mar 24, 2025

    @melvin-bot
    melvin-botBot
    on Mar 24, 2025 – with Melvin Bot

    Payment Summary

    Upwork Job

    • ROLE: @brunovjk paid $(AMOUNT) via Upwork (LINK)
    • Contributor: @289Adam289 is from an agency-contributor and not due payment

    BugZero Checklist (@stephanieelliott)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct

  16. brunovjk commented on Mar 24, 2025

    @brunovjk
    brunovjk
    on Mar 24, 2025
    Contributor

    This issue is part of some regressions during the implementation of Help Panel. I think we can follow the payment on the original issues.

  17. stephanieelliott commented on Mar 25, 2025

    @stephanieelliott
    stephanieelliott
    on Mar 25, 2025
    Contributor

    @brunovjk sorry -- does that mean we should follow the payment dates that are on this issue? Or wait for #58732 to be ready for payment?

  18. melvin-bot
    removed
    Overdue
    on Mar 25, 2025

  19. brunovjk commented on Mar 25, 2025

    @brunovjk
    brunovjk
    on Mar 25, 2025
    Contributor

    @stephanieelliott Good question, I'll ask on Slack so we can discuss and clarify. We have a lot of issues/PRs about this implementation, the Help Panel.

  20. stephanieelliott commented on Mar 27, 2025

    @stephanieelliott
    stephanieelliott
    on Mar 27, 2025
    Contributor

    Sounds good -- LMK!

  21. brunovjk commented on Mar 27, 2025

    @brunovjk
    brunovjk
    on Mar 27, 2025
    Contributor

    I can't reproduce this anymore after implementing this PR. Tested on 27 Mar v9.1.20-2 Develop. We can close, payment and BZ checklist will be handled here. Thanks!

  22. stephanieelliott commented on Mar 29, 2025

    @stephanieelliott
    stephanieelliott
    on Mar 29, 2025
    Contributor

    Great, thanks @brunovjk!

  23. stephanieelliott
    closed this as completedon Mar 29, 2025
  24. github-project-automation
    moved this to Done in [#whatsnext] #converton Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions