Repository navigation
Help panel - Help panel opens behind RHP on edit photo and view attachment page #57806
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.9-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: User Settings
Action Performed:
Precondition:
- Run Onyx.set('nvp_sidePaneExpanded', {}) in console.
- Go to staging.new.expensify.com
- Go to Settings > Profile.
- Click on the avatar.
- Select a photo.
- On Edit photo page, click Help icon.
- Note that help panel opens behind the RHP.
- Upload the photo.
- Click on the avatar.
- Click View photo.
- Click help icon.
- Note that help panel does not have right padding and it opens behind the RHP.
Expected Result:
In Step 6, help panel will open next to the RHP.
In Step 11, help panel will have right padding and it will open next to the RHP.
Actual Result:
In Step 6, help panel opens behind the RHP.
In Step 11, help panel does not have right padding and it opens behind the RHP.
Step 11 also happens when viewing attachment.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Mar 5, 2025
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 5, 2025
Triggered auto assignment to @robertjchen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 5, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 5, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
8 remaining items
blazejkustra commentedon Mar 11, 2025
FYI I'm working on this issue and two other that are strictly connected. I should have updates tomorrow!
CortneyOfstad commentedon Mar 13, 2025
Thanks @blazejkustra! Any update?
blazejkustra commentedon Mar 13, 2025
Update: I'm working on this, I'm on a good track but still not a final solution:
userprofile.mov
blazejkustra commentedon Mar 18, 2025
Update: PR is ready for review.
melvin-bot commentedon Mar 20, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Mar 20, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
blazejkustra commentedon Mar 27, 2025
PR got merged, we can slowly wrap this issue up.
brunovjk commentedon Mar 27, 2025
I can't reproduce this anymore after implementing this PR. Tested on 27 Mar v9.1.20-2 Develop. We can close, payment and BZ checklist will be handled here. Thanks!
CortneyOfstad commentedon Mar 28, 2025
Sounds good — thanks @brunovjk!