Repository navigation
Hold - Hold page lead to detail page when hold expense #57835
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.1.9-2
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): gocemate+b20101@gmail.com
Issue reported by: Applause Internal Team
Device used: Lenovo 80ES / Windows 10 Pro
App Component: Other
Action Performed:
- User A submit 2 expenses to User B
- User B open detail page on one of the expense> Hold expense
Expected Result:
RHP modal should close
Actual Result:
Detail page opens when user hold expense
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6761611_1741163775903.Recording__5132.mp4
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
melvin-bot commentedon Mar 5, 2025
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 5, 2025
Triggered auto assignment to @grgia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 5, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 5, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Mar 5, 2025
Not repro on prod
Screen.Recording.2025-03-05.at.4.18.36.PM.mov
grgia commentedon Mar 5, 2025
Perhaps related to #57565
hungvu193 commentedon Mar 5, 2025
@FitseTLT Can you raise a PR to fix this please?
FitseTLT commentedon Mar 5, 2025
@hungvu193 @grgia @dangrous Are u sure the production behavior is better? I know I am suggesting a behavior change on the current main but there are a lot of things to do in details page beside hold. So now a user press hold button and will be navigated to the hold reason form and then whether they press go back or confirm on the hold reason don't u think the user should be navigated back to the original page(i.e. details page if they opened hold from their) That's more intuitive and its the reason I made the behavior of onBAckButtonPress and confirm hold reason consistent original. WDYT??
grgia commentedon Mar 5, 2025
@FitseTLT I think you're right, that's what the pin button does right?
grgia commentedon Mar 5, 2025
Gonna demote this one
FitseTLT commentedon Mar 5, 2025
Pin/Unpin remain on the details page. But unhold dismisses the details page. And the one that is similar to our case is title page and on confirm it takes u to the details page, which I think is right. Here is a vid:
2025-03-05.16-47-14.mp4
dangrous commentedon Mar 5, 2025
Yeah it makes sense to me to have everything return back to the details page... Do we need to create a separate issue (or repurpose this one) for changing the behavior of unholding as well?
@grgia should we bring this to Slack to confirm the ideal behavior?
joekaufmanexpensify commentedon Mar 5, 2025
Hmm, we are about to move
Holdout of the details page altogether in the Simplified Action Framework doc.I'd personally vote not to make any changes to the hold behavior given it's soon not going to be on the details page at all. cc @JmillsExpensify
joekaufmanexpensify commentedon Mar 5, 2025
Bumping to daily as this is no longer a blocker.
grgia commentedon Mar 7, 2025
Should we close this out then @joekaufmanexpensify
joekaufmanexpensify commentedon Mar 7, 2025
Yep, I think that is fine, given we are going to move hold soon. No need to change this further in the interim.