Skip to content

[Due for payment 2025-03-24] iOS&Android - Help panel - Keyboard does not dismiss when help panel is opened #57839

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.9-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+050302kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Chat Report View

Action Performed:

Precondition:

  • Help panel feature is enabled by switching language to Spanish and back to English.
  1. Launch ND or hybrid app.
  2. Open any chat.
  3. Tap on the composer to open keyboard.
  4. Tap help icon.

Expected Result:

Keyboard will dismiss.

Actual Result:

Keyboard does not dismiss.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6761693_1741170040743.ScreenRecording_03-05-2025_18-16-48_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @laurenreidexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 5, 2025
  2. melvin-bot commented on Mar 5, 2025

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Mar 5, 2025

    @melvin-bot

    Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Mar 5, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Mar 5, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mjasikowski commented on Mar 5, 2025

    @mjasikowski
    Contributor

    caused by #56490, but a minor UI bug, so not a blocker

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 5, 2025
  8. 20 remaining items

  9. melvin-bot commented on Mar 17, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Mar 17, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-24. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Mar 17, 2025

    @melvin-bot

    @mjasikowski @laurenreidexpensify @blazejkustra / @289Adam289 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. melvin-bot commented on Mar 24, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  13. laurenreidexpensify commented on Mar 24, 2025

    @laurenreidexpensify
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  14. laurenreidexpensify commented on Mar 24, 2025

    @laurenreidexpensify
    Contributor

    @blazejkustra can you complete checklist thanks

  15. blazejkustra commented on Mar 24, 2025

    @blazejkustra
    Contributor

    @laurenreidexpensify Hey! What checklist exactly? Does it matter that I'm from an agency? I've never done that before 😅

  16. blazejkustra commented on Mar 24, 2025

    @blazejkustra
    Contributor

    I think @brunovjk was reviewing this as a C+

  17. brunovjk commented on Mar 24, 2025

    @brunovjk
    Contributor

    @laurenreidexpensify This issue is part of some regressions during the implementation of Help Panel. I think we can follow the payment on the original issues.

  18. laurenreidexpensify commented on Mar 26, 2025

    @laurenreidexpensify
    Contributor

    Okay thanks @brunovjk

  19. brunovjk commented on Mar 27, 2025

    @brunovjk
    Contributor

    I can't reproduce this anymore after implementing this PR. Tested on 27 Mar v9.1.20-2 Develop. We can close, payment and BZ checklist will be handled here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions