Skip to content

[CRITICAL] Temporary login is seen as unvalidated login when signing in #57869

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.9-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): expensify-bugs

Action Performed:

  1. Login to an account on Staging.
  2. Switch to Expensify Classic.
  3. Sign out.
  4. Sign into a different account and land in NewDot.
  5. Go to Profile > Contact method.

Expected Result:

You shouldn't see a RBR or a temporary login shown as a unvalidated login.

Actual Result:

You see an expensify.cash temporary login shown as an unvalidated login in your account on the frontend.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Recording.1031.mp4

Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021897406227746943523
  • Upwork Job ID: 1897406227746943523
  • Last Price Increase: 2025-03-05
  • Automatic offers:
    • nkdengineer | Contributor | 106460534
Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 5, 2025
  2. melvin-bot commented on Mar 5, 2025

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Mar 5, 2025

    @melvin-bot

    Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Mar 5, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Mar 5, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 5, 2025
  7. pecanoro commented on Mar 5, 2025

    @pecanoro
    Contributor

    Happening on prod as well so not a deploy blocker

  8. 41 remaining items

  9. akinwale commented on Mar 13, 2025

    @akinwale
    Contributor

    @blimpich I believe compensation is still due here according to the process doc since a PR was already created and reviewed.

    cc @twisterdotcom

  10. blimpich commented on Mar 13, 2025

    @blimpich
    Contributor

    Apologies, wasn't aware of that part of the process. @twisterdotcom can you confirm that?

  11. pecanoro commented on Mar 13, 2025

    @pecanoro
    Contributor

    It was my fault. I tried to debug it and check if the back-end was returning the temporary logins, but I could not find where that was happening since the data from OpenApp was okay. Considering the PR was super small and it wasn't reviewed, the checklist wasn't completed, and the PR wasn't approved, what if we issue half of the bounty, $125?

  12. akinwale commented on Mar 13, 2025

    @akinwale
    Contributor

    It was my fault. I tried to debug it and check if the back-end was returning the temporary logins, but I could not find where that was happening since the data from OpenApp was okay. Considering the PR was super small and it wasn't reviewed, the checklist wasn't completed, and the PR wasn't approved, what if we issue half of the bounty, $125?

    In this case, the contributor would be eligible for full payment, and half payment for the C+ since a complete review wasn't done.

  13. changed the title [-][$250] Temporary login is seen as unvalidated login when signing in[/-] [+][CRITICAL] emporary login is seen as unvalidated login when signing in[/+] on Mar 13, 2025
  14. changed the title [-][CRITICAL] emporary login is seen as unvalidated login when signing in[/-] [+][CRITICAL] Temporary login is seen as unvalidated login when signing in[/+] on Mar 13, 2025
  15. twisterdotcom commented on Mar 14, 2025

    @twisterdotcom
    Contributor

    Alright yes, this is pretty clear:

    Image.

    $250 was the job we created, so this would be $250 for @nkdengineer and $125 for @akinwale.

  16. twisterdotcom commented on Mar 14, 2025

    @twisterdotcom
    Contributor

    Payment Summary:

  17. JmillsExpensify commented on Mar 17, 2025

    @JmillsExpensify
    Contributor

    $125 approved for @akinwale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions