You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-27] [$125] Refactor buildOptimisticMoneyRequestEntities to use a parameter object #57959
Thanks for your proposal @Themoonalsofall. Technically, they are not assigned to any yet and do not have many active assigned issues, so I am obliged to go with their proposal here. Please keep an eye on the other open issues; I am sure you will get them.
changed the title [-][$125] Refactor buildOptimisticMoneyRequestEntities to use a parameter object[/-][+][Due for payment 2025-03-27] [$125] Refactor buildOptimisticMoneyRequestEntities to use a parameter object[/+]on Mar 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@parasharrajat@strepanier03@parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 6, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021897773327035083754
melvin-bot commentedon Mar 6, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)melvin-bot commentedon Mar 6, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Shahidullah-Muffakir commentedon Mar 6, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Refactor
buildOptimisticMoneyRequestEntitiesto use parameter objec.What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
Update the
buildOptimisticMoneyRequestEntitiesto accept parameter object, and pass parameter object in all the places the function is called.App/src/libs/ReportUtils.ts
Line 6801 in 4fabee6
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
No tests needed, because It's just a refactor.
What alternative solutions did you explore? (Optional)
parasharrajat commentedon Mar 7, 2025
Thanks for your proposal @Themoonalsofall. Technically, they are not assigned to any yet and do not have many active assigned issues, so I am obliged to go with their proposal here. Please keep an eye on the other open issues; I am sure you will get them.
15 remaining items
[-][$125] Refactor buildOptimisticMoneyRequestEntities to use a parameter object[/-][+][Due for payment 2025-03-27] [$125] Refactor buildOptimisticMoneyRequestEntities to use a parameter object[/+]melvin-bot commentedon Mar 20, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-27. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 20, 2025
@parasharrajat @strepanier03 @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 27, 2025
Payment Summary
Upwork Job
BugZero Checklist (@strepanier03)
parasharrajat commentedon Mar 27, 2025
No Checklist needed. It is a refactor.
strepanier03 commentedon Mar 27, 2025
Payment Summary
strepanier03 commentedon Mar 27, 2025
I'll pay out the Upwork contract when I see it's accepted and then close this. Thank you both!
strepanier03 commentedon Mar 28, 2025
@Shahidullah-Muffakir - I've paid and closed your contract.
Since all that's left is the manual request I'm going to close this out since the payment summary is above.
I hope you both have a great weekend.
parasharrajat commentedon May 23, 2025
Payment requested as per #57959 (comment)
JmillsExpensify commentedon May 29, 2025
$125 approved for @parasharrajat