Skip to content

[Due for payment 2025-03-27] [$125] Refactor buildOptimisticMoneyRequestEntities to use a parameter object #57959

Closed

Description

@neil-marcellini

As part of the tracking issue, and as advised in its description, refactor buildOptimisticMoneyRequestEntities to use a parameter object.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021897773327035083754
  • Upwork Job ID: 1897773327035083754
  • Last Price Increase: 2025-03-06
Issue OwnerCurrent Issue Owner: @strepanier03

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 6, 2025
  2. melvin-bot commented on Mar 6, 2025

    @melvin-bot
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 6, 2025
  4. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  5. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. Shahidullah-Muffakir commented on Mar 6, 2025

    @Shahidullah-Muffakir
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Refactor buildOptimisticMoneyRequestEntities to use parameter objec.

    What is the root cause of that problem?

    Improvement

    What changes do you think we should make in order to solve the problem?

    Update the buildOptimisticMoneyRequestEntities to accept parameter object, and pass parameter object in all the places the function is called.

    function buildOptimisticMoneyRequestEntities(

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    No tests needed, because It's just a refactor.

    What alternative solutions did you explore? (Optional)

  7. parasharrajat commented on Mar 7, 2025

    @parasharrajat
    Member

    Thanks for your proposal @Themoonalsofall. Technically, they are not assigned to any yet and do not have many active assigned issues, so I am obliged to go with their proposal here. Please keep an eye on the other open issues; I am sure you will get them.

  8. 15 remaining items

  9. changed the title [-][$125] Refactor buildOptimisticMoneyRequestEntities to use a parameter object[/-] [+][Due for payment 2025-03-27] [$125] Refactor buildOptimisticMoneyRequestEntities to use a parameter object[/+] on Mar 20, 2025
  10. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-27. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    @parasharrajat @strepanier03 @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. melvin-bot commented on Mar 27, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@strepanier03)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1897773327035083754/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. parasharrajat commented on Mar 27, 2025

    @parasharrajat
    Member

    No Checklist needed. It is a refactor.

  15. strepanier03 commented on Mar 27, 2025

    @strepanier03
    Contributor

    Payment Summary

  16. strepanier03 commented on Mar 27, 2025

    @strepanier03
    Contributor

    I'll pay out the Upwork contract when I see it's accepted and then close this. Thank you both!

  17. strepanier03 commented on Mar 28, 2025

    @strepanier03
    Contributor

    @Shahidullah-Muffakir - I've paid and closed your contract.

    Since all that's left is the manual request I'm going to close this out since the payment summary is above.

    I hope you both have a great weekend.

  18. parasharrajat commented on May 23, 2025

    @parasharrajat
    Member

    Payment requested as per #57959 (comment)

  19. JmillsExpensify commented on May 29, 2025

    @JmillsExpensify
    Contributor

    $125 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions