[Due for payment 2025-03-27] Add approvals switch is locked&disabled after reenabling Workflows when Smart limit is selected

@MitchExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

Workspace has Expensify Card feature.
User has assigned a virtual card to themselves (Limit type should not be Smart limit).
Add approvals feature is enabled.

Go to staging.new.expensify.com
Go to workspace settings > Expensify Card.
Click on any card.
Click Limit type.
Select Smart limit and save it.
Go to Workflows.
Note that Add approvals switch is enabled and locked.
Go to More features.
Disable and reenable Workflows.
Go to Workflows.

Expected Result:

Add approvals switch should not be locked.

Actual Result:

Add approvals switch is disabled and locked. User will have to change the Limit type in order to unlock the switch.

In this case, the message asks to change the limit type before "disabling" approvals, when it is already disabled and locked.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6763738_1741336218611.20250307_162316.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @MitchExpensify

@MitchExpensify

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@cristipaval

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Not repro on production

screen-20250307-111250.mp4

🚨 Edited by proposal-police: This proposal was edited at 2025-03-07 10:16:52 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add approvals switch is disabled and locked. User will have to change the Limit type in order to unlock the switch.

What is the root cause of that problem?

We don't have any logic to disable workflow button here

App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

Lines 175 to 187 in d414689

    
           { 
        
               icon: Illustrations.Workflows, 
        
               titleTranslationKey: 'workspace.moreFeatures.workflows.title', 
        
               subtitleTranslationKey: 'workspace.moreFeatures.workflows.subtitle', 
        
               isActive: policy?.areWorkflowsEnabled ?? false, 
        
               pendingAction: policy?.pendingFields?.areWorkflowsEnabled, 
        
               action: (isEnabled: boolean) => { 
        
                   if (!policyID) { 
        
                       return; 
        
                   } 
        
                   enablePolicyWorkflows(policyID, isEnabled); 
        
               }, 
        
           },

What changes do you think we should make in order to solve the problem?

We should disbale workflow button while we have isSmartLimitEnabled

    const [cardList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}`);
    const workspaceCards = getAllCardsForWorkspace(workspaceAccountID, cardList);
    const isSmartLimitEnabled = isSmartLimitEnabledUtil(workspaceCards);

    ... 

        {
            icon: Illustrations.Workflows,
            disabled: isSmartLimitEnabled,
        },

And we can add disabledAction to show warning modal like we did with others, the modal content will be confirmed later.

App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

Lines 98 to 103 in d414689

    
           const onDisabledOrganizeSwitchPress = useCallback(() => { 
        
               if (!hasAccountingConnection) { 
        
                   return; 
        
               } 
        
               setIsOrganizeWarningModalOpen(true); 
        
           }, [hasAccountingConnection]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None UI bug

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@cristipaval

@cristipaval I can quickly raise a PR if needed.

@daledah

@daledah can you apply to this job as a next step please? https://www.upwork.com/jobs/~021907069798744476418

When I click the job link, it shows:

@MitchExpensify can you send an offer directly to me https://www.upwork.com/freelancers/~0138d999529f34d33f

Thanks

@daledah

New offer sent here @daledah https://www.upwork.com/nx/wm/offer/106810957

@MitchExpensify

@MitchExpensify Accepted thx!

Paid, thank you!

@MitchExpensify

@MitchExpensify i have not been paid in this issue as this comment. Could you please check again?

@MitchExpensify

@MitchExpensify I also did not receive payment.

@nkdengineer

Oh apologies, I must have got my wires crossed!

Offer sent @nkdengineer: https://www.upwork.com/nx/wm/offer/107183174

What is your Upwork profile @dominictb ?

@MitchExpensify

@MitchExpensify Accepted the offer, thanks for your help!

@dominictb

What is your Upwork profile @dominictb ?

@MitchExpensify It's https://www.upwork.com/freelancers/~01f70bed1934fd35d5

@dominictb

Thanks, offer her @dominictb - https://www.upwork.com/nx/wm/offer/107263237

@MitchExpensify

@MitchExpensify Accepted, thanks 🙏

Paid, thanks!

Navigation Menu

Repository navigation

[Due for payment 2025-03-27] Add approvals switch is locked&disabled after reenabling Workflows when Smart limit is selected #57998

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

70 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{
	icon: Illustrations.Workflows,
	titleTranslationKey: 'workspace.moreFeatures.workflows.title',
	subtitleTranslationKey: 'workspace.moreFeatures.workflows.subtitle',
	isActive: policy?.areWorkflowsEnabled ?? false,
	pendingAction: policy?.pendingFields?.areWorkflowsEnabled,
	action: (isEnabled: boolean) => {
	if (!policyID) {
	return;
	}
	enablePolicyWorkflows(policyID, isEnabled);
	},
	},

	const onDisabledOrganizeSwitchPress = useCallback(() => {
	if (!hasAccountingConnection) {
	return;
	}
	setIsOrganizeWarningModalOpen(true);
	}, [hasAccountingConnection]);

[Due for payment 2025-03-27] Add approvals switch is locked&disabled after reenabling Workflows when Smart limit is selected #57998

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 7, 2025

melvin-bot commented on Mar 7, 2025

melvin-bot commented on Mar 7, 2025

github-actions commented on Mar 7, 2025

IuliiaHerets commented on Mar 7, 2025

daledah commented on Mar 7, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

daledah commented on Mar 7, 2025

70 remaining items

daledah commented on Apr 1, 2025

MitchExpensify commented on Apr 6, 2025

daledah commented on Apr 7, 2025

MitchExpensify commented on Apr 8, 2025

nkdengineer commented on Apr 24, 2025

dominictb commented on Apr 24, 2025

MitchExpensify commented on May 5, 2025

nkdengineer commented on May 5, 2025

dominictb commented on May 5, 2025

MitchExpensify commented on May 11, 2025

dominictb commented on May 13, 2025

MitchExpensify commented on May 13, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions