Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5702032
Email or phone of affected tester (no customers): applausetester+030725dr053@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: MacOS 14.7.4 / Safari, Chrome, Desktop. iPhone 15 Pro / 18.3.1. Google Pixel 5 / Android 14
App Component: User Settings
Action Performed:
- Login to NewDot with a new Expensifail account
- Go to Settings > Wallet
- Click Add bank account
- Verify your country is selected by default (eg. United States)
- In the search bar, enter the first letter of another country. For example - N, A, D, E etc.
- Select another country (eq. Cambodia) and try searching by letters again.
Expected Result:
Country search scrolls to the correct country starting with these letters.
Actual Result:
For some first letters the country search scrolls to countries that start with a different letter. Incorrect letters will vary depending on the country already selected by default.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6763951_1741350688270.iOS-Wallet-Search-Incorrect-Scroll.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021898763466530762704
- Upwork Job ID: 1898763466530762704
- Last Price Increase: 2025-03-09
- Automatic offers:
- FitseTLT | Contributor | 106479043
Activity
melvin-bot commentedon Mar 7, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.FitseTLT commentedon Mar 7, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-03-07 16:15:55 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Wallet - Country search scrolls to incorrect line for some letters
What is the root cause of that problem?
When the search key contains letters from the currently selected item, the selected item will still be in the list but its index might change (because the relative index will change as the number of items above it change) then setFocusedIndex will be called with the current new index of the selected item
App/src/components/SelectionList/BaseSelectionList.tsx
Lines 363 to 374 in 1247366
What changes do you think we should make in order to solve the problem?
This feature is implemented in #54457 but caused this issue. So we should disable it if there is a search string like:
App/src/components/SelectionList/BaseSelectionList.tsx
Lines 369 to 370 in 1247366
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
The test created for the original pr suffices.
What alternative solutions did you explore? (Optional)
nyomanjyotisa commentedon Mar 7, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Wallet - Country search scrolls to incorrect line for some letters
What is the root cause of that problem?
We update the
focusedIndexonce theflattenedSections.allOptionsis updated. This is necessary to update thefocusedIndexwhen there is a changes on Backend especially for Priority mode selection in this issue #54457But, we also update the
focusedIndexwhen the new data offlattenedSections.allOptionscoming from search resultWhat changes do you think we should make in order to solve the problem?
Return early if the new data of
flattenedSections.allOptionscoming from search resultApp/src/components/SelectionList/BaseSelectionList.tsx
Lines 368 to 374 in 2316207
Additionally we can set focus to the default value if the
textInputValueempty if neededWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Or we can do like this instead of using existing
prevTextInputValuevalue[-]Wallet - Country search scrolls to incorrect line for some letters[/-][+][$125] Wallet - Country search scrolls to incorrect line for some letters[/+]melvin-bot commentedon Mar 9, 2025
melvin-bot commentedon Mar 9, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021898763466530762704
17 remaining items
melvin-bot commentedon Mar 28, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mallenexpensify commentedon Mar 28, 2025
@jliexpensify I'm going to be OOO and offline for two weeks so I'm reassigning, will pick back up upon my return, thx
FitseTLT commentedon Mar 28, 2025
Payment is due today
ahmedGaber93 commentedon Mar 29, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/54457/files#r2019991575
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
ahmedGaber93 commentedon Mar 29, 2025
@jliexpensify It looks the automation was failed here, this issue was due for payment yesterday.
jliexpensify commentedon Mar 30, 2025
Payment Summary
Upwork job
jliexpensify commentedon Mar 30, 2025
Paid and job closed.
JmillsExpensify commentedon Apr 25, 2025
$125 approved for @ahmedGaber93