Repository navigation
[C+ Checklist Needs Completion] [$125] Magic code modal isn't dismissed and the page freezes after updating delegate role #58045
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.10-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @getusha
Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
- Add a delegate with limited access level
- Press on the member and change access level to full
- Enter the magic code sent to your email
Expected Result:
The modal will be dismissed
Actual Result:
Modal is not dismissed, and there is another same modal below it
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Screen.Recording.2025-03-07.at.3.46.21.in.the.afternoon.mov
Recording.1036.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021899053673683496912
- Upwork Job ID: 1899053673683496912
- Last Price Increase: 2025-03-10
- Automatic offers:
- nyomanjyotisa | Contributor | 106518154
Issue Owner
Current Issue Owner: @s77rtMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Mar 8, 2025
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]https://github.com/Expensify/App/issues/new/choose[/-][+]Magic code modal isn't dismissed and the page freezes after updating delegate role[/+]nyomanjyotisa commentedon Mar 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Magic code modal isn't dismissed and the page freezes after updating delegate role
What is the root cause of that problem?
We use
Navigation.navigatehere and it makes the modal not dismissedApp/src/pages/settings/Security/AddDelegate/UpdateDelegateRole/UpdateDelegateMagicCodeModal.tsx
Lines 31 to 32 in 9702e89
What changes do you think we should make in order to solve the problem?
Use
Navigation.goBack(ROUTES.SETTINGS_SECURITY);instead like the one hereWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
[-]Magic code modal isn't dismissed and the page freezes after updating delegate role[/-][+][$125] Magic code modal isn't dismissed and the page freezes after updating delegate role[/+]melvin-bot commentedon Mar 10, 2025
melvin-bot commentedon Mar 10, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021899053673683496912
melvin-bot commentedon Mar 10, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)16 remaining items
greg-schroeder commentedon Mar 19, 2025
Deployed to prod yesterday
[-][$125] Magic code modal isn't dismissed and the page freezes after updating delegate role[/-][+][Due for payment 2025-03-25] [$125] Magic code modal isn't dismissed and the page freezes after updating delegate role[/+]greg-schroeder commentedon Mar 27, 2025
Payment summary:
Contributor: @nyomanjyotisa - $125 - Upwork
C+: @s77rt - $125 - NewDot
greg-schroeder commentedon Mar 27, 2025
Could you take care of the C+ checklist @s77rt?
[-][Due for payment 2025-03-25] [$125] Magic code modal isn't dismissed and the page freezes after updating delegate role[/-][+][C+ Checklist Needs Completion] [$125] Magic code modal isn't dismissed and the page freezes after updating delegate role[/+]s77rt commentedon Mar 27, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Update delegate flow to use modal #56231 is the PR with the offending code but the bug is likely caused by a navigation refactor or upgrade
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, this is a pretty minor issue
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
s77rt commentedon Mar 27, 2025
@greg-schroeder ^
JmillsExpensify commentedon Mar 29, 2025
$125 approved for @s77rt