Repository navigation
Closed
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewHas a PR in review
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search
Action Performed:
- Go to staging.new.expensify.com
- Log in with a new account.
- Create a new workspace.
- Submit an expense to the workspace chat.
- Go to Reports.
- Click Filters button.
- Apply any filter, and click Save search.
- Click Expenses.
- Click on the expense submitted in Step 4.
- Close the RHP.
Expected Result:
Only one rename tooltip will be displayed.
Actual Result:
Two rename tooltips are displayed.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6766842_1741654176634.20250311_084642.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021899519705512085595
- Upwork Job ID: 1899519705512085595
- Last Price Increase: 2025-03-11
- Automatic offers:
- nkdengineer | Contributor | 106497756
Issue Owner
Current Issue Owner: @c3024Metadata
Metadata
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewHas a PR in review
Activity
melvin-bot commentedon Mar 11, 2025
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Mar 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Two rename tooltips are displayed.
What is the root cause of that problem?
When we navigate to another search page, the
shouldRenderTooltipof the three-dot on the previous search page is stilltruebut it's hidden based on this logic.App/src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx
Lines 106 to 108 in ef00a61
When we open the RHP,
shouldRenderTooltipof both three-dot changes tofalsebecause this tooltip is hidden now. After the RHP is closed,shouldRenderTooltipchanges totrueand the tooltip is rendered again for both of them. And because the element of the previous search page isn't found in the current search page, a tooltip is displayed at the top.What changes do you think we should make in order to solve the problem?
Update the
shouldShowcondition for the rename tooltip to only show if the page is focusedApp/src/pages/Search/SearchTypeMenu.tsx
Line 51 in ef00a61
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
This is UI bug, no need to test.
What alternative solutions did you explore? (Optional)
We can implement a solution in
BaseEducationalTooltipby creating a new variable that stores the focus state, when the page is blurred, set this tofalse. Add another listener withfocusevent and set this totruewhen the page is focused. Then we will only show the tooltip if this variable istrue.App/src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx
Lines 106 to 108 in ef00a61
Result
Screen.Recording.2025-03-11.at.11.42.14.mov
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
zanyrenney commentedon Mar 11, 2025
I can't reproduce this exact flow, but I have seen similar behaviour in the past in my own LHN. Looking into this to try and reproduce.
melvin-bot commentedon Mar 11, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021899519705512085595
[-]Web - Tooltip - Two rename tooltips are displayed[/-][+][$250] Web - Tooltip - Two rename tooltips are displayed[/+]zanyrenney commentedon Mar 11, 2025
Adding the external label.
melvin-bot commentedon Mar 11, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (
External)c3024 commentedon Mar 12, 2025
Thanks for the proposal.
I think checking the focus state to determine whether the tooltip should be displayed, as suggested in the main solution, seems better to me than the alternative approach of tracking the parent page focus state in
BaseEducationalTooltip. The focus check is also used on other pages to determine tooltip visibility.The fix suggested in the main solution of @nkdengineer’s proposal LGTM!
🎀 👀 🎀 C+ reviewed!
2 remaining items
melvin-bot commentedon Mar 12, 2025
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
Add educational tooltips for search filter and update bottom navigati…
c3024 commentedon Apr 4, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/54064/files#r2028310562
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No discussion was started because this bug could not have been identified earlier.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
c3024 commentedon Apr 4, 2025
@zanyrenney
Automation failed here. PR deployed to production two weeks ago. Can you please post the payment summary here? Thanks!
c3024 commentedon Apr 21, 2025
@zanyrenney , gentle bump here!
zanyrenney commentedon Apr 23, 2025
Thanks! Sorry for missing this @c3024
zanyrenney commentedon Apr 23, 2025
Payment summary
$250 to @nkdengineer paid via Upwork.
$250 to @c3024 owed with ND. Please request.
JmillsExpensify commentedon Apr 25, 2025
$250 approved for @c3024