Skip to content

[Due for payment 2025-04-17] [$250] Approvers Flow - No Add Bank Account button In report from employee without added BA #58155

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5723719
Email or phone of affected tester (no customers): fischer9966+031025aemp@gmail.com, fischer9966+031025aadm@gmail.com
Issue reported by: Applause Internal Team
Device used: MacOS 14.7.4 - Safari, Chrome, Desktop. iPhone 15 Pro / 18.2.1. Google Pixel 5 / Android 14
App Component: Chat Report View

Action Performed:

Pre-condition:

  1. Create ADMIN account with Gmail
  2. Create Collect workspace, set Workflows to enabled
  3. Enable Approvals in Workflows and set ADMIN account as Approver
  4. Enable Workflows > Delay submissions and set it to Manually
  5. Invite EMPLOYEE to workspace
  6. Add bank account to ADMIN account in OD

Steps:

  1. Login as EMPLOYEE in ND
  2. Create report and submit it to ADMIN
  3. Login to ND as ADMIN
  4. Approve report created in step 2
  5. Pay it with Expensify

Expected Result:

ADMIN - Payment is on hold until EMPLOYEE adds a bank account.
EMPLOYEE - There is system message with a button "Add bank account" in submitted report

Actual Result:

EMPLOYEE - There is system message WITHOUT a button "Add bank account" in submitted report

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6766882_1741660277032.Web-Approvers-No-Add-BA-button-for-Employee.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @adelekennedy
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021899664898937387365
  • Upwork Job ID: 1899664898937387365
  • Last Price Increase: 2025-03-12
  • Automatic offers:
    • nkdengineer | Contributor | 106587202

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 11, 2025
  2. melvin-bot commented on Mar 11, 2025

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Mar 11, 2025

    @melvin-bot

    Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Mar 11, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Mar 11, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. 52 remaining items

  7. adelekennedy commented on Apr 18, 2025

    @adelekennedy
    Contributor

    Payment Summary:

  8. adelekennedy commented on Apr 18, 2025

    @adelekennedy
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  9. adelekennedy commented on Apr 18, 2025

    @adelekennedy
    Contributor

    Do we need a regression test here @mananjadhav @hungvu193?

  10. mountiny commented on Apr 19, 2025

    @mountiny
    Contributor

    If there is none, we should cc @jponikarchuk @mananjadhav could you confirm if we already have one test for this or if we need to add a new one?

  11. mananjadhav commented on Apr 19, 2025

    @mananjadhav
    Collaborator

    Well I don't think we need a separate test for this. It was anyway caught with an existing regression test.

  12. adelekennedy commented on Apr 21, 2025

    @adelekennedy
    Contributor

    perfect - then closing this one as the two outstanding payments are through NewDot

  13. garrettmknight commented on Apr 22, 2025

    @garrettmknight
    Contributor

    $250 approved for @mananjadhav

  14. garrettmknight commented on Apr 22, 2025

    @garrettmknight
    Contributor

    $250 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions