Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5723719
Email or phone of affected tester (no customers): fischer9966+031025aemp@gmail.com, fischer9966+031025aadm@gmail.com
Issue reported by: Applause Internal Team
Device used: MacOS 14.7.4 - Safari, Chrome, Desktop. iPhone 15 Pro / 18.2.1. Google Pixel 5 / Android 14
App Component: Chat Report View
Action Performed:
Pre-condition:
- Create ADMIN account with Gmail
- Create Collect workspace, set Workflows to enabled
- Enable Approvals in Workflows and set ADMIN account as Approver
- Enable Workflows > Delay submissions and set it to Manually
- Invite EMPLOYEE to workspace
- Add bank account to ADMIN account in OD
Steps:
- Login as EMPLOYEE in ND
- Create report and submit it to ADMIN
- Login to ND as ADMIN
- Approve report created in step 2
- Pay it with Expensify
Expected Result:
ADMIN - Payment is on hold until EMPLOYEE adds a bank account.
EMPLOYEE - There is system message with a button "Add bank account" in submitted report
Actual Result:
EMPLOYEE - There is system message WITHOUT a button "Add bank account" in submitted report
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6766882_1741660277032.Web-Approvers-No-Add-BA-button-for-Employee.mp4
Issue Owner
Current Issue Owner: @adelekennedyUpwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021899664898937387365
- Upwork Job ID: 1899664898937387365
- Last Price Increase: 2025-03-12
- Automatic offers:
- nkdengineer | Contributor | 106587202
Activity
melvin-bot commentedon Mar 11, 2025
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 11, 2025
Triggered auto assignment to @robertjchen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 11, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 11, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
52 remaining items
adelekennedy commentedon Apr 18, 2025
Payment Summary:
adelekennedy commentedon Apr 18, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
adelekennedy commentedon Apr 18, 2025
Do we need a regression test here @mananjadhav @hungvu193?
mountiny commentedon Apr 19, 2025
If there is none, we should cc @jponikarchuk @mananjadhav could you confirm if we already have one test for this or if we need to add a new one?
mananjadhav commentedon Apr 19, 2025
Well I don't think we need a separate test for this. It was anyway caught with an existing regression test.
adelekennedy commentedon Apr 21, 2025
perfect - then closing this one as the two outstanding payments are through NewDot
garrettmknight commentedon Apr 22, 2025
$250 approved for @mananjadhav
garrettmknight commentedon Apr 22, 2025
$250 approved for @hungvu193