You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-02] [$250] mWeb - Reports - User has to use device´s back button to access the results of a search. #58162
changed the title [-]mWeb - Reports - User has to use device´s back button to access the results of a search.[/-][+][$250] mWeb - Reports - User has to use device´s back button to access the results of a search.[/+]on Mar 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mananjadhav@abekkala@mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Mar 11, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Mar 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
After entering a search, we need to go back to see the filtered search results.
What is the root cause of that problem?
When we submit the search input,
submitSearchwhich navigates to search page is called twice.App/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx
Lines 158 to 173 in aef2182
First when the text input
onSubmitis triggered, and the 2nd one is when the focused item on the list is pressed (by ENTER key).App/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx
Lines 197 to 199 in aef2182
App/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx
Lines 254 to 256 in aef2182
The 2nd call has an empty query because we already clear it in
submitSearch.What changes do you think we should make in order to solve the problem?
For non-native platforms, we will ignore the
onSubmitcallback, so it will only rely on the focused item press.App/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx
Lines 254 to 256 in aef2182
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
melvin-bot commentedon Mar 14, 2025
@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]mWeb - Reports - User has to use device´s back button to access the results of a search.[/-][+][$250] mWeb - Reports - User has to use device´s back button to access the results of a search.[/+]melvin-bot commentedon Mar 14, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021900530783250150549
melvin-bot commentedon Mar 14, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)melvin-bot commentedon Mar 18, 2025
@mananjadhav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
16 remaining items
melvin-bot commentedon Mar 26, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 26, 2025
@mananjadhav @abekkala @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
abekkala commentedon Mar 26, 2025
PAYMENT SUMMARY FOR APRIL 02
Please complete checklist
abekkala commentedon Apr 1, 2025
@mananjadhav can you please complete the checklist by tomorrow?
mananjadhav commentedon Apr 1, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: fix navigate to detail page on enter for highlighted item #54807 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/487118
Regression Test Proposal
Test:
Do we agree 👍 or 👎
@abekkala I think the test should exist already for the same, but if it doesn't then here's the proposal to add one ^.
melvin-bot commentedon Apr 2, 2025
Payment Summary
Upwork Job
BugZero Checklist (@abekkala)
abekkala commentedon Apr 2, 2025
PAYMENT SUMMARY FOR APRIL 02
THANK YOU! 🎉
bernhardoj commentedon Apr 3, 2025
Requested in ND.
JmillsExpensify commentedon Apr 9, 2025
$250 approved for @bernhardoj
garrettmknight commentedon Apr 10, 2025
$250 approved for @mananjadhav