You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PAY 26th MARCH][$250] Accounting - Export page content is not wrapped correctly #58342
Version Number: 9.1.12-5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+ps309@applause.expensifail.com Issue reported by: Applause Internal Team Device used: iPhone 15 Pro Max / iOS 18.3 App Component: Money Requests
changed the title [-]Accounting - Export page content is not wrapped correctly[/-][+][$250] Accounting - Export page content is not wrapped correctly[/+]on Mar 13, 2025
changed the title [-][$250] Accounting - Export page content is not wrapped correctly[/-][+][PAY 26th MARCH][$250] Accounting - Export page content is not wrapped correctly[/+]on Mar 20, 2025
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, edge case
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Mar 13, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.linhvovan29546 commentedon Mar 13, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-03-13 05:53:00 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Accounting - Export page content is not wrapped correctly
What is the root cause of that problem?
The
ConfirmationPagedoes not extend to the full space, which caused the issue here.What changes do you think we should make in order to solve the problem?
We should add containerStyle={styles.flex1} to ConfirmationPage here
App/src/pages/home/report/ReportDetailsExportPage.tsx
Line 89 in 2496dfa
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A, small UI bug
What alternative solutions did you explore? (Optional)
We can wrap
ConfirmationPageinsideScrollViewwithflex.grow1and addcontainerStyle={styles.h100}toConfirmationPage[-]Accounting - Export page content is not wrapped correctly[/-][+][$250] Accounting - Export page content is not wrapped correctly[/+]melvin-bot commentedon Mar 13, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021900115916963772773
melvin-bot commentedon Mar 13, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)jliexpensify commentedon Mar 13, 2025
Guessing this is an #expense one, feel free to correct me!
s77rt commentedon Mar 13, 2025
@linhvovan29546 Thanks for the proposal. RCA and solution looks good to me.
🎀 👀 🎀 C+ reviewed
Link to proposal
6 remaining items
linhvovan29546 commentedon Mar 14, 2025
PR is ready for review!
cc @s77rt
linhvovan29546 commentedon Mar 20, 2025
The PR was deployed to production two days ago. It looks like Mevin-bot failed.
[-][$250] Accounting - Export page content is not wrapped correctly[/-][+][PAY 26th MARCH][$250] Accounting - Export page content is not wrapped correctly[/+]jliexpensify commentedon Mar 20, 2025
Payment Summary
Upwork job
jliexpensify commentedon Mar 20, 2025
@s77rt - bumping for checklist
s77rt commentedon Mar 21, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: fix: mWeb/Safari - Subscription - "Downgrade workspace" button is hidden behind iOS controls. #56781 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, edge case
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
jliexpensify commentedon Mar 23, 2025
Is any Regression Test needed @s77rt ?
s77rt commentedon Mar 23, 2025
@jliexpensify No, I feel this is a an edge case and does not require a regression test
jliexpensify commentedon Mar 23, 2025
Great, thanks!
Re-linking the payment summary.
jliexpensify commentedon Mar 27, 2025
Paid and job closed.
JmillsExpensify commentedon Mar 29, 2025
$250 approved for @s77rt