Skip to content

[PAY 26th MARCH][$250] Accounting - Export page content is not wrapped correctly #58342

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.12-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Money Requests

Action Performed:

Precondition:

  • Workspace is connected to QBO.
  1. Launch ND or hybrid app.
  2. Go to workspace chat.
  3. Submit an expense.
  4. Go to expense report.
  5. Tap on the report header > Export.

Expected Result:

Export page content will be wrapped correctly.

Actual Result:

Export page content is not wrapped correctly.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6769435_1741841817543.ScreenRecording_03-13-2025_12-53-55_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021900115916963772773
  • Upwork Job ID: 1900115916963772773
  • Last Price Increase: 2025-03-13
  • Automatic offers:
    • linhvovan29546 | Contributor | 106522723
Issue OwnerCurrent Issue Owner: @s77rt

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 13, 2025
  2. melvin-bot commented on Mar 13, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. linhvovan29546 commented on Mar 13, 2025

    @linhvovan29546
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-03-13 05:53:00 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Accounting - Export page content is not wrapped correctly

    What is the root cause of that problem?

    The ConfirmationPage does not extend to the full space, which caused the issue here.

    What changes do you think we should make in order to solve the problem?

    We should add containerStyle={styles.flex1} to ConfirmationPage here

                    <ConfirmationPage
                        containerStyle={styles.flex1}
                        ...
                    />

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A, small UI bug

    What alternative solutions did you explore? (Optional)

    We can wrap ConfirmationPage inside ScrollView with flex.grow1 and add containerStyle={styles.h100} to ConfirmationPage

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 13, 2025
  5. changed the title [-]Accounting - Export page content is not wrapped correctly[/-] [+][$250] Accounting - Export page content is not wrapped correctly[/+] on Mar 13, 2025
  6. melvin-bot commented on Mar 13, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 13, 2025
  8. melvin-bot commented on Mar 13, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  9. jliexpensify commented on Mar 13, 2025

    @jliexpensify
    Contributor

    Guessing this is an #expense one, feel free to correct me!

  10. s77rt commented on Mar 13, 2025

    @s77rt
    Member

    @linhvovan29546 Thanks for the proposal. RCA and solution looks good to me.

    🎀 👀 🎀 C+ reviewed
    Link to proposal

  11. 6 remaining items

  12. linhvovan29546 commented on Mar 14, 2025

    @linhvovan29546
    Contributor

    PR is ready for review!
    cc @s77rt

  13. moved this to Bugs and Follow Up Issues in #expensify-bugson Mar 18, 2025
  14. linhvovan29546 commented on Mar 20, 2025

    @linhvovan29546
    Contributor

    The PR was deployed to production two days ago. It looks like Mevin-bot failed.

  15. changed the title [-][$250] Accounting - Export page content is not wrapped correctly[/-] [+][PAY 26th MARCH][$250] Accounting - Export page content is not wrapped correctly[/+] on Mar 20, 2025
  16. jliexpensify commented on Mar 20, 2025

    @jliexpensify
    Contributor

    Payment Summary

    Upwork job

  17. jliexpensify commented on Mar 20, 2025

    @jliexpensify
    Contributor

    @s77rt - bumping for checklist

  18. s77rt commented on Mar 21, 2025

    @s77rt
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: fix: mWeb/Safari - Subscription - "Downgrade workspace" button is hidden behind iOS controls. #56781 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: n/a

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      Bug requires regression test: No, edge case

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  19. jliexpensify commented on Mar 23, 2025

    @jliexpensify
    Contributor

    Is any Regression Test needed @s77rt ?

  20. s77rt commented on Mar 23, 2025

    @s77rt
    Member

    @jliexpensify No, I feel this is a an edge case and does not require a regression test

  21. jliexpensify commented on Mar 23, 2025

    @jliexpensify
    Contributor
  22. jliexpensify commented on Mar 27, 2025

    @jliexpensify
    Contributor

    Paid and job closed.

  23. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Mar 27, 2025
  24. JmillsExpensify commented on Mar 29, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @s77rt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions