You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-03] [$250] Invoice - Invoice can be downloaded from Reports but not from invoice details page #58346
Version Number: 9.1.12-5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+130302kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Invoice feature is enabled.
Go to staging.new.expensify.com
Go to FAB > Send invoice.
Send an invoice to any user.
Go to Reports > Invoices.
Select the invoice via checkmark.
Click on the dropdown.
Note that download option is available.
Click on the invoice.
Click on the report header.
Expected Result:
Download option should be accessible from invoice details page.
Actual Result:
Download option is not accessible from invoice details page.
What changes do you think we should make in order to solve the problem?
We should add || isInvoiceReport to this condition
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can render ReportDetailsPage and pass the invoice report as prop and verify the Download option is visible. We can also test if the transaction ID list is not empty by spying the exportReportToCSV and assert it's being called with the transaction ID list.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We should add another
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@samranahm Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
changed the title [-]Invoice - Invoice can be downloaded from Reports but not from invoice details page[/-][+][$250] Invoice - Invoice can be downloaded from Reports but not from invoice details page[/+]on Mar 19, 2025
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
You have a workspace and "Invoice" feature is enabled.
Test:
Send an invoice to any user
Open the invoice report
Open the report details by pressing on the report header
Verify the "download" item is displayed and you are able to download the invoice
Activity
melvin-bot commentedon Mar 13, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Mar 13, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-03-13 06:31:50 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Download option is not accessible from invoice details page.
What is the root cause of that problem?
We are just showing download option for money request report
App/src/pages/ReportDetailsPage.tsx
Lines 549 to 565 in 2496dfa
What changes do you think we should make in order to solve the problem?
We should add
|| isInvoiceReportto this conditionWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
bernhardoj commentedon Mar 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Invoice can't be downloaded from the report details page.
What is the root cause of that problem?
Currently, we only show the download option for IOU/expense report.
App/src/pages/ReportDetailsPage.tsx
Lines 549 to 553 in 2496dfa
And downloading requires the transaction ID list and it currently returns empty for non IOU/expense report.
App/src/pages/ReportDetailsPage.tsx
Lines 263 to 268 in 2496dfa
What changes do you think we should make in order to solve the problem?
First, show the download button for invoice report too.
Second, we need to include the transaction ID list for invoice report too.
To simplify it, we can even check if
caseIDis money report.App/src/pages/ReportDetailsPage.tsx
Lines 280 to 284 in 2496dfa
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can render ReportDetailsPage and pass the invoice report as prop and verify the Download option is visible. We can also test if the transaction ID list is not empty by spying the
exportReportToCSVand assert it's being called with the transaction ID list.samranahm commentedon Mar 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Invoice - Invoice can be downloaded from Reports but not from invoice details page
What is the root cause of that problem?
We are only displaying download as csv on
MoneyRequestReportApp/src/pages/ReportDetailsPage.tsx
Lines 549 to 552 in 2496dfa
What changes do you think we should make in order to solve the problem?
We should add another exception
|| isInvoiceReportand update our
App/src/pages/ReportDetailsPage.tsx
Lines 263 to 265 in 2496dfa
to
so that we did not return empty array on
isInvoiceReportleading to triggerWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We should add another
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon Mar 13, 2025
melvin-bot commentedon Mar 18, 2025
@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?
[-]Invoice - Invoice can be downloaded from Reports but not from invoice details page[/-][+][$250] Invoice - Invoice can be downloaded from Reports but not from invoice details page[/+]melvin-bot commentedon Mar 19, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021902155072665785104
33 remaining items
ahmedGaber93 commentedon Apr 2, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/50137/files#r2025132648
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Apr 3, 2025
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
bernhardoj commentedon Apr 3, 2025
Requested in ND.
melvin-bot commentedon Apr 8, 2025
@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...
ahmedGaber93 commentedon Apr 10, 2025
@adelekennedy bump for payment summary
adelekennedy commentedon Apr 10, 2025
Payments due:
@ahmedGaber93 owed $250 via NewDot
@bernhardoj owed $250 via NewDot
JmillsExpensify commentedon Apr 14, 2025
$250 approved for @bernhardoj
JmillsExpensify commentedon Apr 25, 2025
$250 approved for @ahmedGaber93