[Due for payment 2025-05-22] [$250] Trip - Long press the link "book a demo" doesn't show copy url to clipboard pop up.

@johncschuster

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: V9.1.12-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): Slottwo1+fasfggffd@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Other

Action Performed:

Go to https://staging.new.expensify.com/home
Tap reports > reports > bookmark > trip
Long press the link " book a demo "

Expected Result:

In trips page, long pressing the link "book a demo" must show copy url to clipboard pop up.

Actual Result:

In trips page, long pressing the link "book a demo" doesn't show copy url to clipboard pop up.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6769453_1741845305975.Screenrecorder-2025-03-13-11-20-16-967.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021902131005921399568
Upwork Job ID: 1902131005921399568
Last Price Increase: 2025-04-29

Issue Owner

Current Issue Owner: @johncschuster

@johncschuster

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In trips page, long pressing the link "book a demo" doesn't show copy url to clipboard pop up.

What is the root cause of that problem?

We define the <TextLink> here

App/src/pages/Search/EmptySearchView.tsx

Lines 66 to 72 in 2496dfa

    
           <TextLink 
        
               onPress={() => { 
        
                   Linking.openURL(CONST.BOOK_TRAVEL_DEMO_URL); 
        
               }} 
        
           > 
        
               {translate('travel.bookADemo')} 
        
           </TextLink>

And we don't have option to copy to clipboard

What changes do you think we should make in order to solve the problem?

We should add the icon copy in the right of the text link

              <TextLink
                  onPress={() => {
                      Linking.openURL(CONST.BOOK_TRAVEL_DEMO_URL);
                  }}
              >
                  {translate('travel.bookADemo')}
              </TextLink>
              <View style={styles.justifyContentCenter}>
                  <PressableWithDelayToggle
                      tooltipText={translate('reportActionContextMenu.copyToClipboard')}
                      tooltipTextChecked={translate('reportActionContextMenu.copied')}
                      icon={Expensicons.Copy}
                      onPress={()=>{
                          Clipboard.setString(CONST.BOOK_TRAVEL_DEMO_URL)
                      }}
                      accessible={false}
                      text=""
                  />
              </View>

Screen.Recording.2025-03-13.at.17.32.04.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Trip - Long press the link "book a demo" doesn't show copy url to clipboard pop up.

What is the root cause of that problem?

It is a feature request

What changes do you think we should make in order to solve the problem?

We should add long press handler

App/src/pages/Search/EmptySearchView.tsx

Lines 68 to 71 in d9e4e0c

    
           <TextLink 
        
               onPress={() => { 
        
                   Linking.openURL(CONST.BOOK_TRAVEL_DEMO_URL); 
        
               }}

                        onLongPress={(event) => {
                            showContextMenu(CONST.CONTEXT_MENU_TYPES.LINK, event, CONST.BOOK_TRAVEL_DEMO_URL, null);
                        }}

Result

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Job added to Upwork: https://www.upwork.com/jobs/~021902131005921399568

@sobitneupane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@sobitneupane

@sobitneupane Eep! 4 days overdue now. Issues have feelings too...

@drminh2807

Payment Summary

Upwork Job

ROLE: @drminh2807 paid $(AMOUNT) via Upwork (LINK)
Reviewer: @sobitneupane owed $250 via NewDot

BugZero Checklist (@johncschuster)

I have verified the correct assignees and roles are listed above and updated the necessary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1902131005921399568/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@sobitneupane

@sobitneupane can you complete the BZ Checklist when you get a moment?

@johncschuster

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

Bumped in Slack

@johncschuster

Sorry for the delay, @johncschuster.

I’m not at full capacity this week, but I’ll try to get it done over the weekend.

@johncschuster

@johncschuster Eep! 4 days overdue now. Issues have feelings too...

Not overdue, Melv. We're just waiting to close this out with a BZ Checklist

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: feat: update trips empty state view #48060 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Test:

Tap reports
Search "type:trip status:all"
Long press or double tap the link "book a demo"
Verify that context menu "Copy URL to clipboard" appears

Do we agree 👍 or 👎

@sobitneupane

@sobitneupane please request payment via NewDot! Payment Summary here!

@sobitneupane

$250 approved in NewDot for @sobitneupane.

(We changed approvers so this bounced to me!)

Navigation Menu

Repository navigation

[Due for payment 2025-05-22] [$250] Trip - Long press the link "book a demo" doesn't show copy url to clipboard pop up. #58359

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

77 remaining items

Payment Summary

BugZero Checklist (@johncschuster)

BugZero Checklist:

Regression Test Proposal

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<TextLink
	onPress={() => {
	Linking.openURL(CONST.BOOK_TRAVEL_DEMO_URL);
	}}
	>
	{translate('travel.bookADemo')}
	</TextLink>

[Due for payment 2025-05-22] [$250] Trip - Long press the link "book a demo" doesn't show copy url to clipboard pop up. #58359

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 13, 2025

daledah commented on Mar 13, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

drminh2807 commented on Mar 13, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Mar 18, 2025

melvin-bot commented on Mar 18, 2025

melvin-bot commented on Mar 24, 2025

77 remaining items

melvin-bot commented on May 22, 2025

Payment Summary

BugZero Checklist (@johncschuster)

johncschuster commented on May 23, 2025

melvin-bot commented on May 27, 2025

johncschuster commented on May 27, 2025

sobitneupane commented on May 29, 2025

melvin-bot commented on Jun 2, 2025

johncschuster commented on Jun 2, 2025

sobitneupane commented on Jun 3, 2025

BugZero Checklist:

Regression Test Proposal

Test:

johncschuster commented on Jun 3, 2025

trjExpensify commented on Aug 14, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions