You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-31] [$125] Header title uses wrong fonts in Workspace settings. #58386
Version Number: 9.1.12-5 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@dubielzyk-expensify Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
Navigate to workspace settings
Click Overview, Members, Expensify Cards, Company Cards, Workflows, Rules, Invoices
Expected Result:
Font size is as per design documents
Actual Result:
Uses wrong font size
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Header title uses wrong fonts in Workspace settings.[/-][+][$250] Header title uses wrong fonts in Workspace settings.[/+]on Mar 19, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.17-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Pujan92 / @shubham1206agra@JmillsExpensify@Pujan92 / @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Navigate to workspace settings
Click Overview, Members, Expensify Cards, Company Cards, Workflows, Rules, Invoices and verify the header font is correct
Activity
melvin-bot commentedon Mar 13, 2025
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Mar 13, 2025
shubham1206agra commentedon Mar 13, 2025
Note for C+ - My proposal was first posted https://expensify.slack.com/archives/C049HHMV9SM/p1741846813554639?thread_ts=1741845175.294349&cid=C049HHMV9SM
shubham1206agra commentedon Mar 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Header title uses wrong fonts in Workspace settings.
What is the root cause of that problem?
In
App/src/pages/workspace/WorkspacePageWithSections.tsx
Lines 180 to 189 in 2496dfa
We forgot to add
shouldUseHeadlineHeaderwhich caused the wrong font to be appliedWhat changes do you think we should make in order to solve the problem?
Add
shouldUseHeadlineHeadertoApp/src/pages/workspace/WorkspacePageWithSections.tsx
Lines 180 to 189 in 2496dfa
Which will fix this issue
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Not Required as this is an UI issue
What alternative solutions did you explore? (Optional)
m-natarajan commentedon Mar 13, 2025
My apologies I forgot to post, @shubham1206agra posted the proposal first, @daledah can you please remove your proposal if possible.
melvin-bot commentedon Mar 17, 2025
@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Mar 19, 2025
@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?
[-]Header title uses wrong fonts in Workspace settings.[/-][+][$250] Header title uses wrong fonts in Workspace settings.[/+]melvin-bot commentedon Mar 19, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021902287874021816471
22 remaining items
melvin-bot commentedon Mar 24, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.17-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-31. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 24, 2025
@Pujan92 / @shubham1206agra @JmillsExpensify @Pujan92 / @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 31, 2025
Payment Summary
Upwork Job
BugZero Checklist (@JmillsExpensify)
Pujan92 commentedon Apr 2, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [vip-travel] Create Trip Details Screen #52823 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
melvin-bot commentedon Apr 3, 2025
@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Apr 7, 2025
@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
JmillsExpensify commentedon Apr 8, 2025
Payment summary:
JmillsExpensify commentedon Apr 8, 2025
We don't typically do regression tests for font styles, so I'm going to close this out. Please submit expenses.
garrettmknight commentedon Apr 10, 2025
$125 approved for @Pujan92
garrettmknight commentedon Apr 22, 2025
$125 approved for @shubham1206agra