Skip to content

[Due for payment 2025-03-31] [$125] Header title uses wrong fonts in Workspace settings. #58386

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.12-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

  1. Navigate to workspace settings
  2. Click Overview, Members, Expensify Cards, Company Cards, Workflows, Rules, Invoices

Expected Result:

Font size is as per design documents

Actual Result:

Uses wrong font size

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Image

Recording.1053.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021902287874021816471
  • Upwork Job ID: 1902287874021816471
  • Last Price Increase: 2025-03-19
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 13, 2025
  2. melvin-bot commented on Mar 13, 2025

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. daledah commented on Mar 13, 2025

    @daledah
  4. shubham1206agra commented on Mar 13, 2025

    @shubham1206agra
    Contributor
  5. shubham1206agra commented on Mar 13, 2025

    @shubham1206agra
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Header title uses wrong fonts in Workspace settings.

    What is the root cause of that problem?

    In

    <HeaderWithBackButton
    title={headerText}
    onBackButtonPress={() => (onBackButtonPress ? onBackButtonPress() : Navigation.goBack(backButtonRoute))}
    shouldShowBackButton={shouldUseNarrowLayout || shouldShowBackButton}
    icon={icon ?? undefined}
    style={styles.headerBarDesktopHeight}
    shouldShowThreeDotsButton={shouldShowThreeDotsButton}
    threeDotsMenuItems={threeDotsMenuItems}
    threeDotsAnchorPosition={threeDotsAnchorPosition}
    >

    We forgot to add shouldUseHeadlineHeader which caused the wrong font to be applied

    What changes do you think we should make in order to solve the problem?

    Add shouldUseHeadlineHeader to

    <HeaderWithBackButton
    title={headerText}
    onBackButtonPress={() => (onBackButtonPress ? onBackButtonPress() : Navigation.goBack(backButtonRoute))}
    shouldShowBackButton={shouldUseNarrowLayout || shouldShowBackButton}
    icon={icon ?? undefined}
    style={styles.headerBarDesktopHeight}
    shouldShowThreeDotsButton={shouldShowThreeDotsButton}
    threeDotsMenuItems={threeDotsMenuItems}
    threeDotsAnchorPosition={threeDotsAnchorPosition}
    >

    Which will fix this issue

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    Not Required as this is an UI issue

    What alternative solutions did you explore? (Optional)

  6. m-natarajan commented on Mar 13, 2025

    @m-natarajan
    Author

    My apologies I forgot to post, @shubham1206agra posted the proposal first, @daledah can you please remove your proposal if possible.

  7. melvin-bot commented on Mar 17, 2025

    @melvin-bot

    @JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  8. melvin-bot commented on Mar 19, 2025

    @melvin-bot

    @JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 19, 2025
  10. changed the title [-]Header title uses wrong fonts in Workspace settings.[/-] [+][$250] Header title uses wrong fonts in Workspace settings.[/+] on Mar 19, 2025
  11. melvin-bot commented on Mar 19, 2025

    @melvin-bot
  12. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 19, 2025
  13. 22 remaining items

  14. melvin-bot commented on Mar 24, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.17-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-31. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Pujan92 requires payment through NewDot Manual Requests
    • @shubham1206agra requires payment through NewDot Manual Requests
  15. melvin-bot commented on Mar 24, 2025

    @melvin-bot

    @Pujan92 / @shubham1206agra @JmillsExpensify @Pujan92 / @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@JmillsExpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1902287874021816471/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. Pujan92 commented on Apr 2, 2025

    @Pujan92
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: [vip-travel] Create Trip Details Screen #52823 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    1. Navigate to workspace settings
    2. Click Overview, Members, Expensify Cards, Company Cards, Workflows, Rules, Invoices and verify the header font is correct
  18. melvin-bot commented on Apr 3, 2025

    @melvin-bot

    @JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  19. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    @JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  20. JmillsExpensify commented on Apr 8, 2025

    @JmillsExpensify
    Contributor

    Payment summary:

  21. JmillsExpensify commented on Apr 8, 2025

    @JmillsExpensify
    Contributor

    We don't typically do regression tests for font styles, so I'm going to close this out. Please submit expenses.

  22. garrettmknight commented on Apr 10, 2025

    @garrettmknight
    Contributor

    $125 approved for @Pujan92

  23. garrettmknight commented on Apr 22, 2025

    @garrettmknight
    Contributor

    $125 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions