[Due for payment 2025-03-27] Track expense - Unable to delete track expense from context menu

@JmillsExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.14-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): jsdsjdojsdoijo@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

Account has self DM.

Go to staging.new.expensify.com
Go to self DM.
Track a manual expense.
Right click on the expense preview.
Click Delete expense.

Expected Result:

There will be a delete modal when deleting expense from context menu.

Actual Result:

There is no delete modal when deleting expense from context menu.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6773280_1742230933533.delete.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

@JmillsExpensify

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@neil-marcellini

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

🚨 Edited by proposal-police: This proposal was edited at 2025-03-17 17:56:14 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track expense - Unable to delete track expense from context menu

What is the root cause of that problem?

here

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 769 in 9dc9fb1

    
           const reportID = isMoneyRequestAction(moneyRequestAction) ? getOriginalMessage(moneyRequestAction)?.IOUReportID : reportIDParam;

when isMoneyRequestAction reportID becomes 0 leading to not displaying delete Model

What changes do you think we should make in order to solve the problem?

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 770 to 778 in fa8eb81

    
               if (closePopover) { 
        
                   // Hide popover, then call showDeleteConfirmModal 
        
                   hideContextMenu(false, () => showDeleteModal(reportID, moneyRequestAction ?? reportAction)); 
        
                   return; 
        
               } 
        
               // No popover to hide, call showDeleteConfirmModal immediately 
        
               showDeleteModal(reportID, moneyRequestAction ?? reportAction); 
        
           },

Here we are getting report ID from original message but we should pass the report Id from reportIDParam

onPress: (closePopover, {reportID: reportIDParam, reportAction, moneyRequestAction}) => {
    if (closePopover) {
    // Hide popover, then call showDeleteConfirmModal
        hideContextMenu(false, () => showDeleteModal(reportIDParam, moneyRequestAction ?? reportAction));
        return;
    }

    // No popover to hide, call showDeleteConfirmModal immediately
    showDeleteModal(reportIDParam, moneyRequestAction ?? reportAction);
},

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

@daledah

Payment Summary

Upwork Job

ROLE: @daledah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@JmillsExpensify)

I have verified the correct assignees and roles are listed above and updated the necessary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@daledah

Payment summary: $250 to @daledah via Upwork.

Offer sent

All paid out.

@JmillsExpensify

@JmillsExpensify requesting payment summary for review of PR, thank you!
#58590 (comment)

@JmillsExpensify

@JmillsExpensify can you confirm if @rushatgabhane should get payment here and update the summary if that's the case?

@JmillsExpensify

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@rushatgabhane

Payment summary for @rushatgabhane: $250 for PR review and testing.

@rushatgabhane

$250 approved for @rushatgabhane

Navigation Menu

Repository navigation

[Due for payment 2025-03-27] Track expense - Unable to delete track expense from context menu #58571

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

18 remaining items

Payment Summary

BugZero Checklist (@JmillsExpensify)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (closePopover) {
	// Hide popover, then call showDeleteConfirmModal
	hideContextMenu(false, () => showDeleteModal(reportID, moneyRequestAction ?? reportAction));
	return;
	}

	// No popover to hide, call showDeleteConfirmModal immediately
	showDeleteModal(reportID, moneyRequestAction ?? reportAction);
	},

[Due for payment 2025-03-27] Track expense - Unable to delete track expense from context menu #58571

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 17, 2025

melvin-bot commented on Mar 17, 2025

melvin-bot commented on Mar 17, 2025

github-actions commented on Mar 17, 2025

samranahm commented on Mar 17, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

github-actions commented on Mar 17, 2025

18 remaining items

melvin-bot commented on Mar 27, 2025

Payment Summary

BugZero Checklist (@JmillsExpensify)

JmillsExpensify commented on Mar 27, 2025

JmillsExpensify commented on Mar 27, 2025

JmillsExpensify commented on Mar 29, 2025

rushatgabhane commented on Apr 2, 2025

garrettmknight commented on Apr 10, 2025

melvin-bot commented on Apr 14, 2025

JmillsExpensify commented on Apr 16, 2025

garrettmknight commented on Apr 22, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions