You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-28] [Due for payment 2025-03-27] Company cards - Add cards button is disabled #58667
Version Number: 9.1.15-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+67907690@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Workspace Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
We incorrectly disable the button when workspaceAccountID is greater then CONST.DEFAULT_NUMBER_ID. If the workspaceAccountID is exist this condition is always true, so the button will always disabled when the workspaceAccountID exist
changed the title [-]Company cards - Add cards button is disabled[/-][+][Due for payment 2025-03-27] Company cards - Add cards button is disabled[/+]on Mar 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dangrous@JmillsExpensify@dangrous The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2025-03-27] Company cards - Add cards button is disabled[/-][+][Due for payment 2025-03-28] [Due for payment 2025-03-27] Company cards - Add cards button is disabled[/+]on Mar 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.16-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dangrous@JmillsExpensify@dangrous The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 18, 2025
Triggered auto assignment to @dangrous (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 18, 2025
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 18, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 18, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
dangrous commentedon Mar 19, 2025
coming from #58599 cc @mountiny as the author
nyomanjyotisa commentedon Mar 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Add cards button is disabled
What is the root cause of that problem?
Coming from #58599
We incorrectly disable the button when
workspaceAccountIDis greater thenCONST.DEFAULT_NUMBER_ID. If theworkspaceAccountIDis exist this condition is always true, so the button will always disabled when theworkspaceAccountIDexistApp/src/pages/workspace/companyCards/WorkspaceCompanyCardPageEmptyState.tsx
Line 45 in c94cb19
App/src/pages/workspace/companyCards/WorkspaceCompanyCardPageEmptyState.tsx
Line 74 in c94cb19
What changes do you think we should make in order to solve the problem?
Change the condition to the following
since if
policy?.workspaceAccountIDis not exist, we setCONST.DEFAULT_NUMBER_IDto theworkspaceAccountIDWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
I don't think automated test required here, but if required we can create UI test to:
policy?.workspaceAccountIDexistpolicy?.workspaceAccountIDdidn't existWhat alternative solutions did you explore? (Optional)
5 remaining items
mountiny commentedon Mar 19, 2025
All done we can close I think, thanks for handling
[-]Company cards - Add cards button is disabled[/-][+][Due for payment 2025-03-27] Company cards - Add cards button is disabled[/+]melvin-bot commentedon Mar 20, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-27. 🎊
melvin-bot commentedon Mar 20, 2025
@dangrous @JmillsExpensify @dangrous The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2025-03-27] Company cards - Add cards button is disabled[/-][+][Due for payment 2025-03-28] [Due for payment 2025-03-27] Company cards - Add cards button is disabled[/+]melvin-bot commentedon Mar 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.16-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-03-28. 🎊
melvin-bot commentedon Mar 21, 2025
@dangrous @JmillsExpensify @dangrous The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]