Skip to content

[Due for payment 2025-03-28] [Due for payment 2025-03-27] Company cards - Add cards button is disabled #58667

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.15-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+67907690@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace.
  3. Go to Company cards.
  4. Click Add cards.

Expected Result:

Add cards button should not be disabled.

Actual Result:

Add cards button is disabled.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6774894_1742337436388.company_card.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 18, 2025
  2. melvin-bot commented on Mar 18, 2025

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Mar 18, 2025

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Mar 18, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Mar 18, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. dangrous commented on Mar 19, 2025

    @dangrous
    Contributor

    coming from #58599 cc @mountiny as the author

  7. nyomanjyotisa commented on Mar 19, 2025

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Add cards button is disabled

    What is the root cause of that problem?

    Coming from #58599

    We incorrectly disable the button when workspaceAccountID is greater then CONST.DEFAULT_NUMBER_ID. If the workspaceAccountID is exist this condition is always true, so the button will always disabled when the workspaceAccountID exist

    const workspaceAccountID = policy?.workspaceAccountID ?? CONST.DEFAULT_NUMBER_ID;

    isButtonDisabled={workspaceAccountID > CONST.DEFAULT_NUMBER_ID}

    What changes do you think we should make in order to solve the problem?

    Change the condition to the following

    isButtonDisabled={workspaceAccountID === CONST.DEFAULT_NUMBER_ID}
    

    since if policy?.workspaceAccountID is not exist, we set CONST.DEFAULT_NUMBER_ID to the workspaceAccountID

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    I don't think automated test required here, but if required we can create UI test to:

    • Verify the button enabled if policy?.workspaceAccountID exist
    • Verify the button disabled if policy?.workspaceAccountID didn't exist

    What alternative solutions did you explore? (Optional)

  8. 5 remaining items

  9. mountiny commented on Mar 19, 2025

    @mountiny
    Contributor

    All done we can close I think, thanks for handling

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 20, 2025
  11. changed the title [-]Company cards - Add cards button is disabled[/-] [+][Due for payment 2025-03-27] Company cards - Add cards button is disabled[/+] on Mar 20, 2025
  12. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-27. 🎊

  14. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    @dangrous @JmillsExpensify @dangrous The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. changed the title [-][Due for payment 2025-03-27] Company cards - Add cards button is disabled[/-] [+][Due for payment 2025-03-28] [Due for payment 2025-03-27] Company cards - Add cards button is disabled[/+] on Mar 21, 2025
  16. melvin-bot commented on Mar 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.16-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-03-28. 🎊

  17. melvin-bot commented on Mar 21, 2025

    @melvin-bot

    @dangrous @JmillsExpensify @dangrous The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions