You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-27] [$250] 2FA - Hybrid - User asked to again validate account after disabling 2FA #58682
Version Number: 9.1.15-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/5766528 Email or phone of affected tester (no customers):applausetester+ck3182510@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Pixel 8a/Android 15 App Component: User Settings
Action Performed:
Launch Hybrid app
Log in with new validated account
Go to Settings >> Security >> 2FA
Enter the magic code to validate account to use 2FA feature
Go through the 2FA process
Once the 2FA is enabled, log out of the account
Log in with same account >> enter magic account >> enter 2FA code
Go to Settings >> Security >> 2FA
Disable 2FA
Enter 2FA code from authenticator app
Observe user asked to again validate account
Expected Result:
User should not be prompted to validate account again after disabling 2FA.
Actual Result:
User asked to again validate account to enter magic code after disabling 2FA
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Oh, interesting but I'm not sure about that - do you mean that an API command that is supposed to return the Account data isn't returning that data correctly?
We definitely to standardize the usage
Yes, agreed. From our internal convo, I think we will be merging User and Account into a single model: Account. I double check on Monday if any of our internal engineers have any objections. If not, I will create an issue to merge those two models.
do you mean that an API command that is supposed to return the Account data isn't returning that data correctly?
Yeah, that's my guess. My PR is already deployed to prod, but this issue is marked as a deploy blocker, so there might be something changed with the API.
If there are no objections, I will create a separate issue to tackle that so we can centralize all user/account related information in the Account model.
Oops, I forgot that there was an outstanding question from @MariaHCD proposing that we deprecate the User model and merge it into the Account model internally in a separate issue.
@MariaHCD - I've finished handling payment, so if everyone agrees with your proposal, feel free to close out this issue when you're ready.
Activity
melvin-bot commentedon Mar 19, 2025
Triggered auto assignment to @MariaHCD (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 19, 2025
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Mar 19, 2025
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Mar 19, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
dukenv0307 commentedon Mar 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
User asked to again validate account to enter magic code after disabling 2FA
What is the root cause of that problem?
When we redirect to ND after signing in,
account?.validatedisundefinedthen the validate modal appears again after we disabled the 2FAApp/src/pages/settings/Security/TwoFactorAuth/CopyCodesPage.tsx
Line 48 in cb0d374
What changes do you think we should make in order to solve the problem?
To check the
isUserValidatedwe should useuser?.validatedApp/src/pages/settings/Security/TwoFactorAuth/CopyCodesPage.tsx
Line 48 in cb0d374
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Mar 19, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021902273993490623286
34 remaining items
MariaHCD commentedon Mar 21, 2025
Oh, interesting but I'm not sure about that - do you mean that an API command that is supposed to return the Account data isn't returning that data correctly?
Yes, agreed. From our internal convo, I think we will be merging User and Account into a single model: Account. I double check on Monday if any of our internal engineers have any objections. If not, I will create an issue to merge those two models.
bernhardoj commentedon Mar 21, 2025
Yeah, that's my guess. My PR is already deployed to prod, but this issue is marked as a deploy blocker, so there might be something changed with the API.
MariaHCD commentedon Mar 27, 2025
I'm proposing that we deprecate the User model and merge it into the Account model internally: https://expensify.slack.com/archives/C03TQ48KC/p1743072786763749?thread_ts=1742392904.804209&cid=C03TQ48KC
If there are no objections, I will create a separate issue to tackle that so we can centralize all user/account related information in the Account model.
sakluger commentedon Mar 27, 2025
Summarizing payment on this issue:
Contributor: @dukenv0307 $250, please request on Newdot
Contributor+: @allgandalf $250, paid via Upwork
sakluger commentedon Mar 27, 2025
Oops, I forgot that there was an outstanding question from @MariaHCD proposing that we deprecate the User model and merge it into the Account model internally in a separate issue.
@MariaHCD - I've finished handling payment, so if everyone agrees with your proposal, feel free to close out this issue when you're ready.
MariaHCD commentedon Mar 28, 2025
Internal convo on deprecating the User model got no pushback so far: https://expensify.slack.com/archives/C03TQ48KC/p1743072786763749?thread_ts=1742392904.804209&cid=C03TQ48KC
So I will create a new issue for that :) We can close this one out. Thanks, all!
JmillsExpensify commentedon Apr 25, 2025
$250 approved for @dukenv0307