You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-27] [Due for payment 2025-05-08] [$250] Distance rates - User goes to rate details when tapping on it in multiselect mode #58696
Version Number: v9.1.15-3 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/5766860 Email or phone of affected tester (no customers):sustinov@applausemail.com Issue reported by: Applause Internal Team Device used: OnePlus 9 PRO/Android 14/Chrome, iPhone 12 PRO/iOS 18.3.1 App Component: Workspace Settings
Action Performed:
Prerequisites:
Create a WS, in the WS settings enable Distance rates, create multiple rates
Steps:
Open Hybrid ND app
Log in as a user with a configured WS
Navigate to the WS settings
Navigate to Distance rates
Long press on any rate to activate multiselection
Tap in the middle on any rate
Expected Result:
When you click on a rate in multiselect mode, that rate should select, not go to its details
Actual Result:
User goes to rate details when tapping on it in multiselect mode. In categories and tags, this field is selected when you tap on the field itself
What changes do you think we should make in order to solve the problem?
We should add the condition like in the category page here
if (isSmallScreenWidth && selectionMode?.isEnabled) {
toggleRate(rate);
return;
}
Note: We can fix the other page if it get the same bug
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@abzokhattab Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
🚨 Edited by proposal-police: This proposal was edited at 2025-03-19 10:51:54 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
In multi-selection mode inside the distance rates, tapping on a row triggers navigation to the details page, when the expected behavior is to simply toggle the selection state.
What is the root cause of that problem?
The selectRow function inside the selection modal always triggers navigation to the details page, even in multi-selection mode, without checking whether we want to toggle the selection or navigate.
What changes do you think we should make in order to solve the problem?
To fix the root cause of this issue and prevent it in other places, we should disable executing the onSelectRow function inside the selection list if canSelectMultiple is true and isSmallScreenWidth.
We can modify this part in the BaseSelectionListItemRenderer.tsx
Optional: we can make this behavior optional by introducing a boolean prop such as shouldExecuteCheckboxSelectionOnMobile, which would allow us to enable or disable this behavior only in components where needed. This would prevent breaking any existing functionality and give us the flexibility to control it per component.
POC:
Screen.Recording.2025-03-19.at.11.52.37.mov
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Alternatively we can change the selection function inside
the BaseSelectionList instead of the BaseSelectionListItemRendererhere
changed the title [-]Distance rates - User goes to rate details when tapping on it in multiselect mode[/-][+][$250] Distance rates - User goes to rate details when tapping on it in multiselect mode[/+]on Mar 19, 2025
Please re-state the problem that we are trying to solve in this issue.
Distance rates - User goes to rate details when tapping on it in multiselect mode
What is the root cause of that problem?
We don't have mechanism to prevent calling onSelectRow when selectionMode?.isEnabled is true and option can be selected. This should be applied in SelectionListWithModal.
What changes do you think we should make in order to solve the problem?
First we need to extract onSelectRow & onCheckboxPress from the props here.
Then we would need to create a function onPress to call the onCheckboxPress function when selectionMode?.isEnabled and other required conditions are true.
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Narrow devices (small screens) tests
Create a workspace
Navigate to Workspace settings and enable: distance rates, categories, tags, taxes, and report fields
Create a few records in each of the above sections and invite a few members to the workspace
Navigate to each of those pages (including the members page)
Long press on a record to activate multiselection
Tap in the middle of a record
Confirm that the record is selected or unselected, and that the record details page does not open
Wide devices (web / desktop) tests
Repeat steps 1 and 2 above
Click on a record
Confirm that the user is navigated to the record details page
Activity
melvin-bot commentedon Mar 19, 2025
Triggered auto assignment to @maddylewis (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Mar 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
User goes to rate details when tapping on it in multiselect mode. In categories and tags, this field is selected when you tap on the field itself
What is the root cause of that problem?
We are navigating when click the distance rate row
App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx
Lines 187 to 190 in 52b22cb
What changes do you think we should make in order to solve the problem?
We should add the condition like in the category page here
Note: We can fix the other page if it get the same bug
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon Mar 19, 2025
abzokhattab commentedon Mar 19, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-03-19 10:51:54 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
In multi-selection mode inside the distance rates, tapping on a row triggers navigation to the details page, when the expected behavior is to simply toggle the selection state.
What is the root cause of that problem?
The selectRow function inside the selection modal always triggers navigation to the details page, even in multi-selection mode, without checking whether we want to toggle the selection or navigate.
What changes do you think we should make in order to solve the problem?
To fix the root cause of this issue and prevent it in other places, we should disable executing the
onSelectRowfunction inside the selection list ifcanSelectMultipleistrueandisSmallScreenWidth.We can modify this part in the
BaseSelectionListItemRenderer.tsxApp/src/components/SelectionList/BaseSelectionListItemRenderer.tsx
Lines 62 to 68 in bea3eb9
to
Optional: we can make this behavior optional by introducing a boolean prop such as
shouldExecuteCheckboxSelectionOnMobile, which would allow us to enable or disable this behavior only in components where needed. This would prevent breaking any existing functionality and give us the flexibility to control it per component.POC:
Screen.Recording.2025-03-19.at.11.52.37.mov
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Alternatively we can change the selection function inside
the
BaseSelectionListinstead of theBaseSelectionListItemRendererherewe can add this condition to top of this function
[-]Distance rates - User goes to rate details when tapping on it in multiselect mode[/-][+][$250] Distance rates - User goes to rate details when tapping on it in multiselect mode[/+]melvin-bot commentedon Mar 19, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021902356609676349283
melvin-bot commentedon Mar 19, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (
External)Krishna2323 commentedon Mar 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance rates - User goes to rate details when tapping on it in multiselect mode
What is the root cause of that problem?
onSelectRowwhenselectionMode?.isEnabledis true and option can be selected. This should be applied inSelectionListWithModal.What changes do you think we should make in order to solve the problem?
onSelectRow&onCheckboxPressfrom the props here.onPressto call theonCheckboxPressfunction whenselectionMode?.isEnabledand other required conditions are true.onPressandonCheckboxPresstoSelectionList.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Result
melvin-bot commentedon Mar 25, 2025
@allgandalf Huh... This is 4 days overdue. Who can take care of this?
70 remaining items
maddylewis commentedon May 20, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
maddylewis commentedon May 27, 2025
Payment Overview + Final To-Dos
maddylewis commentedon May 27, 2025
Since this arose from a regression, i believe the payments are now $125. lmk if im mistaken!
allgandalf commentedon May 28, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: 166363d#r158190761
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Confirm that the record is selected or unselected, and that the record details page does not open
Do we agree 👍 or 👎
Improve SelectionList item rendering performance