You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Concierge chat - 'Back' app button redirects to 'Workspaces' instead of 'Concierge' #58709
Version Number: 9.1.15-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory. Email or phone of affected tester (no customers):testexpensify9+onvoardin000005@gmail.com Issue reported by: Applause Internal Team Device used: Samsung A15, Android 14 | iPhone SE 3rd generation (2022), iOS 18.3.2 App Component: Other
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@samranahm Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
🚨 Edited by proposal-police: This proposal was edited at 2025-03-20 03:23:15 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
When user clicks on the call to action link in the Title or description of any onboarding task, after going to that page, using the back button , user is not landing on the concierge chat/admin room
What is the root cause of that problem?
We are not adding the backTo route here to the call-to-actions links :
This is happens in both Titles and Descriptions of the onboarding Tasks
What changes do you think we should make in order to solve the problem?
For the Title part: In case of test accounts, those which have + in it, the onboarding tasks are created in the concierge chat, while in the case of real users , the onboarding tasks are created in the admin room
Check if the shouldPostTasksInAdminsRoom is true, then add adminRoom as the backTo route, otherwise the concierge chat.
for example for the createWorkspace task:
Or directly we can use targetChatReportID, which is found considering the shouldPostTasksInAdminsRoom
2. For the description part, we have to use the reportID of each task as the backTo route
let's say if user opens the createWorkspace task, and then they click on the Check it out link, the reportID of the current task report should be the backTo route
For that instead of generating the reportID inside the buildOptimisticTaskReport, we can generate the reportID, before calling the buildOptimisticTaskReport here:
Activity
melvin-bot commentedon Mar 19, 2025
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Mar 19, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
samranahm commentedon Mar 19, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-03-19 17:07:47 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Concierge chat - 'Back' app button redirects to 'Workspaces' instead of 'Concierge'
What is the root cause of that problem?
Here
App/src/pages/workspace/WorkspaceInitialPage.tsx
Line 444 in fa8eb81
we are using
ROUTES.SETTINGS_WORKSPACESthat take us back to workspaces pageWhat changes do you think we should make in order to solve the problem?
Update the logic like this to always go back on from route
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon Mar 19, 2025
mitarachim commentedon Mar 19, 2025
we have different behavior in Prod Android Hybrid (9.1.9.8 from playstore)
2025-03-19.7.09.15.PM.mp4
but have same behavior in Prod Android: mWeb Chrome (v9.1.14-5) and iOS Hybrid (v9.1.14-5)
ScreenRecording_03-19-2025.19-21-30_1.MP4
2025-03-19.7.18.21.PM.mp4
lschurr commentedon Mar 19, 2025
Started convo here: https://expensify.slack.com/archives/C01GTK53T8Q/p1742399049471069
13 remaining items
mountiny commentedon Mar 19, 2025
This might not be a bug
mountiny commentedon Mar 19, 2025
Discussing in the thread
daledah commentedon Mar 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The user is redirected to 'Workspaces' page.
What is the root cause of that problem?
We just get the workspace setting link here
App/src/CONST.ts
Lines 128 to 132 in 04a0d0b
App/src/libs/actions/Report.ts
Lines 3922 to 3928 in 04a0d0b
What changes do you think we should make in order to solve the problem?
We should add
backToto theWORKSPACE_INITIALroute to go back the concierge page when user click the device back buttonWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
samranahm commentedon Mar 19, 2025
Proposal updated
Shahidullah-Muffakir commentedon Mar 20, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-03-20 03:23:15 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
When user clicks on the call to action link in the Title or description of any onboarding task, after going to that page, using the back button , user is not landing on the concierge chat/admin room
What is the root cause of that problem?
We are not adding the backTo route here to the call-to-actions links :
App/src/libs/actions/Report.ts
Lines 3896 to 3904 in 524c4e8
and here:
App/src/libs/actions/Report.ts
Line 3910 in 524c4e8
This is happens in both Titles and Descriptions of the onboarding Tasks
What changes do you think we should make in order to solve the problem?
App/src/libs/actions/Report.ts
Line 3825 in 524c4e8
Consider this , we will add the backTo route:
Check if the
shouldPostTasksInAdminsRoomis true, then add adminRoom as the backTo route, otherwise the concierge chat.for example for the createWorkspace task:
Or directly we can use
targetChatReportID, which is found considering theshouldPostTasksInAdminsRoom2. For the description part, we have to use the
reportIDof each task as thebackToroutelet's say if user opens the createWorkspace task, and then they click on the
Check it outlink, thereportIDof the current task report should be the backTo routeFor that instead of generating the reportID inside the
buildOptimisticTaskReport, we can generate the reportID, before calling thebuildOptimisticTaskReporthere:App/src/libs/actions/Report.ts
Line 3913 in 3addd36
as :
and then use this reportID as the backTo route in the description call-to-action link, for ex in the createWorkspace task:
App/src/libs/actions/Report.ts
Line 3903 in 3addd36
and then pass the same reportID to the
buildOptimisticTaskReport, and inside thebuildOptimisticTaskReportuse it if exists:App/src/libs/ReportUtils.ts
Line 6879 in 3addd36
as:
3. Additionally these routes don't support the backTo route currently, we will add that as well:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
No need
What alternative solutions did you explore? (Optional)
mountiny commentedon Mar 20, 2025
As mentioned in the thread, this is not a bug actually, the in app button acts as UP action so it takes you up in the stack.
The device back or browser history back will take you back to the concierge chat
melvin-bot commentedon Mar 25, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.