Skip to content

Populate deploy checklists with PRs from both repos #58775

Closed

Description

@roryabraham

Problem

HybridApp includes code from two repos - E/App and E/Mobile-Expensify. However, our deploy checklists only include code from E/App. This means that we (and applause) do not have a clear view of when Mobile-Expensify PRs are deployed, nor a complete and accurate view of all pull requests introducing code changes in a given release.

Solution

  • Populate deploy checklists with pull requests from both E/App and E/Mobile-Expensify
  • Fix the diff link and include a Mobile-Expensify diff link in the checklist as well
  • Leave deploy comments on Mobile-Expensify PRs when they're deployed in HybridApp.

Activity

  1. self-assigned this
    on Mar 19, 2025
  2. melvin-bot commented on Mar 19, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  3. melvin-bot commented on Mar 19, 2025

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  4. melvin-bot commented on Mar 19, 2025

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

  5. roryabraham commented on Mar 19, 2025

    @roryabraham
    ContributorAuthor

    HOLD on #55403

  6. changed the title [-]Populate deploy checklists with PRs from both repos[/-] [+][HOLD #55403] Populate deploy checklists with PRs from both repos[/+] on Mar 19, 2025
  7. changed the title [-][HOLD #55403] Populate deploy checklists with PRs from both repos[/-] [+]Populate deploy checklists with PRs from both repos[/+] on Apr 1, 2025
  8. 94 remaining items

  9. Julesssss commented on Aug 11, 2025

    @Julesssss
    Contributor

    PR in review: #67444

  10. Julesssss commented on Aug 12, 2025

    @Julesssss
    Contributor

    Live on staging and generating checklists nicely:

    Image Image
  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 13, 2025
  12. changed the title [-]Populate deploy checklists with PRs from both repos[/-] [+][Due for payment 2025-08-20] Populate deploy checklists with PRs from both repos[/+] on Aug 13, 2025
  13. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.93-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-08-20. 🎊

  15. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Julesssss / @roryabraham] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  16. Julesssss commented on Aug 18, 2025

    @Julesssss
    Contributor

    Completed.

    Checklists now contain Mobile-Expensify diff, Mobile-Expensify PRs, and we comment on deployed Mobile-Expensify PRs 🎉

    Image
  17. changed the title [-][Due for payment 2025-08-20] Populate deploy checklists with PRs from both repos[/-] [+]Populate deploy checklists with PRs from both repos[/+] on Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionFire-CleanupSomething needs to be done after a fireNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions