Skip to content

[Due for payment 2025-04-10] [Better Expense Report View] Expense Reports - Table header remains after all the expenses are deleted #58854

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.16-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kok1@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Precondition:

  • Log in with Expensifail account.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit a manual expense to the workspace chat.
  4. Go to expense report and send a message.
  5. Go to Reports.
  6. Go to Expense Reports.
  7. Click on the expense report from Step 4.
  8. Click on the report header > Delete expense.
  9. Delete the expense.

Expected Result:

The table header will disappear after all the expenses are deleted.

Actual Result:

The table header remains after all the expenses are deleted.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 20, 2025
  2. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Mar 20, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. vincdargento commented on Mar 20, 2025

    @vincdargento
    Author

    @twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. luacmartins commented on Mar 20, 2025

    @luacmartins
    Contributor

    This view is behind a beta. NAB. @Kicu

  8. self-assigned this
    on Mar 20, 2025
  9. 30 remaining items

  10. luacmartins commented on Apr 2, 2025

    @luacmartins
    Contributor

    🤝

  11. dubielzyk-expensify commented on Apr 3, 2025

    @dubielzyk-expensify
    Contributor

    🤝

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 3, 2025
  13. changed the title [-][Better Expense Report View] Expense Reports - Table header remains after all the expenses are deleted[/-] [+][Due for payment 2025-04-10] [Better Expense Report View] Expense Reports - Table header remains after all the expenses are deleted[/+] on Apr 3, 2025
  14. melvin-bot commented on Apr 3, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Apr 3, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.22-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-10. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Kicu does not require payment (Contractor)
    • @DylanDylann requires payment (Needs manual offer from BZ)
  16. melvin-bot commented on Apr 3, 2025

    @melvin-bot

    @DylanDylann @twisterdotcom @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. mountiny commented on Apr 3, 2025

    @mountiny
    Contributor

    🤝

    Sorry using internet explorer

  18. Kicu commented on Apr 8, 2025

    @Kicu
    Contributor

    @mountiny I think we can close this. There were separate PRs responsible for the "empty transactions" view and it looks good - header no longer stays.

  19. mountiny commented on Apr 8, 2025

    @mountiny
    Contributor

    🤝

  20. moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrateon Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions