Skip to content

[Due for payment 2025-05-20] [$500] iOS - Expense Reports - Report page cannot be dismissed by swiping to right #58863

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.16-2
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kok1@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Search

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Account has at least one expense.
  1. Launch ND or hybrid app.
  2. Go to Reports.
  3. Tap bookmark icon.
  4. Go to Expense Reports.
  5. Open any expense reports.
  6. Swipe to right with iOS gesture to go back.

Expected Result:

The report page can be dismissed by swiping to right.

Actual Result:

The report page cannot be dismissed by swiping to right.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021903125815331781283
  • Upwork Job ID: 1903125815331781283
  • Last Price Increase: 2025-04-18
Issue OwnerCurrent Issue Owner: @zanyrenney

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 20, 2025
  2. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 21, 2025
  4. changed the title [-]iOS - Expense Reports - Report page cannot be dismissed by swiping to right[/-] [+][$250] iOS - Expense Reports - Report page cannot be dismissed by swiping to right[/+] on Mar 21, 2025
  5. melvin-bot commented on Mar 21, 2025

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 21, 2025
  7. melvin-bot commented on Mar 21, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

  8. zanyrenney commented on Mar 21, 2025

    @zanyrenney
    Contributor

    Added to quality.

  9. Pranavs09 commented on Mar 21, 2025

    @Pranavs09

    Proposal

    Please re-state the problem that we are trying to solve in this issue.
    On iOS, users are unable to swipe from the left edge of the screen to go back when viewing an Expense Report. This is inconsistent with standard iOS navigation behavior.

    What is the root cause of that problem?
    The screen is either:

    Presented modally with gesture support disabled, or
    Wrapped in a navigator or layout that blocks the native swipe gesture (e.g., ScrollView, custom pan responders, or modal presentation style).

    What changes do you think we should make in order to solve the problem?

    Ensure the Expense Report screen is pushed via a Stack.Navigator with gestureEnabled: true.
    Set presentation: 'card' to allow swipe-back gestures.
    Check for gesture conflicts from nested components like ScrollView or custom gestures and update them to allow edge swiping.
    Example:

    <Stack.Screen
      name="ExpenseReport"
      component={ExpenseReportScreen}
      options={{
        gestureEnabled: true,
        presentation: 'card',
      }}
    />
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    iOS UI test: Open an Expense Report and verify swipe-to-go-back gesture works.
    Navigation regression test: Confirm all report screens allow swipe-back unless explicitly disabled.
    Cross-platform test: Ensure no regressions on Android behavior.

    What alternative solutions did you explore? (Optional)

    Replacing modal presentation with custom transitions – ruled out for complexity and inconsistency with native gestures.
    Adding manual back gesture handling – not ideal since React Navigation already provides native support.

  10. mallenexpensify commented on Mar 24, 2025

    @mallenexpensify
    Contributor

    Was part of the reason you were able to swipe back because the report didn't load?
    Going to make as LOW for now.

  11. 55 remaining items

  12. changed the title [-][$500] iOS - Expense Reports - Report page cannot be dismissed by swiping to right[/-] [+][Due for payment 2025-05-20] [$500] iOS - Expense Reports - Report page cannot be dismissed by swiping to right[/+] on May 13, 2025
  13. melvin-bot commented on May 13, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on May 13, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-20. 🎊

    For reference, here are some details about the assignees on this issue:

    • @WojtekBoman does not require payment (Contractor)
    • @getusha requires payment through NewDot Manual Requests
  15. melvin-bot commented on May 13, 2025

    @melvin-bot

    @getusha @zanyrenney @getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. melvin-bot commented on May 20, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @WojtekBoman is from an agency-contributor and not due payment
    • Reviewer: @getusha owed $250 via NewDot

    BugZero Checklist (@zanyrenney)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1903125815331781283/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. zanyrenney commented on May 20, 2025

    @zanyrenney
    Contributor

    Hey @getusha please can you complete the checklist? We won't be able to move ahead with payment until it is complete.

  18. getusha commented on May 21, 2025

    @getusha
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/a

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/a

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • None

    Test:

    1. Launch Hybrid App
    2. Go to Search page > Reports.
    3. Tap bookmark icon.
    4. Go to (Expense Reports) / Reports.
    5. Open any expense reports.
    6. Verify if it's possible to swipe to right to go back.
    7. Reopen the expense report.
    8. Verify if the transition animation is shown when navigating back.

    Do we agree 👍 or 👎

  19. zanyrenney commented on May 21, 2025

    @zanyrenney
    Contributor

    Payment Summary

    • Contributor: @WojtekBoman is from an agency contributor and not due payment
    • Reviewer: @getusha owed $500 via NewDot - please request on ND.
  20. garrettmknight commented on Jun 26, 2025

    @garrettmknight
    Contributor

    $500 approved for @getusha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions