Skip to content

[Due for payment 2025-04-10] [$250] Incorrect Icon Color in Flight Details Option Row #58996

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.17-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Prerequisite: The user have booked flight trip.

  1. Navigate to Workspace where user have the trip report
  2. Click View Trip
  3. Click Trip Summary and observe the flight details in RHP

Expected Result:

The Icon color for the Modify trip and Trip support external link should use the grey color

Actual Result:

Icon color are in green

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Image

Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021904285720528943779
  • Upwork Job ID: 1904285720528943779
  • Last Price Increase: 2025-03-24
  • Automatic offers:
    • allgandalf | Contributor | 106659226
Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 24, 2025
  2. melvin-bot commented on Mar 24, 2025

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. m-natarajan commented on Mar 24, 2025

    @m-natarajan
    Author

    Proposal by @allgandalf

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Flight details option row icons are green. They should be icon color

    What is the root cause of that problem?

    we use theme.iconSuccessFill which is causing this bug:

    iconFill={theme.iconSuccessFill}

    What changes do you think we should make in order to solve the problem?

    We need to update it to the same colour which is used at other places. i.e. remove the iconFill, let it take the default value like other places. else we can explicitly set it to take the icon colour

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A this is a simple UI bug, alternatively we can simply mock onyx data then render the screen and verify that the icon colour is present for the menu item

    What alternative solutions did you explore? (Optional)

    N/A

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 24, 2025
  5. changed the title [-]Incorrect Icon Color in Flight Details Option Row[/-] [+][$250] Incorrect Icon Color in Flight Details Option Row[/+] on Mar 24, 2025
  6. melvin-bot commented on Mar 24, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 24, 2025
  8. melvin-bot commented on Mar 24, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

  9. neonbhai commented on Mar 24, 2025

    @neonbhai
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Incorrect Icon Color in Flight Details Option Row

    What is the root cause of that problem?

    This is caused by the incorrect color passed here:

    iconFill={theme.iconSuccessFill}

    and here:

    iconFill={theme.iconSuccessFill}

    What changes do you think we should make in order to solve the problem?

    We will omit the iconFill prop here and here as this would allow the MenuItem styles defined here to take over, which would give the correct styles consistent with other places in the App

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A simple UI bug, we will not need a test here

  10. alitoshmatov commented on Mar 25, 2025

    @alitoshmatov
    Contributor

    Pretty straightforward fix, we can with @allgandalf 's proposal

    C+ reviewed 🎀 👀 🎀

  11. melvin-bot commented on Mar 25, 2025

    @melvin-bot

    Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  12. 9 remaining items

  13. changed the title [-][$250] Incorrect Icon Color in Flight Details Option Row[/-] [+][Due for payment 2025-04-10] [$250] Incorrect Icon Color in Flight Details Option Row[/+] on Apr 3, 2025
  14. melvin-bot commented on Apr 3, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Apr 3, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.22-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-10. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Apr 3, 2025

    @melvin-bot

    @alitoshmatov / @allgandalf @lschurr @alitoshmatov / @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. allgandalf commented on Apr 4, 2025

    @allgandalf
    Contributor

    @alitoshmatov was the C+ so they will fill the checklist

  18. lschurr commented on Apr 9, 2025

    @lschurr
    Contributor

    Lil bump @alitoshmatov to handle the checklist.

  19. lschurr commented on Apr 10, 2025

    @lschurr
    Contributor

    Payment summary:

  20. alitoshmatov commented on Apr 11, 2025

    @alitoshmatov
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/52823/files#r2039184111

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: No discussion

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    No regression test needed, simple style fix

  21. JmillsExpensify commented on Apr 14, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @alitoshmatov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions