You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-10] [$250] Incorrect Icon Color in Flight Details Option Row #58996
Version Number: 9.1.17-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@dubielzyk-expensify Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
Prerequisite: The user have booked flight trip.
Navigate to Workspace where user have the trip report
Click View Trip
Click Trip Summary and observe the flight details in RHP
Expected Result:
The Icon color for the Modify trip and Trip support external link should use the grey color
Actual Result:
Icon color are in green
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
What changes do you think we should make in order to solve the problem?
We need to update it to the same colour which is used at other places. i.e. remove the iconFill, let it take the default value like other places. else we can explicitly set it to take the icon colour
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A this is a simple UI bug, alternatively we can simply mock onyx data then render the screen and verify that the icon colour is present for the menu item
What alternative solutions did you explore? (Optional)
changed the title [-]Incorrect Icon Color in Flight Details Option Row[/-][+][$250] Incorrect Icon Color in Flight Details Option Row[/+]on Mar 24, 2025
What changes do you think we should make in order to solve the problem?
We will omit the iconFill prop here and here as this would allow the MenuItem styles defined here to take over, which would give the correct styles consistent with other places in the App
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
changed the title [-][$250] Incorrect Icon Color in Flight Details Option Row[/-][+][Due for payment 2025-04-10] [$250] Incorrect Icon Color in Flight Details Option Row[/+]on Apr 3, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.22-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@alitoshmatov / @allgandalf@lschurr@alitoshmatov / @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No discussion
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Mar 24, 2025
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.m-natarajan commentedon Mar 24, 2025
Proposal by @allgandalf
Proposal
Please re-state the problem that we are trying to solve in this issue.
Flight details option row icons are green. They should be icon color
What is the root cause of that problem?
we use theme.iconSuccessFill which is causing this bug:
App/src/pages/Travel/TripDetailsPage.tsx
Line 110 in 4750e38
What changes do you think we should make in order to solve the problem?
We need to update it to the same colour which is used at other places. i.e. remove the iconFill, let it take the default value like other places. else we can explicitly set it to take the icon colour
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A this is a simple UI bug, alternatively we can simply mock onyx data then render the screen and verify that the icon colour is present for the menu item
What alternative solutions did you explore? (Optional)
N/A
[-]Incorrect Icon Color in Flight Details Option Row[/-][+][$250] Incorrect Icon Color in Flight Details Option Row[/+]melvin-bot commentedon Mar 24, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021904285720528943779
melvin-bot commentedon Mar 24, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (
External)neonbhai commentedon Mar 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Incorrect Icon Color in Flight Details Option Row
What is the root cause of that problem?
This is caused by the incorrect color passed here:
App/src/pages/Travel/TripDetailsPage.tsx
Line 110 in 351ac63
and here:
App/src/pages/Travel/TripDetailsPage.tsx
Line 126 in 351ac63
What changes do you think we should make in order to solve the problem?
We will omit the
iconFillprop here and here as this would allow theMenuItemstyles defined here to take over, which would give the correct styles consistent with other places in the AppWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A simple UI bug, we will not need a test here
alitoshmatov commentedon Mar 25, 2025
Pretty straightforward fix, we can with @allgandalf 's proposal
C+ reviewed 🎀 👀 🎀
melvin-bot commentedon Mar 25, 2025
Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
9 remaining items
[-][$250] Incorrect Icon Color in Flight Details Option Row[/-][+][Due for payment 2025-04-10] [$250] Incorrect Icon Color in Flight Details Option Row[/+]melvin-bot commentedon Apr 3, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 3, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.22-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 3, 2025
@alitoshmatov / @allgandalf @lschurr @alitoshmatov / @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
allgandalf commentedon Apr 4, 2025
@alitoshmatov was the C+ so they will fill the checklist
lschurr commentedon Apr 9, 2025
Lil bump @alitoshmatov to handle the checklist.
lschurr commentedon Apr 10, 2025
Payment summary:
alitoshmatov commentedon Apr 11, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/52823/files#r2039184111
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No discussion
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
No regression test needed, simple style fix
JmillsExpensify commentedon Apr 14, 2025
$250 approved for @alitoshmatov