Repository navigation
Closed
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2
Description
This is a list of follow up tasks related to the report/expense preview we're aware of to handle after this PR has merged: #58479
HIGH:
- Add the amount in confirmation button (i.e Submit $20.00) @JakubKorytko working on this one [Better Expense Report View] Add the amount in confirmation button #59715
- Navigating to the report view when clicking the preview - will be worked on once we are ready to bring the new report view to Inbox too - @Kicu works on this here Display MoneyRequestReport on Inbox and navigate to it from preview #60119
- Cannot swipe down or up - [Due for payment 2025-04-18] [$125] [Better Expense Report View] mWeb - Can't swipe down/up on the report in the Workspace #59536 @Guccio163 looking into this
- RBR logic to extract specific errors to display @JakubKorytko picking this up
MEDIUM:
- Have the arrow controls change state at the same time avoiding the cascading effect - Exported here [$125] [Better Expense Report View] Ensure the carousel arrows change style at the same time #59727
- [Due for payment 2025-04-25] [$250] [Better Expense Report View] Use aspect-ratio for receipt thumbnail area of expense previews #59555
- Manual horizontal scrolling of the carousel - handled here [Waiting on Upstream PR to Remove Patch] [Better Expense Report View] Fix manual scrolling in the report carousel on web #60180
- strip markdown/HTML out of expense previews - will be handled here Strip the new expense preview of the markdown and html #59733
- swap approved/paid icons: [Due for payment 2025-04-10] [$125] [Better Expense Report View] Wrong icon is displayed for approved and paid report preview #59455
- delete
}from action button: [Due for payment 2025-04-14] [Due for payment 2025-04-10] [Better Expense Report View] } symbol after the amount in Review button #59456 - fix not working last navigation dot in narrow screen: [Due for payment 2025-04-16] [Better Expense Report View] Carousel does not show the last expense when the last dot is clicked #59463
- not deleting exactly in the same moment as thread in
ReportAction?: [Due for payment 2025-04-16] [Better Expense Report View] Reply count is not removed together with expense preview after deleting expense #59465 - fix disabling
>arrow after resizing: [Due for payment 2025-04-16] [Better Expense Report View] button is not disabled when the carousel is at the end of the expense preview #59466 - The merchant is overflowing on ios native preview (at least there) in the carousel, check the attached image below [Better Expense Report View] Fix TransactionPreview merchant overflowing on mobile devices and Export button display in MoneyRequestReportPreview #59718
- Clean-up Invoice, split, and selfDM previews [Better Expense Report View] Remove RBR logic from Preview & clean-up invoice, split, and self-DM previews #59811
- The Expense level RBR is not showing any violation message in some cases https://expensify.slack.com/archives/C07NMDKEFMH/p1743665105390399?thread_ts=1743665068.343459&cid=C07NMDKEFMH
- Update the docs of this method and move it to utils [Better Expense Report View] Remove reply count together with expense preview after deleting last expense #59679 (comment)
Assigned a bunch of us to keep track of it. Let's link out to where the items are being taken care of as we chomp through them. Thanks!
Issue Owner
Current Issue Owner: @trjExpensifyMetadata
Metadata
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Apr 1, 2025
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
Guccio163 commentedon Apr 1, 2025
I'm adding 6 issues that emerged more:
✅ swap approved/paid icons: [Due for payment 2025-04-10] [$125] [Better Expense Report View] Wrong icon is displayed for approved and paid report preview #59455
✅ delete
}from action button: [Due for payment 2025-04-14] [Due for payment 2025-04-10] [Better Expense Report View] } symbol after the amount in Review button #59456ReportAction?: [Due for payment 2025-04-16] [Better Expense Report View] Reply count is not removed together with expense preview after deleting expense #59465>arrow after resizing: [Due for payment 2025-04-16] [Better Expense Report View] button is not disabled when the carousel is at the end of the expense preview #59466✅ already handled in a separate PR
Guccio163 commentedon Apr 1, 2025
Great, if I checked correctly I'm assigned to all of them, thanks @mountiny!
mountiny commentedon Apr 1, 2025
Some of them can be handled by contributors - lets focus on the real blockers there (not everything is behind beta)
Guccio163 commentedon Apr 2, 2025
Okay, so out of 5 issues and 7 yet-to-do's mentioned above, only 2 are marked as deploy blockers: 'swap approved/paid icons' and 'delete } from action button'. Are any of the other issues high priority? One of blockers is being handled by someone else and I already fixed the other one since it's just a typo - should I rush with a PR for this single fix, or do we wait and group a couple of them more? Some of the issues here are really complex, so they can certainly take more than the end of the week to fix 📆. cc: @mountiny
mountiny commentedon Apr 2, 2025
smaller prs are better
I would do:
The rest is handled
48 remaining items
melvin-bot commentedon Apr 16, 2025
[-][Due for payment 2025-04-23] [Better Expense Report View] Preview follow-ups[/-][+][Due for payment 2025-04-25] [Due for payment 2025-04-23] [Better Expense Report View] Preview follow-ups[/+]melvin-bot commentedon Apr 18, 2025
melvin-bot commentedon Apr 18, 2025
[-][Due for payment 2025-04-25] [Due for payment 2025-04-23] [Better Expense Report View] Preview follow-ups[/-][+][Better Expense Report View] Preview follow-ups[/+]mountiny commentedon Apr 25, 2025
Handling this in a separate issue, so we can close this one, great job everyone