You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-28] [$250] Expense preview - Expense preview shows "Receiver > Payer" instead of "Payer > Receiver" #59526
Version Number: 9.1.22-2 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #58479 Email or phone of affected tester (no customers):applausetester+sdsoidsj@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail account,
Go to staging.new.expensify.com
Go to 1:1 DM.
Click + > Pay user.
Enter amount > Next.
Click Pay elsewhere.
Expected Result:
The expense preview should show that "Payer > Receiver" (we can double confirm this iin Reports).
Actual Result:
The expense preview shows "Receiver > Payer" instead.
@jponikarchuk Just out of curiosity, do we really need to Login with Expensifail account? Is there some UIs limited to Expensifail accounts? cc @rushatgabhane
Activity
melvin-bot commentedon Apr 2, 2025
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.zanyrenney commentedon Apr 2, 2025
adding external
zanyrenney commentedon Apr 2, 2025
It is a minor UI adjustment, but if this is being stored or displayed incorrectly, we'll want a deeper investigation.
[-]Expense preview - Expense preview shows "Receiver > Payer" instead of "Payer > Receiver"[/-][+][$250] Expense preview - Expense preview shows "Receiver > Payer" instead of "Payer > Receiver"[/+]melvin-bot commentedon Apr 2, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021907390149084405396
melvin-bot commentedon Apr 2, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)samranahm commentedon Apr 2, 2025
@jponikarchuk Just out of curiosity, do we really need to Login with Expensifail account? Is there some UIs limited to Expensifail accounts? cc @rushatgabhane
ChavdaSachin commentedon Apr 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense preview - Expense preview shows "Receiver > Payer" instead of "Payer > Receiver"
What is the root cause of that problem?
Small logical mistake during implementation here, managerID and ownerAccountID passed here are passed in reverse order.
App/src/libs/TransactionPreviewUtils.ts
Lines 54 to 55 in 9a58e7d
What changes do you think we should make in order to solve the problem?
Change the order of managerID and ownerAccountID passed here.
App/src/libs/TransactionPreviewUtils.ts
Lines 54 to 55 in 9a58e7d
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Could be corrected by fixing the function body of
chooseIDBasedOnAmountto work inversely, or any other small similar change.38 remaining items
zanyrenney commentedon Apr 28, 2025
hey @ChavdaSachin - you never applied to the job.
zanyrenney commentedon Apr 28, 2025
Please can you apply here? https://www.upwork.com/jobs/~021907390149084405396 I just tried to invite you to the job, but I'm unable to find you on upwork. @ChavdaSachin
ChavdaSachin commentedon Apr 28, 2025
@zanyrenney applied for the job.
Upwork profile: https://www.upwork.com/freelancers/~016a0f0a12bce54a49
ChavdaSachin commentedon Apr 29, 2025
@zanyrenney can you please accept the proposal and release the payment.
thank you.
ChavdaSachin commentedon Apr 30, 2025
@zanyrenney bump on above ^
zanyrenney commentedon May 1, 2025
taking a look!
zanyrenney commentedon May 1, 2025
@ChavdaSachin all rehired!
zanyrenney commentedon May 1, 2025
offer is pending!
ChavdaSachin commentedon May 1, 2025
Accepted the offer
zanyrenney commentedon May 1, 2025
Payment summary
Reviewer: @rushatgabhane owed $250 via NewDot - please request $250 via ND.
ROLE: @ChavdaSachin paid $(AMOUNT) via Upwork (LINK) - paid $250 via upwork.
garrettmknight commentedon May 20, 2025
$250 approved for @rushatgabhane