Skip to content

[Due for payment 2025-04-28] [$250] Expense preview - Expense preview shows "Receiver > Payer" instead of "Payer > Receiver" #59526

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.22-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #58479
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account,
  1. Go to staging.new.expensify.com
  2. Go to 1:1 DM.
  3. Click + > Pay user.
  4. Enter amount > Next.
  5. Click Pay elsewhere.

Expected Result:

The expense preview should show that "Payer > Receiver" (we can double confirm this iin Reports).

Actual Result:

The expense preview shows "Receiver > Payer" instead.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4
Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021907390149084405396
  • Upwork Job ID: 1907390149084405396
  • Last Price Increase: 2025-04-02
Issue OwnerCurrent Issue Owner: @zanyrenney

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 2, 2025
  2. melvin-bot commented on Apr 2, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. zanyrenney commented on Apr 2, 2025

    @zanyrenney
    Contributor

    adding external

  4. zanyrenney commented on Apr 2, 2025

    @zanyrenney
    Contributor

    It is a minor UI adjustment, but if this is being stored or displayed incorrectly, we'll want a deeper investigation.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 2, 2025
  6. changed the title [-]Expense preview - Expense preview shows "Receiver > Payer" instead of "Payer > Receiver"[/-] [+][$250] Expense preview - Expense preview shows "Receiver > Payer" instead of "Payer > Receiver"[/+] on Apr 2, 2025
  7. melvin-bot commented on Apr 2, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 2, 2025
  9. melvin-bot commented on Apr 2, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  10. samranahm commented on Apr 2, 2025

    @samranahm
    Contributor

    @jponikarchuk Just out of curiosity, do we really need to Login with Expensifail account? Is there some UIs limited to Expensifail accounts? cc @rushatgabhane

  11. ChavdaSachin commented on Apr 2, 2025

    @ChavdaSachin
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Expense preview - Expense preview shows "Receiver > Payer" instead of "Payer > Receiver"

    What is the root cause of that problem?

    Small logical mistake during implementation here, managerID and ownerAccountID passed here are passed in reverse order.

    const fromID = chooseIDBasedOnAmount(amount, managerID, ownerAccountID);
    const toID = chooseIDBasedOnAmount(amount, ownerAccountID, managerID);

    What changes do you think we should make in order to solve the problem?

    Change the order of managerID and ownerAccountID passed here.

    const fromID = chooseIDBasedOnAmount(amount, managerID, ownerAccountID);
    const toID = chooseIDBasedOnAmount(amount, ownerAccountID, managerID);

        const fromID = chooseIDBasedOnAmount(amount, ownerAccountID, managerID);
        const toID = chooseIDBasedOnAmount(amount, managerID, ownerAccountID);

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    Could be corrected by fixing the function body of chooseIDBasedOnAmount to work inversely, or any other small similar change.

  12. 38 remaining items

  13. zanyrenney commented on Apr 28, 2025

    @zanyrenney
    Contributor

    hey @ChavdaSachin - you never applied to the job.

  14. zanyrenney commented on Apr 28, 2025

    @zanyrenney
    Contributor

    Please can you apply here? https://www.upwork.com/jobs/~021907390149084405396 I just tried to invite you to the job, but I'm unable to find you on upwork. @ChavdaSachin

  15. ChavdaSachin commented on Apr 28, 2025

    @ChavdaSachin
    Contributor
  16. ChavdaSachin commented on Apr 29, 2025

    @ChavdaSachin
    Contributor

    @zanyrenney can you please accept the proposal and release the payment.
    thank you.

  17. ChavdaSachin commented on Apr 30, 2025

    @ChavdaSachin
    Contributor

    @zanyrenney bump on above ^

  18. zanyrenney commented on May 1, 2025

    @zanyrenney
    Contributor

    taking a look!

  19. zanyrenney commented on May 1, 2025

    @zanyrenney
    Contributor

    @ChavdaSachin all rehired!

  20. zanyrenney commented on May 1, 2025

    @zanyrenney
    Contributor

    offer is pending!

  21. ChavdaSachin commented on May 1, 2025

    @ChavdaSachin
    Contributor

    Accepted the offer

  22. zanyrenney commented on May 1, 2025

    @zanyrenney
    Contributor

    Payment summary

    Reviewer: @rushatgabhane owed $250 via NewDot - please request $250 via ND.
    ROLE: @ChavdaSachin paid $(AMOUNT) via Upwork (LINK) - paid $250 via upwork.

  23. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson May 1, 2025
  24. garrettmknight commented on May 20, 2025

    @garrettmknight
    Contributor

    $250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions