You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Attendees - Attendees field shows "Attendees per person" while receipt is scanning #59597
Version Number: 9.1.23-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail:#58120 Email or phone of affected tester (no customers):sdjmosdjojsoid@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Click + > Create expense > Scan.
Upload a receipt.
On confirmation page, click Attendees.
Select another user and click Save.
Note that Attendees field shows "Attendees • MYR 0.00 per person".
Create the expense.
Go to transaction thread.
Expected Result:
Attendees field will show "Attendees • MYR 0.00 per person" in the transaction thread while the receipt is scanning.
Actual Result:
Attendees field shows "Attendees per person" in the transaction thread while the receipt is scanning.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I added a blocker label, as it is not repro on prod, it is a new feature.
If there is no need to add this label, please let me know, and I will delete it. If not, you can also do it yourself.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Use the same format
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][Due for payment 2025-04-16] [Due for payment 2025-04-14] Attendees - Attendees field shows "Attendees per person" while receipt is scanning[/-][+]Attendees - Attendees field shows "Attendees per person" while receipt is scanning[/+]on Apr 16, 2025
Since this last PR is still being worked on, I've updated the GH to remove the payment notices. @allroundexperts, please leave a comment when you are ready, and we can update the GH again. For now, I'll remove myself here, and Vic should be back for the payment date when the next PR is live. If anything changes this week, @ me and I'll hop back in to help.
Activity
melvin-bot commentedon Apr 3, 2025
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 3, 2025
Triggered auto assignment to @roryabraham (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 3, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 3, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Apr 3, 2025
I added a
blockerlabel, as it is not repro on prod, it is a new feature.If there is no need to add this label, please let me know, and I will delete it. If not, you can also do it yourself.
samranahm commentedon Apr 3, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-03 16:58:27 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Attendees - Attendees field shows "Attendees per person" while receipt is scanning
What is the root cause of that problem?
Here
App/src/components/MoneyRequestConfirmationListFooter.tsx
Line 594 in 9a58e7d
we have another format as compared to
App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 767 in 9a58e7d
What changes do you think we should make in order to solve the problem?
We need to change this translation to
App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 767 in 9a58e7d
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Use the same format
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
jasperhuangg commentedon Apr 3, 2025
Reached out here to @allroundexperts to see if they can fix this, coming from #58120
29 remaining items
melvin-bot commentedon Apr 16, 2025
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mallenexpensify commentedon Apr 16, 2025
@alexpensify Vic is out, can you please wrap this issue up? Thx
allroundexperts commentedon Apr 16, 2025
@mallenexpensify This is still being worked on here. Let's keep this open.
[-][Due for payment 2025-04-16] [Due for payment 2025-04-14] Attendees - Attendees field shows "Attendees per person" while receipt is scanning[/-][+]Attendees - Attendees field shows "Attendees per person" while receipt is scanning[/+]alexpensify commentedon Apr 16, 2025
Since this last PR is still being worked on, I've updated the GH to remove the payment notices. @allroundexperts, please leave a comment when you are ready, and we can update the GH again. For now, I'll remove myself here, and Vic should be back for the payment date when the next PR is live. If anything changes this week, @ me and I'll hop back in to help.